Skip to content

Commit e43c3f7

Browse files
Arthur-Milchiorlukstbit
authored andcommitted
Add unbreakable space after digits
As a matter of styleguide, I recall it was recommender that a number using digits should be on the same line as the thing being counted. I found in Ankidroid a line ending with numbers While creating #18341 I found that we may end up with lines ending with numbers. I don't know whether this rule is universal, so I only add a comment requesting translators to consider this. Still, I believe it's useful to indicate that this is an option as translators may not know it.
1 parent 400ec1f commit e43c3f7

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

AnkiDroid/src/main/res/values/02-strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@
328328
<string name="show_cards" comment="Label for toggle cards button in BrowserOptionsDialog">Cards</string>
329329
<string name="show_notes" comment="Label for toggle notes button in BrowserOptionsDialog">Notes</string>
330330
<string name="toggle_cards_notes">Toggle Cards/Notes</string>
331-
<string name="truncate_content_help">Truncate the height of each row of the Browser to show only first 3 lines of content</string>
331+
<string name="truncate_content_help">Truncate the height of each row of the Browser to show only first 3&#160;lines of content</string>
332332
<string name="browser_options_dialog_heading">Browser options</string>
333333

334334
<string name="audio_saved">Recording saved</string>

AnkiDroid/src/main/res/values/03-dialogs.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@
140140
<string name="error_deleting_image">Error deleting image</string>
141141
<string name="failed_to_apply_background_image">Failed to apply background image %s</string>
142142
<string name="background_image_too_large">Deck Picker background too large</string>
143-
<string name="image_max_size_allowed">Maximum image size %d MB allowed</string>
143+
<string name="image_max_size_allowed" comment="Consider keeping the unbreakable space after the digit">Maximum image size %d&#160;MB allowed</string>
144144
<string name="image_dimensions_too_large">Image dimensions are too large (%1$d × %2$d)</string>
145145

146146
<!-- Global Intent handler -->
@@ -190,8 +190,8 @@
190190

191191
<!--Sync-->
192192
<plurals name="sync_automatic_sync_needs_more_time">
193-
<item quantity="one">An automatic sync may be triggered in %d second</item>
194-
<item quantity="other">An automatic sync may be triggered in %d seconds</item>
193+
<item quantity="one" comment="Consider keeping the unbreakable space after the digit">An automatic sync may be triggered in %d&#160;second</item>
194+
<item quantity="other" comment="Consider keeping the unbreakable space after the digit">An automatic sync may be triggered in %d&#160;seconds</item>
195195
</plurals>
196196
<string name="metered_sync_data_warning">Your internet provider may charge money for data use</string>
197197
<string name="deck_picker_new">Number of new cards to see today in this deck.</string>

AnkiDroid/src/main/res/values/08-widget.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@
4848
<string name="deck_removed_from_widget" comment="Snackbar when deck is removed from widget">Deck removed</string>
4949
<string name="deck_already_selected_message" comment="Snackbar when user try to select the same deck again">This deck is already selected</string>
5050
<plurals name="deck_limit_reached">
51-
<item quantity="one">You can select up to %d deck.</item>
52-
<item quantity="other">You can select up to %d decks.</item>
51+
<item quantity="one" comment="Consider keeping the unbreakable space after the digit">You can select up to %d&#160;deck.</item>
52+
<item quantity="other" comment="Consider keeping the unbreakable space after the digit">You can select up to %d&#160;decks.</item>
5353
</plurals>
5454
<string name="empty_widget_state" comment="To denote the widget is empty">Missing deck. Tap to reconfigure.</string>
5555
<string name="empty_collection_state_in_widget" comment="To denote the collection is empty">Collection is empty, use app to add decks then reconfigure</string>"

AnkiDroid/src/main/res/values/09-backup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
--><resources>
2121

2222
<string name="backup_deck_no_storage_left">Backup not saved. Not enough space left on your storage. Lower the backup depth or remove some other files.</string>
23-
<string name="storage_warning">Less than %d MB space on your storage left.\nFree some space to avoid data loss.</string>
23+
<string name="storage_warning" comment="Consider keeping the unbreakable space after the digit">Less than %d&#160;MB space on your storage left.\nFree some space to avoid data loss.</string>
2424
<string name="backup_restore" maxLength="28">Restore from backup</string>
2525
<string name="backup_new_collection">New collection</string>
2626
<string name="backup_del_collection">Delete collection and create new one</string>

AnkiDroid/src/main/res/values/10-preferences.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
<string name="notification_pref_title" maxLength="41">Notify when</string>
128128
<string name="never_notify">Never notify</string>
129129
<string name="notify_when_pending">Pending messages available</string>
130-
<string name="notification_minimum_cards_due">More than %d cards due</string>
130+
<string name="notification_minimum_cards_due" comment="Consider keeping the unbreakable space after the digit">More than %d&#160;cards due</string>
131131
<string name="notification_minimum_cards_due_vibrate" maxLength="41">Vibrate</string>
132132
<string name="notification_minimum_cards_due_blink" maxLength="41">Blink light</string>
133133
<string name="select_locale_title">Select language</string>
@@ -147,7 +147,7 @@
147147
<string name="show_estimates" maxLength="41">Show button time</string>
148148
<string name="show_estimates_summ">Show next review time on answer buttons</string>
149149
<string name="show_large_answer_buttons" maxLength="41">Show large answer buttons</string>
150-
<string name="show_large_answer_buttons_summ">Show answer button in 2 rows</string>
150+
<string name="show_large_answer_buttons_summ">Show answer button in 2&#160;rows</string>
151151
<string name="show_top_bar" maxLength="41">Show top bar</string>
152152
<string name="show_top_bar_summary">Show card counts, answer timer, flag and mark in top bar</string>
153153
<string name="show_progress" maxLength="41">Show remaining</string>
@@ -159,8 +159,8 @@
159159
<string name="time_limit" maxLength="41">Timebox time limit</string>
160160
<string name="day_offset_with_description" maxLength="41">Start of next day</string>
161161
<plurals name="day_offset_summ" comment="%d is going to be replaced with the number of hours past midnight. It can be replaced if something else suits better the translation">
162-
<item quantity="one">%d hour past midnight</item>
163-
<item quantity="other">%d hours past midnight</item>
162+
<item quantity="one" comment="Consider keeping the unbreakable space after the digit">%d&#160;hour past midnight</item>
163+
<item quantity="other" comment="Consider keeping the unbreakable space after the digit">%d&#160;hours past midnight</item>
164164
</plurals>
165165
<string name="pref_keep_screen_on" maxLength="41">Keep screen on</string>
166166
<string name="pref_keep_screen_on_summ">Disable screen timeout</string>

0 commit comments

Comments
 (0)