chore: convert MultiColumnViewHolder to ViewBinding

Issue 11116

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/browser/BrowserMultiColumnAdapter.kt

@@ -25,10 +25,8 @@ import android.text.TextUtils
 import android.util.TypedValue
 import android.view.LayoutInflater
 import android.view.MotionEvent
-import android.view.View
 import android.view.ViewGroup
 import android.widget.CheckBox
-import android.widget.LinearLayout
 import android.widget.TextView
 import androidx.annotation.ColorInt
 import androidx.annotation.IdRes
@@ -42,9 +40,9 @@ import com.ichi2.anki.AnkiDroidApp.Companion.sharedPrefs
 import com.ichi2.anki.Flag
 import com.ichi2.anki.R
 import com.ichi2.anki.common.annotations.NeedsTest
+import com.ichi2.anki.databinding.CardItemBrowserBinding
 import com.ichi2.anki.utils.android.darkenColor
 import com.ichi2.anki.utils.android.lightenColorAbsolute
-import com.ichi2.anki.utils.ext.findViewById
 import com.ichi2.themes.Themes
 import com.ichi2.utils.removeChildren
 import net.ankiweb.rsdroid.BackendException
@@ -76,11 +74,9 @@ class BrowserMultiColumnAdapter(
     private var originalTextSize = -1.0f
 
     inner class MultiColumnViewHolder(
-        holder: View,
-    ) : RecyclerView.ViewHolder(holder) {
+        private val binding: CardItemBrowserBinding,
+    ) : RecyclerView.ViewHolder(binding.root) {
         var id: CardOrNoteId? = null
-        private val mainView = findViewById<LinearLayout>(R.id.card_item_browser)
-        private val checkBoxView = findViewById<CheckBox>(R.id.card_checkbox)
 
         val columnViews = mutableListOf<TextView>()
 
@@ -89,16 +85,16 @@ class BrowserMultiColumnAdapter(
                 if (field == value) return
                 field = value
                 // remove the past set of columns
-                mainView.removeChildren { it !is CheckBox }
+                binding.root.removeChildren { it !is CheckBox }
                 columnViews.clear()
 
                 val layoutInflater = LayoutInflater.from(context)
 
                 // inflates and returns the inflated view
                 fun inflate(
                     @IdRes id: Int,
-                ) = layoutInflater.inflate(id, mainView, false).apply {
-                    mainView.addView(this)
+                ) = layoutInflater.inflate(id, binding.root, false).apply {
+                    binding.root.addView(this)
                 }
 
                 // recreate the columns and the dividers
@@ -133,7 +129,7 @@ class BrowserMultiColumnAdapter(
                 }
                 return@setOnTouchListener false
             }
-            checkBoxView.setOnClickListener {
+            binding.rowSelectedCheckBox.setOnClickListener {
                 id?.let { id ->
                     Timber.d("Tapped on checkbox: %s", id)
                     onTap(id)
@@ -153,11 +149,11 @@ class BrowserMultiColumnAdapter(
             } ?: false
 
         fun setInMultiSelect(inMultiSelect: Boolean) {
-            checkBoxView.isVisible = inMultiSelect
+            binding.rowSelectedCheckBox.isVisible = inMultiSelect
         }
 
         fun setIsSelected(value: RowIsSelected) {
-            checkBoxView.isChecked = value
+            binding.rowSelectedCheckBox.isChecked = value
         }
 
         @NeedsTest("17731 - maybe check all activities load in dark mode, at least check this code")
@@ -244,11 +240,9 @@ class BrowserMultiColumnAdapter(
         parent: ViewGroup,
         viewType: Int,
     ): MultiColumnViewHolder {
-        val view =
-            LayoutInflater
-                .from(parent.context)
-                .inflate(R.layout.card_item_browser, parent, false)
-        return MultiColumnViewHolder(view)
+        val layoutInflater = LayoutInflater.from(context)
+        val binding = CardItemBrowserBinding.inflate(layoutInflater, parent, false)
+        return MultiColumnViewHolder(binding)
     }
 
     override fun getItemCount(): Int = rowCollection.size

AnkiDroid/src/main/res/layout/card_item_browser.xml

@@ -7,7 +7,7 @@
     xmlns:tools="http://schemas.android.com/tools">
 
     <CheckBox
-        android:id="@+id/card_checkbox"
+        android:id="@+id/row_selected_check_box"
         android:focusable="false"
         android:focusableInTouchMode="false"
         android:layout_width="wrap_content"