Skip to content

Commit f98b5ea

Browse files
snowtimeglassdavid-allison
authored andcommitted
fix: custom study card state menu overflow
`minHeight` is no longer enforced, so use `paddingVertical` if the height is over `minHeight`
1 parent 084329c commit f98b5ea

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ class CustomStudyDialog : AnalyticsDialogFragment() {
308308
android.R.layout.simple_spinner_item,
309309
CustomStudyCardState.entries.map { it.labelProducer() },
310310
).apply {
311-
setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item)
311+
setDropDownViewResource(R.layout.multiline_spinner_item)
312312
}
313313
}
314314
val editText =
@@ -590,7 +590,9 @@ class CustomStudyDialog : AnalyticsDialogFragment() {
590590
NewCardsOnly({ TR.customStudyNewCardsOnly() }, CramKind.CRAM_KIND_NEW),
591591
DueCardsOnly({ TR.customStudyDueCardsOnly() }, CramKind.CRAM_KIND_DUE),
592592
ReviewCardsRandom({ TR.customStudyAllReviewCardsInRandomOrder() }, CramKind.CRAM_KIND_REVIEW),
593-
AllCardsRandom({ TR.customStudyAllCardsInRandomOrderDont() }, CramKind.CRAM_KIND_ALL),
593+
AllCardsRandom({
594+
TR.customStudyAllCardsInRandomOrderDont() + "Afddsfgjdskfhdshfjkdshfjshfkshdjfkhdsjkfhdsjkfhjkdsfhkjdsfh"
595+
}, CramKind.CRAM_KIND_ALL),
594596
}
595597

596598
/**

AnkiDroid/src/main/res/layout/multiline_spinner_item.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
style="?android:attr/spinnerDropDownItemStyle"
2020
android:singleLine="false"
2121
android:maxLines="5"
22+
android:paddingVertical="8dp"
2223
android:layout_width="match_parent"
2324
android:layout_height="wrap_content"
2425
android:minHeight="?attr/dropdownListPreferredItemHeight"

0 commit comments

Comments
 (0)