Instant Card: Double "discard changes" window appears on Android "Back" swipe gesture

[david-allison]

• Enable the swipe gestures to go back in Android settings
• Highlight text: FSRS sees only the first 64 reviews per card
• Share text to AnkiDroid - instant card
  • Tap 64
• Swipe from the right of the screen to go back (Android gesture)
• Discard changes is shown on the "touch down" of the tap
• Discard changes is shown again when the swipe is released

OR

If the swipe is slow
The "back" gesture closes the Discard Changes modal

AnkiDroid Version = 2.21alpha8-debug (a9b95293f35b57857c96ef47232fe168034383e7)
Backend Version = 0.1.48-anki24.11 (24.11 c47638ca36f99dd4f3b81ae82d964aec66e392e0)
Android Version = 14 (SDK 34)
ProductFlavor = play
Device Info = samsung | samsung | o1s | o1sxeea | SM-G991B | exynos2100
Webview User Agent = Mozilla/5.0 (Linux; Android 14; SM-G991B Build/UP1A.231005.007; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/131.0.6778.262 Mobile Safari/537.36
ACRA UUID = 9ff2e57a-1926-4d25-b1b9-05453c01c54b
FSRS = 1.4.3 (Enabled: true)
Crash Reports Enabled = false

[Aditya13s]

Started working on it

[Arthur-Milchior]

@Aditya13s please don't. Unless you've already started.
It's a good first issue. We want to keep some for the sake of onboarding new contributors. There is a reason why David didn't do it even if it's simple.
Experienced contributors closing good first issue makes it harder to find new good contributor

[adnanrangrej]

Working on it.

[MritunjayTiwari14]

Working on it.

Sorry, i was not able to reply that i started working on this issue after Arthur Milchior told that this issue is for beginners.

[adnanrangrej]

Working on it.

Sorry, i was not able to reply that i started working on this issue after Arthur Milchior told that this issue is for beginners.

No problem.

[MritunjayTiwari14]

Working on it.

Sorry, i was not able to reply that i started working on this issue after Arthur Milchior told that this issue is for beginners.

No problem.

Maybe we can work together on this issue? I was able to fix the Double pop up of Discard Dialog Box through Flags, but i am still trying to figure out how to resolve that opening and closing of discard dialog box due to both swipe gesture and back button operated upon simultaneously.

[criticalAY]

The reason: the dialog is set to show a discard dialog in case any touch outside the dialog, and then we have a back callback that also triggers the discard dialog so what's happening is ->Touch outside is registered then the back callback is registered

[Sahil06012002]

Hello @david-allison ,

It looks like this issue has been inactive for a while. I’ve raised a PR to address it.

PR: #17907
cc: @criticalAY could you please review the changes when you have some time.