Crash on closing reviewer

[user1823]

Checked for duplicates?

• This issue is not a duplicate

Does it also happen in the desktop version?

• This bug does not occur in the latest version of Anki Desktop

What are the steps to reproduce this bug?

After answering one card, I pressed the back button to close the reviewer and the app crashed.

Expected behaviour

No crash.

Debug info

AnkiDroid Version = 2.21alpha9 (b4396e8d4199e1bfe51ea56809cdf073c9b9c5ad)
Backend Version = 0.1.48-anki24.11 (24.11 c47638ca36f99dd4f3b81ae82d964aec66e392e0)
Android Version = 13 (SDK 33)
ProductFlavor = full
Device Info = motorola | motorola | rhodei | rhodei_g | moto g62 5G | qcom
Webview User Agent = Mozilla/5.0 (Linux; Android 13; moto g62 5G Build/T1SSIS33.1-75-7-12; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/132.0.6834.79 Mobile Safari/537.36
ACRA UUID = 38b5ca07-ddb1-4b0e-9d8c-30e3ac117703
FSRS = 1.4.3 (Enabled: true)
Crash Reports Enabled = true

(Optional) Anything else you want to share?

No response

Research

• I have checked the manual and the FAQ and could not find a solution to my issue
• (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)

[david-allison]

https://ankidroid.org/acra/app/1/bug/279367/report/debf60b6-4c62-45c0-8bd9-22318dae41ec

java.lang.ClassCastException: android.widget.FrameLayout$LayoutParams cannot be cast to F.e
	at com.ichi2.anki.DeckPicker$onDecksLoaded$2$invokeSuspend$$inlined$doOnLayout$1.onLayoutChange(View.kt:55)
	at android.view.View.layout(View.java:23832)
	at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1103)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.onLayout(SwipeRefreshLayout.java:689)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1213)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:899)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:919)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1213)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:899)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:919)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at androidx.drawerlayout.widget.DrawerLayout.onLayout(DrawerLayout.java:1263)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at com.android.internal.policy.DecorView.onLayout(DecorView.java:830)
	at android.view.View.layout(View.java:23814)
	at android.view.ViewGroup.layout(ViewGroup.java:6428)
	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4161)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3538)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2476)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9303)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1231)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
	at android.view.Choreographer.doCallbacks(Choreographer.java:899)
	at android.view.Choreographer.doFrame(Choreographer.java:832)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
	at android.os.Handler.handleCallback(Handler.java:984)
	at android.os.Handler.dispatchMessage(Handler.java:104)
	at android.os.Looper.loopOnce(Looper.java:238)
	at android.os.Looper.loop(Looper.java:357)
	at android.app.ActivityThread.main(ActivityThread.java:8088)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:957)

Strong suspicion:

Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

Lines 2265 to 2267 in a459da0

	val layoutParams = fabLinearLayout.layoutParams as CoordinatorLayout.LayoutParams
	layoutParams.setMargins(0, 0, 0, reviewSummaryTextView.height / 2)
	fabLinearLayout.layoutParams = layoutParams

[david-allison]

Bisected. Issue:

• Fix fab size in landscape orientation - 2f656e0
• Fix minor UI issue for fab in landscape orientation #17861

along with the above cast.

java.lang.ClassCastException: android.widget.FrameLayout$LayoutParams cannot be cast to androidx.coordinatorlayout.widget.CoordinatorLayout$LayoutParams
    at com.ichi2.anki.DeckPicker$onDecksLoaded$2$invokeSuspend$$inlined$doOnLayout$1.onLayoutChange(View.kt:54)

@lukstbit

[mikehardy]

Thanks as ever for the rapid testing and good reports @user1823 - much appreciated.

I think I've got a fix for this one, and there is a fix posted for the other crash you logged that seems to work as well