Deck description dialog doesn't have tap outside to cancel

[ZornHadNoChoice]

Checked for duplicates?

• This issue is not a duplicate

Does it also happen in the desktop version?

• This bug does not occur in the latest version of Anki Desktop

What are the steps to reproduce this bug?

The edit deck description dialog doesn't go back if you tap outside it.

Expected behaviour

It should go back/bring up the confirmation dialog.

Debug info

AnkiDroid Version = 2.22.3 (4f2ec681da36b8307a865f05192498b8425adf0f)  
Backend Version = 0.1.60-anki25.07.5 (25.07.5 7172b2d26684c7ef9d10e249bd43dc5bf73ae00c)  
Android Version = 13 (SDK 33)  
ProductFlavor = play  
Device Info = Xiaomi | POCO | mondrian | mondrian_global | 23013PC75G | qcom  
Webview User Agent = Mozilla/5.0 (Linux; Android 13; 23013PC75G Build/TKQ1.220905.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/138.0.7204.179 Mobile Safari/537.36  
ACRA UUID = 3792582f-98ac-430e-ae42-4ace0156bf29  
FSRS = 4.1.1 (Enabled: true)  
Crash Reports Enabled = true

(Optional) Anything else you want to share?

No response

Research

• I have checked the manual and the FAQ and could not find a solution to my issue
• (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)

[lukstbit]

This is going to be hard to implement because the event for "touching outside" is not really available to bind to(see comment in the original issue #18748).

It should go back/bring up the confirmation dialog.

Should it really be doing this? I've looked through some of Google's app and they seem to quietly drop user changes when dismissing dialogs with tap outside. Maybe you have some examples of the opposite behavior.

[ZornHadNoChoice]

Should it really be doing this?

I just went with the current behavior when swiping from the edge of the screen to go back or pressing "Cloze".

[argon2r]

I'd like to work on it.

Looking at the code, the dialog currently calls setCanceledOnTouchOutside(false) and setCancelable(false), which ends up blocking the tap outside to dismiss behavior .

[david-allison]

Sounds good, cheers!

When the dialog is normal size: definitely

When the dialog is full-height, I think this is stll expected, but it's less certain. Have a test and see what works