feat(reminders): threshold filters #19156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericli3690
added
Needs Review
GSoC
ericli3690
force-pushed
the
ericli3690-review-reminders-new-lrn-rev
branch
from
1ca08cc to
0793e7a
Compare
ericli3690
force-pushed
the
ericli3690-review-reminders-new-lrn-rev
branch
from
0793e7a to
f2c9dde
Compare
Member
Author
|
ericli3690
force-pushed
the
ericli3690-review-reminders-new-lrn-rev
branch
3 times, most recently
from
5a3ddeb to
a390cfb
Compare
Member
Author
|
ericli3690
force-pushed
the
ericli3690-review-reminders-new-lrn-rev
branch
from
a390cfb to
9a53408
Compare
Member
Author
|
ericli3690
force-pushed
the
ericli3690-review-reminders-new-lrn-rev
branch
from
9a53408 to
ae683e5
Compare
Member
Author
|
Forgot to stage some code. Fixed. |
GSoC 2025: Review Reminders Add a group of new advanced review reminder options: count new cards, count cards in learning, and count cards in review. When the review reminder is about to send a notification and checks to see if the amount of cards in the deck is greater than the card trigger threshold, it examines these options to check if it should count and consider new cards, cards in learning, and cards in review. Adds three new checkboxes to the AddEditReminderDialog to toggle these booleans on or off. Edits some logic in NotificationService to add up cards only from selected card type when determining whether the card trigger threshold is met. Adds three new boolean fields to store the states of these settings to ReviewReminder. Adds unit tests.
ericli3690
force-pushed
the
ericli3690-review-reminders-new-lrn-rev
branch
from
ae683e5 to
e128d8a
Compare
ericli3690
removed
Blocked by dependency
Member
Author
|
Rebased, fully unblocked, and ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Add a group of new advanced review reminder options: count new cards, count cards in learning, and count cards in review. When the review reminder is about to send a notification and checks to see if the amount of cards in the deck is greater than the card trigger threshold, it examines these options to check if it should count and consider new cards, cards in learning, and cards in review.
Adds three new checkboxes to the AddEditReminderDialog to toggle these booleans on or off. Edits some logic in NotificationService to add up cards only from selected card type when determining whether the card trigger threshold is met.
Adds three new boolean fields to store the states of these settings to ReviewReminder. Adds unit tests.
UI
Fixes
Approach
One of the two planned review reminder advanced options! Just needs some extra checks when handling the
Countobjects.How Has This Been Tested?
Checklist