Skip to content

Conversation

@Mahalaxmibejugam
Copy link
Collaborator

  • Adds the ci pipeline configuration
  • Anyone with the Cloud Build Approver role needs to approve for the pipeline to run
  • Trigger is setup on gcs-aiml-clients-testing-101 GCP project
  • This pipeline includes tests on both regional and Zonal buckets
  • Logs from the test run would be visible in details section in the Checks tab of the PR

We need a pre setup zonal bucket as we don't have the writes implemented
yet for zonal buckets. A bucket will need to be passed through
substitution variable containing the required data for tests to run
Only print the errors and redirect standard logs to /dev/null
Instead of hardcoding the github repository to be cloned, use
substitution rule so same cloudbuild file can be used for public repo
@Mahalaxmibejugam
Copy link
Collaborator Author

/gcbrun

Copy link
Owner

@ankitaluthra1 ankitaluthra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone with the Cloud Build Approver role needs to approve for the pipeline to run >> Does that mean pipeline wont run for external contributors ?
The pipeline on this PR should pass, correct ? as PR contains the cloudbuild yaml or does it need to be main to be successfull, also why are there 2 pipelines run ?

@ankitaluthra1 ankitaluthra1 requested a review from jasha26 December 4, 2025 17:02
@Mahalaxmibejugam
Copy link
Collaborator Author

Anyone with the Cloud Build Approver role needs to approve for the pipeline to run >> Does that mean pipeline wont run for external contributors ?

Pipeline would be in pending state till someone with Cloud Build Approver role approves it. This check was added as a safe guard as anyone with read access to repo can create PRs and it might include unsafe changes to access other resources from the GCP project. Let me know your thoughts if we want to remove this, as we are planning to have a project dedicatedly only for cloud build pipeline.

The pipeline on this PR should pass, correct ? as PR contains the cloudbuild yaml or does it need to be main to be successfull, also why are there 2 pipelines run ?

Yes, pipeline is successful on this PR. There are 2 pipelines runs as we have configured 2 triggers, one for integration tests and another for performance tests. Performance tests trigger failed as the yaml doesn't exist. If you are referring to Trigger: b27861cb-58fb-438e-8293-ed1a94ce3c1b, it is a manual trigger which can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants