change metric to only emit when pod is actually ready

Author: Ankit Patel

internal/store/pod.go

@@ -1288,7 +1288,7 @@ func createPodStatusReadyTimeFamilyGenerator() generator.FamilyGenerator {
 			ms := []*metric.Metric{}
 
 			for _, c := range p.Status.Conditions {
-				if c.Type == v1.PodReady {
+				if c.Type == v1.PodReady && c.Status == v1.ConditionTrue {
 					ms = append(ms, &metric.Metric{
 						LabelKeys:   []string{},
 						LabelValues: []string{},

internal/store/pod_test.go

@@ -1409,7 +1409,6 @@ func TestPodStore(t *testing.T) {
 		        # HELP kube_pod_status_ready_time Readiness achieved time in unix timestamp for a pod.
 		        # TYPE kube_pod_status_ready gauge
 		        # TYPE kube_pod_status_ready_time gauge
-		        kube_pod_status_ready_time{namespace="ns2",pod="pod2",uid="uid2"} 1.501666018e+09
 		        kube_pod_status_ready{condition="false",namespace="ns2",pod="pod2",uid="uid2"} 1
 		        kube_pod_status_ready{condition="true",namespace="ns2",pod="pod2",uid="uid2"} 0
 		        kube_pod_status_ready{condition="unknown",namespace="ns2",pod="pod2",uid="uid2"} 0