@@ -111,22 +111,21 @@ public class HeadTest implements HttpServerAdapters {
111
111
@ DataProvider (name = "positive" )
112
112
public Object [][] positive () {
113
113
return new Object [][] {
114
+ // HTTP/1.1
114
115
{ httpURI , "GET" , HTTP_NOT_MODIFIED , HTTP_1_1 },
115
116
{ httpsURI , "GET" , HTTP_NOT_MODIFIED , HTTP_1_1 },
116
- { httpURI , "GET" , HTTP_NOT_MODIFIED , HttpClient .Version .HTTP_2 },
117
- { httpsURI , "GET" , HTTP_NOT_MODIFIED , HttpClient .Version .HTTP_2 },
118
117
{ httpURI , "HEAD" , HTTP_OK , HTTP_1_1 },
119
118
{ httpsURI , "HEAD" , HTTP_OK , HTTP_1_1 },
120
- { httpURI , "HEAD" , HTTP_OK , HttpClient .Version .HTTP_2 },
121
- { httpsURI , "HEAD" , HTTP_OK , HttpClient .Version .HTTP_2 },
122
119
{ httpURI + "transfer/" , "GET" , HTTP_NOT_MODIFIED , HTTP_1_1 },
123
120
{ httpsURI + "transfer/" , "GET" , HTTP_NOT_MODIFIED , HTTP_1_1 },
124
- { httpURI + "transfer/" , "GET" , HTTP_NOT_MODIFIED , HttpClient .Version .HTTP_2 },
125
- { httpsURI + "transfer/" , "GET" , HTTP_NOT_MODIFIED , HttpClient .Version .HTTP_2 },
126
121
{ httpURI + "transfer/" , "HEAD" , HTTP_OK , HTTP_1_1 },
127
122
{ httpsURI + "transfer/" , "HEAD" , HTTP_OK , HTTP_1_1 },
128
- { httpURI + "transfer/" , "HEAD" , HTTP_OK , HttpClient .Version .HTTP_2 },
129
- { httpsURI + "transfer/" , "HEAD" , HTTP_OK , HttpClient .Version .HTTP_2 }
123
+ // HTTP/2
124
+ { http2URI , "GET" , HTTP_NOT_MODIFIED , HttpClient .Version .HTTP_2 },
125
+ { https2URI , "GET" , HTTP_NOT_MODIFIED , HttpClient .Version .HTTP_2 },
126
+ { http2URI , "HEAD" , HTTP_OK , HttpClient .Version .HTTP_2 },
127
+ { https2URI , "HEAD" , HTTP_OK , HttpClient .Version .HTTP_2 },
128
+ // HTTP2 forbids transfer-encoding
130
129
};
131
130
}
132
131
@@ -145,11 +144,9 @@ void test(String uriString, String method,
145
144
146
145
HttpRequest .Builder requestBuilder = HttpRequest
147
146
.newBuilder (uri )
147
+ .version (version )
148
148
.method (method , HttpRequest .BodyPublishers .noBody ());
149
149
150
- if (version != null ) {
151
- requestBuilder .version (version );
152
- }
153
150
HttpRequest request = requestBuilder .build ();
154
151
out .println ("Initial request: " + request .uri ());
155
152
@@ -160,6 +157,7 @@ void test(String uriString, String method,
160
157
assertEquals (response .statusCode (), expResp );
161
158
assertEquals (response .body (), "" );
162
159
assertEquals (response .headers ().firstValue ("Content-length" ).get (), CONTENT_LEN );
160
+ assertEquals (response .version (), request .version ().get ());
163
161
}
164
162
165
163
// -- Infrastructure
@@ -182,7 +180,7 @@ public void setup() throws Exception {
182
180
http2TestServer = HttpTestServer .create (HTTP_2 );
183
181
http2TestServer .addHandler (new HeadHandler (), "/" );
184
182
http2URI = "http://" + http2TestServer .serverAuthority () + "/" ;
185
- https2TestServer = HttpTestServer .create (HTTP_2 , SSLContext . getDefault () );
183
+ https2TestServer = HttpTestServer .create (HTTP_2 , sslContext );
186
184
https2TestServer .addHandler (new HeadHandler (), "/" );
187
185
https2URI = "https://" + https2TestServer .serverAuthority () + "/" ;
188
186
0 commit comments