Default to public join rule in remote summary (element-hq#18493)

nexy7574 · web-flow · commit 341d956ee643 · 2025-06-09T10:59:49.000Z
See: element-hq#18358 (comment)
diff --git a/changelog.d/18493.bugfix b/changelog.d/18493.bugfix
@@ -0,0 +1 @@
+Fixed room summary API incorrectly returning that a room is private in the room summary response when the join rule is omitted by the remote server. Contributed by @nexy7574.
diff --git a/synapse/handlers/room_summary.py b/synapse/handlers/room_summary.py
@@ -701,7 +701,7 @@ async def _is_remote_room_accessible(
         # The API doesn't return the room version so assume that a
         # join rule of knock is valid.
         if (
-            room.get("join_rule")
+            room.get("join_rule", JoinRules.PUBLIC)
             in (JoinRules.PUBLIC, JoinRules.KNOCK, JoinRules.KNOCK_RESTRICTED)
             or room.get("world_readable") is True
         ):

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fixed room summary API incorrectly returning that a room is private in the room summary response when the join rule is omitted by the remote server. Contributed by @nexy7574.`