Fix multi-provider review script and workflow

- Remove duplicate function definitions in multi-review-script.ts
- Fix prompt variable passing to runReview function
- Update workflow files to use local script instead of external URL
- Add proper PR body extraction and AGENTS.md handling

Author: keithah

github/multi-provider-review-template.yml

@@ -78,7 +78,7 @@ jobs:
           PR_BODY: ${{ steps.pr-body.outputs.body }}
           HAS_AGENTS: ${{ steps.agents-md.outputs.exists || 'false' }}
         run: |
-          curl -f -o multi-review.ts https://raw.githubusercontent.com/keithah/multi-provider-code-review/main/multi-review-script.ts
+          cp github/multi-review-script.ts multi-review.ts
 
           if [ "$HAS_AGENTS" = "true" ]; then
             export INCLUDE_AGENTS=true

github/multi-review-script.ts

@@ -5,7 +5,10 @@ type ReviewResult = {
   output: string
 }
 
-const REVIEW_PROVIDERS = (process.env.REVIEW_PROVIDERS || "").split(",").map((p) => p.trim()).filter(Boolean)
+const REVIEW_PROVIDERS = (process.env.REVIEW_PROVIDERS || "")
+  .split(",")
+  .map((p) => p.trim())
+  .filter(Boolean)
 const PR_NUMBER = process.env.PR_NUMBER || ""
 const PR_TITLE = process.env.PR_TITLE || ""
 const PR_BODY = process.env.PR_BODY || ""
@@ -25,7 +28,7 @@ async function buildPrompt(): Promise<string> {
   } catch (e) {
     console.log("Warning: Could not read AGENTS.md")
   }
-  
+
   return `REPO: ${REPO}
 PR NUMBER: ${PR_NUMBER}
 PR TITLE: ${PR_TITLE}
@@ -71,7 +74,7 @@ IMPORTANT: Only create comments for actual issues. If the code follows all guide
 
 async function runReview(provider: string, prompt: string): Promise<ReviewResult> {
   console.log(`Starting review with provider: ${provider}`)
-  
+
   try {
     const result = execSync(`opencode run -m ${provider} -- "${prompt.replace(/"/g, '\\"')}"`, {
       encoding: "utf8",
@@ -86,7 +89,7 @@ async function runReview(provider: string, prompt: string): Promise<ReviewResult
 
 async function synthesize(reviews: ReviewResult[]): Promise<string> {
   const combined = reviews.map((r) => `## Review from ${r.provider}\n\n${r.output}`).join("\n\n---\n\n")
-  const providerList = reviews.map(r => r.provider).join(", ")
+  const providerList = reviews.map((r) => r.provider).join(", ")
   const synthesisPrompt = `You are an expert code reviewer. Synthesize these reviews into one comprehensive review following Claude Code's professional format.
 
 Rules:
@@ -149,7 +152,7 @@ Status: ⚠️ [Approve with Recommendations / Changes Requested / Approved]
 **Positive Aspects** ✨
 ✅ [Positive aspect 1]
 ✅ [Positive aspect 2]
-✅ [Positive aspect 3]
+✅ [Positive aspect 3]`
 
   try {
     return execSync(`opencode run -m opencode/big-pickle -- "${synthesisPrompt.replace(/"/g, '\\"')}"`, {
@@ -161,7 +164,6 @@ Status: ⚠️ [Approve with Recommendations / Changes Requested / Approved]
     return combined
   }
 }
-}
 
 let checklistCommentId: string | null = null
 
@@ -171,28 +173,34 @@ async function postOrUpdateChecklist(status: string, completedTasks: string[] =
     "Read modified files",
     "Analyze security implications",
     "Review code quality and conventions",
-    "Provide comprehensive feedback"
+    "Provide comprehensive feedback",
   ]
 
-  const checklist = tasks.map(task => {
-    const isCompleted = completedTasks.includes(task)
-    return `${isCompleted ? '✅' : '⏳'} ${task}`
-  }).join('\n')
+  const checklist = tasks
+    .map((task) => {
+      const isCompleted = completedTasks.includes(task)
+      return `${isCompleted ? "✅" : "⏳"} ${task}`
+    })
+    .join("\n")
 
   const body = `🤖 **Multi-Provider Code Review** ${status}\n\n**Tasks:**\n${checklist}`
 
-  const escaped = body.replace(/"/g, '\\"').replace(/\n/g, '\\n')
+  const escaped = body.replace(/"/g, '\\"').replace(/\n/g, "\\n")
 
   if (checklistCommentId) {
-    // Update existing comment
-    execSync(`gh api --method PATCH -H "Accept: application/vnd.github+json" /repos/${REPO}/issues/comments/${checklistCommentId} -f "body=${escaped}"`, {
-      encoding: "utf8",
-    })
+    execSync(
+      `gh api --method PATCH -H "Accept: application/vnd.github+json" /repos/${REPO}/issues/comments/${checklistCommentId} -f "body=${escaped}"`,
+      {
+        encoding: "utf8",
+      },
+    )
   } else {
-    // Create new comment with specific author name
-    const result = execSync(`gh api --method POST -H "Accept: application/vnd.github+json" -H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" /repos/${REPO}/issues/${PR_NUMBER}/comments -f "body=${escaped}"`, {
-      encoding: "utf8",
-    })
+    const result = execSync(
+      `gh api --method POST -H "Accept: application/vnd.github+json" /repos/${REPO}/issues/${PR_NUMBER}/comments -f "body=${escaped}"`,
+      {
+        encoding: "utf8",
+      },
+    )
     const comment = JSON.parse(result.toString())
     checklistCommentId = comment.id
   }
@@ -203,7 +211,7 @@ async function postFinalReview(synthesis: string, providerList: string, confiden
 
 **Tasks:**
 ✅ Read repository conventions
-✅ Read modified files  
+✅ Read modified files
 ✅ Analyze security implications
 ✅ Review code quality and conventions
 ✅ Provide comprehensive feedback
@@ -213,33 +221,32 @@ ${synthesis}
 *Review generated by: ${providerList}*
 *Provider confidence scores: ${confidenceString}*`
 
-  const escaped = finalBody.replace(/"/g, '\\"').replace(/\n/g, '\\n')
-  execSync(`gh api --method POST -H "Accept: application/vnd.github+json" /repos/${REPO}/issues/${PR_NUMBER}/comments -f "body=${escaped}"`, {
-    encoding: "utf8",
-  })
+  const escaped = finalBody.replace(/"/g, '\\"').replace(/\n/g, "\\n")
+  execSync(
+    `gh api --method POST -H "Accept: application/vnd.github+json" /repos/${REPO}/issues/${PR_NUMBER}/comments -f "body=${escaped}"`,
+    {
+      encoding: "utf8",
+    },
+  )
 }
 
 async function calculateConfidenceScores(reviews: ReviewResult[]): Promise<Record<string, number>> {
   const scores: Record<string, number> = {}
 
-  // Simple confidence scoring based on review length and content quality
   for (const review of reviews) {
-    let score = 0.5 // Base score
+    let score = 0.5
 
-    // Length factor (longer reviews tend to be more thorough)
     if (review.output.length > 2000) score += 0.2
     else if (review.output.length > 1000) score += 0.1
 
-    // Content quality indicators
-    if (review.output.includes('security') || review.output.includes('performance')) score += 0.1
-    if (review.output.includes('suggestion') || review.output.includes('recommend')) score += 0.1
-    if (review.output.includes('line') || review.output.includes('file')) score += 0.1
+    if (review.output.includes("security") || review.output.includes("performance")) score += 0.1
+    if (review.output.includes("suggestion") || review.output.includes("recommend")) score += 0.1
+    if (review.output.includes("line") || review.output.includes("file")) score += 0.1
 
-    // Provider-specific adjustments
-    if (review.provider.includes('big-pickle')) score += 0.1 // Reasoning model
-    if (review.provider.includes('grok-code')) score += 0.1 // Code-specialized
-    if (review.provider.includes('minimax')) score += 0.05 // General purpose
-    if (review.provider.includes('glm-4.7')) score += 0.05 // Balanced
+    if (review.provider.includes("big-pickle")) score += 0.1
+    if (review.provider.includes("grok-code")) score += 0.1
+    if (review.provider.includes("minimax")) score += 0.05
+    if (review.provider.includes("glm-4.7")) score += 0.05
 
     scores[review.provider] = Math.min(Math.max(score, 0.1), 1.0)
   }
@@ -253,21 +260,35 @@ async function main() {
   const prompt = await buildPrompt()
   console.log(`Prompt built (${prompt.length} chars), includes AGENTS.md: ${INCLUDE_AGENTS}`)
 
-  const results = await Promise.all(REVIEW_PROVIDERS.map((provider) => runReview(provider, prompt)))
+  await postOrUpdateChecklist("🔍 Reading modified files...", ["Read repository conventions"])
 
-  // Update checklist - analysis complete
-  await postOrUpdateChecklist("🔒 Analyzing security implications...", ["Read repository conventions", "Read modified files", "Analyze security implications"])
+  await postOrUpdateChecklist("🔍 Analyzing security implications...", [
+    "Read repository conventions",
+    "Read modified files",
+    "Analyze security implications",
+  ])
 
-  // Update checklist - code review
-  await postOrUpdateChecklist("🔍 Reviewing code quality and conventions...", ["Read repository conventions", "Read modified files", "Analyze security implications", "Review code quality and conventions"])
+  const results = await Promise.all(REVIEW_PROVIDERS.map((provider) => runReview(provider, prompt)))
+
+  await postOrUpdateChecklist("🔍 Reviewing code quality and conventions...", [
+    "Read repository conventions",
+    "Read modified files",
+    "Analyze security implications",
+    "Review code quality and conventions",
+  ])
 
   console.log("\nAll reviews completed. Synthesizing...")
 
-  // Update checklist - synthesizing
-  await postOrUpdateChecklist("🤔 Providing comprehensive feedback...", ["Read repository conventions", "Read modified files", "Analyze security implications", "Review code quality and conventions", "Provide comprehensive feedback"])
+  await postOrUpdateChecklist("🤔 Providing comprehensive feedback...", [
+    "Read repository conventions",
+    "Read modified files",
+    "Analyze security implications",
+    "Review code quality and conventions",
+    "Provide comprehensive feedback",
+  ])
 
   const synthesis = await synthesize(results)
-  const providerList = results.map(r => r.provider).join(", ")
+  const providerList = results.map((r) => r.provider).join(", ")
   const confidenceScores = await calculateConfidenceScores(results)
   const confidenceString = Object.entries(confidenceScores)
     .map(([provider, score]) => `${provider}: ${(score * 100).toFixed(0)}%`)
@@ -276,49 +297,11 @@ async function main() {
   console.log("\n=== SYNTHESIS COMPLETE ===\n")
   console.log(synthesis)
 
-  // Post final comprehensive review
   await postFinalReview(synthesis, providerList, confidenceString)
   console.log("\n✅ Final review posted to PR!")
 }
 
 main().catch((error) => {
   console.error("Error:", error)
   process.exit(1)
-})
-  } catch (e) {
-    return `Error with ${provider}`
-  }
-}
-
-async function synthesize(reviews: string[]) {
-  const combined = reviews.join("\n\n---\n\n")
-  const synthesis = `Synthesize these code reviews into one comprehensive review. Combine overlapping feedback, highlight unique insights, remove duplicates:\n\n${combined}`
-  try {
-    return execSync(`opencode run -m opencode/big-pickle -- "${synthesis}"`, {
-      encoding: "utf8",
-      timeout: 180000,
-    })
-  } catch (e) {
-    return combined
-  }
-}
-
-async function main() {
-  console.log(`Running ${providers.length} parallel reviews...`)
-  const results = await Promise.all(providers.map(runReview))
-  console.log("Synthesizing results...")
-  const final = await synthesize(results)
-  console.log("\n=== SYNTHESIS ===\n" + final)
-
-  // Post as PR comment
-  const escaped = final.replace(/"/g, '\\"').replace(/\n/g, "\\n")
-  execSync(
-    `gh api --method POST -H "Accept: application/vnd.github+json" /repos/${repo}/issues/${prNumber}/comments -f "body=${escaped}"`,
-    { encoding: "utf8" },
-  )
-}
-
-main().catch((e) => {
-  console.error(e)
-  process.exit(1)
 })