test: add comprehensive permission tests for edit and bash

Added comprehensive unit tests covering all three permission modes (allow/deny/ask)
for edit and bash permissions:

Edit permission tests (edit.test.ts):
- permission='allow' - edits succeed without asking
- permission='deny' - edits are blocked without asking
- permission='ask' with approval - asks and allows edit
- permission='ask' with denial - asks and blocks edit

Bash permission tests (bash.test.ts):
- permission='allow' via wildcard - commands succeed without asking
- permission='deny' via wildcard - commands are blocked without asking
- permission='ask' via wildcard - asks and allows command
- undefined permission (no wildcard match) - defaults to deny

Also updated .opencode/opencode.jsonc to set external_directory='ask' for testing.

All 204 tests passing.

Author: KJWhiteside

.opencode/opencode.jsonc

@@ -8,4 +8,7 @@
       },
     },
   },
+  "permission": {
+    "external_directory": "ask"
+  }
 }

packages/opencode/test/tool/bash.test.ts

@@ -59,4 +59,186 @@ describe("tool.bash", () => {
       },
     })
   })
+
+  test("should allow commands when bash permission='allow' via wildcard", async () => {
+    const { Agent } = await import("../../src/agent/agent")
+    const originalGet = Agent.get
+
+    // Mock Agent.get to return agent with bash='allow' via wildcard
+    Agent.get = mock(async () => ({
+      permission: {
+        edit: "allow" as const,
+        bash: { "*": "allow" as const },
+        webfetch: "allow" as const,
+        external_directory: "ask" as const,
+        doom_loop: "ask" as const,
+      },
+    })) as any
+
+    const originalAsk = Permission.ask
+    const permissionAskMock = mock(async () => {})
+    Permission.ask = permissionAskMock
+
+    try {
+      await Instance.provide({
+        directory: projectRoot,
+        fn: async () => {
+          const bash = await BashTool.init()
+          const result = await bash.execute(
+            {
+              command: "echo 'permission test'",
+              description: "Test bash permission",
+            },
+            ctx,
+          )
+
+          expect(result.metadata.exit).toBe(0)
+          expect(result.metadata.output).toContain("permission test")
+
+          // Verify Permission.ask was NOT called
+          expect(permissionAskMock).not.toHaveBeenCalled()
+        },
+      })
+    } finally {
+      Agent.get = originalGet
+      Permission.ask = originalAsk
+    }
+  })
+
+  test("should deny commands when bash permission='deny' via wildcard", async () => {
+    const { Agent } = await import("../../src/agent/agent")
+    const originalGet = Agent.get
+
+    // Mock Agent.get to return agent with bash='deny' via wildcard
+    Agent.get = mock(async () => ({
+      permission: {
+        edit: "allow" as const,
+        bash: { "*": "deny" as const },
+        webfetch: "allow" as const,
+        external_directory: "ask" as const,
+        doom_loop: "ask" as const,
+      },
+    })) as any
+
+    const originalAsk = Permission.ask
+    const permissionAskMock = mock(async () => {})
+    Permission.ask = permissionAskMock
+
+    try {
+      await Instance.provide({
+        directory: projectRoot,
+        fn: async () => {
+          const bash = await BashTool.init()
+          await expect(
+            bash.execute(
+              {
+                command: "echo 'should be denied'",
+                description: "Test bash permission deny",
+              },
+              ctx,
+            ),
+          ).rejects.toThrow("Permission denied: Command not allowed by bash permissions")
+
+          // Verify Permission.ask was NOT called
+          expect(permissionAskMock).not.toHaveBeenCalled()
+        },
+      })
+    } finally {
+      Agent.get = originalGet
+      Permission.ask = originalAsk
+    }
+  })
+
+  test("should ask for permission when bash permission='ask' via wildcard", async () => {
+    const { Agent } = await import("../../src/agent/agent")
+    const originalGet = Agent.get
+
+    // Mock Agent.get to return agent with bash='ask' via wildcard
+    Agent.get = mock(async () => ({
+      permission: {
+        edit: "allow" as const,
+        bash: { "*": "ask" as const },
+        webfetch: "allow" as const,
+        external_directory: "ask" as const,
+        doom_loop: "ask" as const,
+      },
+    })) as any
+
+    const originalAsk = Permission.ask
+    const permissionAskMock = mock(async (input: any) => {
+      expect(input.type).toBe("bash")
+      // Resolve without throwing to simulate user approval
+    })
+    Permission.ask = permissionAskMock
+
+    try {
+      await Instance.provide({
+        directory: projectRoot,
+        fn: async () => {
+          const bash = await BashTool.init()
+          const result = await bash.execute(
+            {
+              command: "echo 'ask permission'",
+              description: "Test bash permission ask",
+            },
+            ctx,
+          )
+
+          expect(result.metadata.exit).toBe(0)
+          expect(result.metadata.output).toContain("ask permission")
+
+          // Verify Permission.ask WAS called
+          expect(permissionAskMock).toHaveBeenCalled()
+        },
+      })
+    } finally {
+      Agent.get = originalGet
+      Permission.ask = originalAsk
+    }
+  })
+
+  test("should deny when no wildcard match (undefined permission)", async () => {
+    const { Agent } = await import("../../src/agent/agent")
+    const originalGet = Agent.get
+
+    // Mock Agent.get to return agent with specific command allowed, but not echo
+    Agent.get = mock(async () => ({
+      permission: {
+        edit: "allow" as const,
+        bash: { "ls *": "allow" as const }, // Only ls is allowed
+        webfetch: "allow" as const,
+        external_directory: "ask" as const,
+        doom_loop: "ask" as const,
+      },
+    })) as any
+
+    const originalAsk = Permission.ask
+    const permissionAskMock = mock(async () => {})
+    Permission.ask = permissionAskMock
+
+    try {
+      await Instance.provide({
+        directory: projectRoot,
+        fn: async () => {
+          const bash = await BashTool.init()
+          // echo doesn't match any pattern, should default to deny
+          await expect(
+            bash.execute(
+              {
+                command: "echo 'no match'",
+                description: "Test undefined permission",
+              },
+              ctx,
+            ),
+          ).rejects.toThrow("Permission denied: Command not allowed by bash permissions")
+
+          // Verify Permission.ask was NOT called
+          expect(permissionAskMock).not.toHaveBeenCalled()
+        },
+      })
+    } finally {
+      Agent.get = originalGet
+      Permission.ask = originalAsk
+    }
+  })
 })