Skip to content

Commit 515ecfe

Browse files
committed
chore(converter): expliciting upgrade/downgrade converter log
1 parent 4066373 commit 515ecfe

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

converter/converter/versions/base_message_converter.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,8 @@ def convert(cls, source_version, target_version, edxl_json):
4747
# Convert directly if version are consecutive
4848
if abs(source_version_index - target_version_index) == 1:
4949
if source_version_index < target_version_index:
50-
logger.info(f"Upgrading message version from {source_version}")
5150
return cls.upgrade(source_version, source_version_index, edxl_json)
5251
else:
53-
logger.info(f"Downgrading message version from {source_version}")
5452
return cls.downgrade(
5553
source_version, source_version_index, edxl_json
5654
)
@@ -78,8 +76,10 @@ def convert(cls, source_version, target_version, edxl_json):
7876
@classmethod
7977
def upgrade(cls, source_version, source_version_index, edxl_json):
8078
if source_version == "v1":
79+
logger.info("Upgrading message version from v1 to v2")
8180
return cls.convert_v1_to_v2(edxl_json)
8281
elif source_version == "v2":
82+
logger.info("Upgrading message version from v2 to v3")
8383
return cls.convert_v2_to_v3(edxl_json)
8484
else:
8585
return cls.raise_conversion_impossible_error(
@@ -89,8 +89,10 @@ def upgrade(cls, source_version, source_version_index, edxl_json):
8989
@classmethod
9090
def downgrade(cls, source_version, source_version_index, edxl_json):
9191
if source_version == "v2":
92+
logger.info("Downgrading message version from v2 to v1")
9293
return cls.convert_v2_to_v1(edxl_json)
9394
elif source_version == "v3":
95+
logger.info("Downgrading message version from v3 to v2")
9496
return cls.convert_v3_to_v2(edxl_json)
9597
else:
9698
return cls.raise_conversion_impossible_error(

0 commit comments

Comments
 (0)