get_certificate: add get_certificate_chain option #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
|
It looks like the Python 3.13 API is somewhat broken, which makes the tests fail: python/cpython#118658 There is a fix for it already: python/cpython#118669 |
|
It might be worth to include a similar hack as in https://github.com/pypa/pip/pull/12707/files#diff-5c235fa5de9ea9d116494690fc0e484c45501486f276649200c7e612c2477f88R285 to fix the Python 3.13 issues. |
|
ede3e54 makes tests pass with the current Python 3.13 pre-releases. It should also work fine once the bug has been fixed. |
markuman
approved these changes
Jul 10, 2024
|
@markuman thanks for reviewing this! |
felixfontein
added a commit
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #568.
ISSUE TYPE
COMPONENT NAME
get_certificate