should rhsm_repository realy fail when trying to disable an inexistent repo?

[StCyr]

Summary

rhsm_repostiroy fails when I do:

- name: Disable repository on Red Hat server 
  community.general.rhsm_repository:
    name:
      - "stupid_and_inexistent_dummy_repo_blablabal_randomdfkjsdvoicxjvfdsfsdfp"
    state: disabled
  become: true

Is it really a good idea?

I mean: if I want to disable a repo on a server, isn't it good enough if rhsm_repository doesn't find it?

sidenote: though deprecated, state can still be "absent", in which case I definitively would classify this failure as a bug.

Issue Type

Bug Report

Component Name

rhsm_repository

Ansible Version

$ ansible --version
ansible [core 2.16.14]
  python version = 3.12.11 (main, Aug 15 2025, 13:38:57) [GCC 8.5.0 20210514 (Red Hat 8.5.0-28)]
  jinja version = 3.1.6
  libyaml = True

Community.general Version

$ ansible-galaxy collection list community.general
Collection        Version
----------------- -------
community.general 7.5.9

related code is still in master though:

    for repoid in matched_existing_repo:
        if len(matched_existing_repo[repoid]) == 0:
            results.append(f"{repoid} is not a valid repository ID")
            module.fail_json(results=results, msg=f"{repoid} is not a valid repository ID")

Configuration

$ ansible-config dump --only-changed
sorry sensitive information

OS / Environment

Red Hat Enterprise Linux release 8.10 (Ootpa)

Steps to Reproduce

- name: Disable repository on Red Hat server 
  community.general.rhsm_repository:
    name:
      - "stupid_and_inexistent_dummy_repo_blablabal_randomdfkjsdvoicxjvfdsfsdfp"
    state: disabled
  become: true

Expected Results

community.general.rhsm_repository should not fail when it doesn't find a repo and state is "disabled" or "absent"

Actual Results

output: 
msg: 
stupid_and_inexistent_dummy_repo_blablabal_randomdfkjsdvoicxjvfdsfsdfp is not a valid repository ID

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibullbot]

Files identified in the description:

• plugins/modules/rhsm_repository.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @cnsnyder @giovannisciortino @ptoscano
click here for bot help

[StCyr]

I guess I could add a ignore_missing option if you like?

[felixfontein]

Please note that community.general 7.5.9 is outdated and 7.x.y has been End of Life since November 2024. The state absent has been removed since then and no longer works. (Also ansible-core 2.16 is no longer supported by the current version.)

I mean: if I want to disable a repo on a server, isn't it good enough if rhsm_repository doesn't find it?

That usually depends on how you see it. state=disabled can be seen as "repository is present, but disabled" - that's what the module does. If it doesn't exist, it isn't present, so it can't be disabled.

Obviously it also makes sense to interpret it your way. So making it configurable is definitely a good idea. Having ignore_missing also for state=enabled might have some use-cases as well (not sure which ones though), so I guess having a general ignore_missing option doesn't hurt.