Storagebox subaccount (#163)

* bit more helpfull err msg in `robot.py`

* add `storagebox_subaccount`

* module manages a single subaccount

* reach 100% coverage

* idempotence input value

* rm outdated doc

* add `password_mode` input

* more tests

* add `no_log=True` to `password_mode` to silence warning

* wip: fix PR review comments

* always return subaccount data

* fix review comments 2

* rework confusing condition

* fix review comments 3

* fix review comments 4

* Update plugins/modules/storagebox_subaccount.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/storagebox_subaccount.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/storagebox_subaccount.py

Co-authored-by: Felix Fontein <[email protected]>

* fix review comments 5

---------

Co-authored-by: Felix Fontein <[email protected]>

Author: vic1707

README.md

@@ -71,6 +71,7 @@ If you use the Ansible package and do not update collections independently, use
 - `community.hrobot.storagebox_snapshot_info` module
 - `community.hrobot.storagebox_snapshot_plan` module
 - `community.hrobot.storagebox_snapshot_plan_info` module
+- `community.hrobot.storagebox_subaccount` module
 - `community.hrobot.storagebox_subaccount_info` module
 - `community.hrobot.v_switch` module
 - `community.hrobot.robot` inventory plugin

meta/runtime.yml

@@ -25,5 +25,6 @@ action_groups:
     - storagebox_snapshot_info
     - storagebox_snapshot_plan
     - storagebox_snapshot_plan_info
+    - storagebox_subaccount
     - storagebox_subaccount_info
     - v_switch

plugins/module_utils/robot.py

@@ -100,8 +100,10 @@ def raw_plugin_open_url_json(plugin, url, method='GET', timeout=10, data=None, h
         )
         status = response.code
         content = response.read()
+        reason = response.reason
     except HTTPError as e:
         status = e.code
+        reason = e.reason
         try:
             content = e.read()
         except AttributeError:
@@ -112,7 +114,11 @@ def raw_plugin_open_url_json(plugin, url, method='GET', timeout=10, data=None, h
     if not content:
         if allow_empty_result and status in allowed_empty_result_status_codes:
             return None, None
-        raise PluginException('Cannot retrieve content from {0}, HTTP status code {1}'.format(url, status))
+        raise PluginException(
+            "Cannot retrieve content from {0} {1}, HTTP status code {2} ({3})".format(
+                method, url, status, reason
+            )
+        )
 
     try:
         result = json.loads(content.decode('utf-8'))
@@ -150,7 +156,11 @@ def raw_fetch_url_json(module, url, method='GET', timeout=10, data=None, headers
     if not content:
         if allow_empty_result and info.get('status') in allowed_empty_result_status_codes:
             return None, None
-        module.fail_json(msg='Cannot retrieve content from {0}, HTTP status code {1}'.format(url, info.get('status')))
+        module.fail_json(
+            msg='Cannot retrieve content from {0} {1}, HTTP status code {2} ({3})'.format(
+                method, url, info.get('status'), info.get('msg')
+            )
+        )
 
     try:
         result = module.from_json(content.decode('utf8'))