proxmox_zone: Fix sanity issues

- Fix PEP8 issues
- Fix Doc issues for dnszone
- Add workaround for author string
- Add attribute check_mode and diff_mode
- Add no_log=False for lock_token as this is not a secret

Author: JanaHoch

plugins/modules/proxmox_zone.py

@@ -17,7 +17,12 @@
 short_description: Manage Proxmox zone configurations
 description:
   - list/create/update/delete proxmox sdn zones
-author: 'Jana Hoch <[email protected]>'
+author: 'Jana Hoch <[email protected]> (!UNKNOWN)'
+attributes:
+  check_mode:
+    support: none
+  diff_mode:
+    support: none
 options:
   state:
     description:
@@ -80,7 +85,7 @@
     type: str
   dnszone:
     description:
-      - dns domain zone  ex: mydomain.com
+      - dns domain zone.
     type: str
   dp_id:
     description:
@@ -167,7 +172,7 @@
     api_password: "{{ vault.proxmox.root_password }}"
     api_host: "{{ pc.proxmox.api_host }}"
     validate_certs: no
-    
+
 - name: Get all simple zones
   community.proxmox.proxmox_zone:
     api_user: "root@pam"
@@ -186,7 +191,7 @@
     type: simple
     zone: ansible
     state: present
-    
+
 - name: create a vlan zones
   community.proxmox.proxmox_zone:
     api_user: "root@pam"
@@ -197,7 +202,7 @@
     zone: ansible
     state: present
     bridge: vmbr0
-    
+
 - name: update a zones
   community.proxmox.proxmox_zone:
     api_user: "root@pam"
@@ -208,7 +213,7 @@
     zone: ansible
     state: update
     mtu: 1200
-    
+
 - name: Delete a zones
   community.proxmox.proxmox_zone:
     api_user: "root@pam"
@@ -222,14 +227,14 @@
 
 RETURN = r"""
 zones:
-    description: 
-      - List of zones. if you do not pass zone name. 
+    description:
+      - List of zones. if you do not pass zone name.
       - If you are creating/updating/deleting it'll just return a msg with status
     returned: on success
     type: list
     elements: dict
     sample:
-      [   
+      [
         {
             "digest": "e29dea494461aa699ab3bfb7264d95631c8d0e0d",
             "type": "simple",
@@ -263,7 +268,7 @@
             "zone": "tsjsfv"
         }
       ]
-        
+
 """
 
 from ansible.module_utils.basic import AnsibleModule
@@ -272,6 +277,7 @@
     ProxmoxAnsible
 )
 
+
 def get_proxmox_args():
     return dict(
         state=dict(type="str", choices=["present", "absent", "update"], required=False),
@@ -294,7 +300,7 @@ def get_proxmox_args():
         exitnodes_primary=dict(type="str", required=False),
         fabric=dict(type="str", required=False),
         ipam=dict(type="str", required=False),
-        lock_token=dict(type="str", required=False),
+        lock_token=dict(type="str", required=False, no_log=False),
         mac=dict(type="str", required=False),
         mtu=dict(type="int", required=False),
         nodes=dict(type="str", required=False),
@@ -307,6 +313,7 @@ def get_proxmox_args():
         vxlan_port=dict(type="int", required=False),
     )
 
+
 def get_ansible_module():
     module_args = proxmox_auth_argument_spec()
     module_args.update(get_proxmox_args())
@@ -320,6 +327,7 @@ def get_ansible_module():
         ]
     )
 
+
 class ProxmoxZoneAnsible(ProxmoxAnsible):
     def __init__(self, module):
         super(ProxmoxZoneAnsible, self).__init__(module)
@@ -406,7 +414,6 @@ def run(self):
             )
 
     def get_zones(self, **type):
-        print("reached")
         try:
             return self.proxmox_api.cluster().sdn().zones().get(**type)
         except Exception as e:
@@ -503,7 +510,6 @@ def zone_absent(self, zone_name, lock):
             )
 
 
-
 def main():
     module = get_ansible_module()
     proxmox = ProxmoxZoneAnsible(module)
@@ -513,5 +519,6 @@ def main():
     except Exception as e:
         module.fail_json(msg=f'An error occurred: {e}')
 
+
 if __name__ == "__main__":
-    main()
+    main()