Import paramiko directly. (#151)

Author: felixfontein

changelogs/fragments/151-connection-paramiko.yml

@@ -0,0 +1,3 @@
+bugfixes:
+  - "proxmox_pct_remote connection plugin - avoid deprecated ansible-core paramiko import helper, import paramiko directly instead
+     (https://github.com/ansible-collections/community.proxmox/issues/146, https://github.com/ansible-collections/community.proxmox/pull/151)."

plugins/connection/proxmox_pct_remote.py

@@ -406,6 +406,7 @@
 import pathlib
 import socket
 import tempfile
+import traceback
 import typing as t
 
 from ansible.errors import (
@@ -414,14 +415,20 @@
     AnsibleError,
 )
 from ansible_collections.community.proxmox.plugins.module_utils._filelock import FileLock, LockTimeout
+from ansible_collections.community.proxmox.plugins.module_utils.version import LooseVersion
 from ansible.module_utils.common.text.converters import to_bytes, to_native, to_text
-from ansible.module_utils.compat.paramiko import PARAMIKO_IMPORT_ERR, paramiko
-from ansible.module_utils.compat.version import LooseVersion
 from ansible.plugins.connection import ConnectionBase
 from ansible.utils.display import Display
 from ansible.utils.path import makedirs_safe
 from binascii import hexlify
 
+try:
+    import paramiko
+    PARAMIKO_IMPORT_ERR = None
+except ImportError:
+    paramiko = None
+    PARAMIKO_IMPORT_ERR = traceback.format_exc()
+
 
 display = Display()
 
@@ -521,7 +528,7 @@ def _parse_proxy_command(self, port: int = 22) -> dict[str, t.Any]:
     def _connect(self) -> Connection:
         """ activates the connection object """
 
-        if paramiko is None:
+        if PARAMIKO_IMPORT_ERR is not None:
             raise AnsibleError(f'paramiko is not installed: {to_native(PARAMIKO_IMPORT_ERR)}')
 
         port = self.get_option('port')

tests/unit/plugins/connection/test_proxmox_pct_remote.py

@@ -14,15 +14,14 @@
 from ansible_collections.community.proxmox.plugins.module_utils._filelock import FileLock, LockTimeout
 from ansible.errors import AnsibleError, AnsibleAuthenticationFailure, AnsibleConnectionFailure
 from ansible.module_utils.common.text.converters import to_bytes
-from ansible.module_utils.compat.paramiko import paramiko
 from ansible.playbook.play_context import PlayContext
 from ansible.plugins.loader import connection_loader
 from io import StringIO
 from pathlib import Path
 from unittest.mock import patch, MagicMock, mock_open
 
 
-pytest.importorskip('paramiko')
+paramiko = pytest.importorskip('paramiko')
 
 
 @pytest.fixture