Skip to content

Commit a5419bd

Browse files
committed
proxmox_firewall: remove unnecsary getattr
1 parent ac5d44b commit a5419bd

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

plugins/modules/proxmox_firewall.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -604,25 +604,22 @@ def run(self):
604604

605605
if level == "vm":
606606
vm = self.get_vm(vmid=self.params.get('vmid'))
607-
node = getattr(self.proxmox_api.nodes(), vm['node'])
608-
virt = getattr(node(), vm['type'])
609-
vm = getattr(virt(), vm['vmid'])
610-
firewall_obj = vm().firewall
607+
node = self.proxmox_api.nodes(vm['node'])
608+
virt = node(vm['type'])
609+
firewall_obj = virt(str(vm['vmid'])).firewall
611610
rules_obj = firewall_obj().rules
612611

613612
elif level == "node":
614-
node = getattr(self.proxmox_api.nodes(), self.params.get('node'))
615-
firewall_obj = node().firewall
613+
firewall_obj = self.proxmox_api.nodes(self.params.get('node')).firewall
616614
rules_obj = firewall_obj().rules
617615

618616
elif level == "vnet":
619-
vnet = getattr(self.proxmox_api.cluster().sdn().vnets(), self.params.get('vnet'))
620-
firewall_obj = vnet().firewall
617+
firewall_obj = self.proxmox_api.cluster().sdn().vnets(self.params.get('vnet')).firewall
621618
rules_obj = firewall_obj().rules
622619

623620
elif level == "group":
624621
firewall_obj = None
625-
rules_obj = getattr(self.proxmox_api.cluster().firewall().groups(), group)
622+
rules_obj = self.proxmox_api.cluster().firewall().groups(group)
626623

627624
else:
628625
firewall_obj = self.proxmox_api.cluster().firewall

0 commit comments

Comments
 (0)