Fix idempotency proxmox_cluster_ha_resources (#135)

* Fix detection of existing resources by normalizing SIDs to vmid only

* Fix change detection

* Added changelog

* Use partition instead of split

Author: Thulium-Drake

changelogs/fragments/135-fix-idempotency-ha-resources.yml

@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - proxmox_cluster_ha_resources -  Fix idempotency proxmox_cluster_ha_resources (https://github.com/ansible-collections/community.proxmox/pull/135).

plugins/modules/proxmox_cluster_ha_resources.py

@@ -148,13 +148,16 @@ def create(self, resources, sid, comment, group, max_relocate, max_restart, stat
             "state": state,
         }
 
+        # Normalize input SIDs to version without : in them
+        if ':' in sid:
+            sid = sid.partition(':')[2]
+
         for resource in resources:
-            if resource["sid"] != sid:
+            if resource["sid"].partition(':')[2] != sid:
                 continue
 
-            if ((resource.get("comment", ""), resource.get("group", ""), resource.get("max_relocate", 1),
-                 resource.get("max_restart", 1), resource["state"]) ==
-                    (comment, group, max_relocate, max_restart, state)):
+            # Compare all keys in the desired state against current state
+            if all(resource.get(k) == v for k, v in data.items()):
                 return False
             else:
                 self._put(sid, data)