-
Notifications
You must be signed in to change notification settings - Fork 39
new module proxmox_vnet #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 64.86% 65.36% +0.50%
==========================================
Files 69 71 +2
Lines 6941 7088 +147
Branches 1326 1342 +16
==========================================
+ Hits 4502 4633 +131
- Misses 2226 2235 +9
- Partials 213 220 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3d2f9dd
to
e48c9bc
Compare
- Also added unit tests
Hi @IamLunchbox / @Thulium-Drake , This is also ready but it needs 1 function from module_utils which I added in #183 and checks are failing because of that. let me know once #183 is merged this should be good to go next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor suggestions, otherwise LGTM
Added suggestions from @IamLunchbox Co-authored-by: IamLunchbox <[email protected]>
Please re-trigger CI task once #183 is merged it should be good then. |
@JanaHoch Done! |
@Thulium-Drake this pr is ready from my side. |
SUMMARY
Added new module
proxmox_vnet
to create/update/delete vnets in proxmox SDNISSUE TYPE
COMPONENT NAME
proxmox_vnet
ADDITIONAL INFORMATION
This is part of #30
Note: If you are trying to test this. it needs sdn locking functions which I've added in #176