Update default proxysql version, drop support for xenial (EOL) and fix small bugs (#92)

* Dynamic user/password in .my.cnf

* python3-mysqldb: Correct package name

* add changelogs

* Update changelogs/fragments/89-dynamic-user-password-in-client-my-cnf-and-correct-package-name.yml

* Update default proxysql version, drop support for xenial and fix small bugs

* (chore) Correct pull request ID in changelog

* (chore) re-add changelog

Co-authored-by: Markus Bergholz <[email protected]>

Author: mrpk1906

.github/workflows/ansible-test-roles.yml

@@ -21,7 +21,7 @@ jobs:
     strategy:
       matrix:
         proxysql:
-          - 2.0.12
+          - 2.3.2
         ansible:
           - stable-2.9
           ### it looks like there's errors for 2.10+ with ansible-lint (https://github.com/ansible/ansible-lint/pull/878)

changelogs/fragments/92-update-default-proxysql-version-and-fix-small-bugs.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - role_proxysql - Update default proxysql version and fix small bugs (https://github.com/ansible-collections/community.proxysql/pull/92).

roles/proxysql/defaults/main.yml

@@ -1,7 +1,7 @@
 ---
 ### proxysql install
 proxysql_download_src: https://github.com/sysown/proxysql/releases/download
-proxysql_version: 2.0.10
+proxysql_version: 2.3.2
 proxysql_mysql_client_version: 5.7
 proxysql_mysql_use_custom_build: false
 proxysql_force_restart: false
@@ -93,8 +93,6 @@ proxysql_mysql_default_charset: utf8
 proxysql_mysql_default_query_delay: 0
 proxysql_mysql_default_query_timeout: 36000000
 proxysql_mysql_default_schema: information_schema
-proxysql_mysql_default_sql_mode:
-proxysql_mysql_default_time_zone: SYSTEM
 proxysql_mysql_init_connect:
 proxysql_mysql_max_allowed_packet: 4194304
 proxysql_mysql_max_transaction_time: 14400000
@@ -118,7 +116,6 @@ proxysql_mysql_query_processor_regex: 1
 proxysql_mysql_autocommit_false_is_transaction: false
 proxysql_mysql_autocommit_false_not_reusable: false
 proxysql_mysql_enforce_autocommit_on_reads: false
-proxysql_mysql_forward_autocommit: false
 
 # prepared statements
 proxysql_mysql_max_stmts_cache: 10000
@@ -160,7 +157,7 @@ proxysql_mysql_monitor_writer_is_also_reader: true
 proxysql_mysql_commands_stats: true
 proxysql_mysql_eventslog_filename:
 proxysql_mysql_eventslog_filesize: 104857600
-proxysql_mysql_hostgroup_manager_verbose: 0
+proxysql_mysql_hostgroup_manager_verbose: 1
 proxysql_mysql_long_query_time: 1000
 proxysql_mysql_query_digests: true
 proxysql_mysql_query_digests_lowercase: false

roles/proxysql/meta/main.yml

@@ -10,8 +10,8 @@ galaxy_info:
   platforms:
     - name: Ubuntu
       versions:
-        - xenial
         - bionic
+        - focal
 
   galaxy_tags:
     - proxysql

roles/proxysql/tasks/install.yml

@@ -5,27 +5,6 @@
   changed_when: false
   ignore_errors: "{{ ansible_check_mode }}"
 
-- name: proxysql | install | install (trusty specific)
-  block:
-
-    - name: proxysql | install | install platform specific prereqs
-      apt:
-        name: "{{ lookup('vars', 'proxysql_' + ansible_lsb.codename + '_prereqs') }}"
-        state: present
-      environment:
-        DEBIAN_FRONTEND: noninteractive
-
-  rescue:
-
-    - name: proxysql | install | handle the error if we failed in check mode, with python-apt uninstalled
-      assert:
-        that: ansible_failed_result.msg is match("python-apt must be installed to use check mode.*")
-        fail_msg: "unknown error during package install"
-        success_msg: "running in check mode without python-apt installed, ignoring error"
-
-  when: ansible_lsb.major_release|int == 14
-
-
 - name: proxysql | install | install
   block:
 

roles/proxysql/tasks/main.yml

@@ -20,3 +20,5 @@
 - import_tasks: config.yml
   tags:
     - config
+  become: true
+  become_user: root

roles/proxysql/tasks/setvars.yml

@@ -6,3 +6,4 @@
     - { username: "{{ proxysql_admin_user }}", password: "{{ proxysql_admin_password }}" }
     - { username: "{{ proxysql_admin_cluster_username }}", password: "{{ proxysql_admin_cluster_password }}" }
   when: item.username and item.password
+  no_log: true

roles/proxysql/vars/main.yml

@@ -1,16 +1,12 @@
 ---
 ### percona repo
 percona_mysql_repos:
-  - deb http://repo.percona.com/apt {{ ansible_lsb.codename }} main
-  - deb-src http://repo.percona.com/apt {{ ansible_lsb.codename }} main
-
-### platform specific packages
-proxysql_trusty_prereqs:
-  - libgnutls28-dev
+  - deb https://repo.percona.com/apt {{ ansible_lsb.codename }} main
+  - deb-src https://repo.percona.com/apt {{ ansible_lsb.codename }} main
 
 proxysql_prereqs:
   - dirmngr
-  - python-setuptools
+  - python3-setuptools
   - python3-pip
   - python3-virtualenv
 
@@ -153,12 +149,6 @@ proxysql_mysql_variables:
   default_schema:
     variable: "default_schema"
     variable_value: "{{ proxysql_mysql_default_schema }}"
-  default_sql_mode:
-    variable: "default_sql_mode"
-    variable_value: "{{ proxysql_mysql_default_sql_mode }}"
-  default_time_zone:
-    variable: "default_time_zone"
-    variable_value: "{{ proxysql_mysql_default_time_zone }}"
   eventslog_filename:
     variable: "eventslog_filename"
     variable_value: "{{ proxysql_mysql_eventslog_filename }}"
@@ -168,9 +158,6 @@ proxysql_mysql_variables:
   enforce_autocommit_on_reads:
     variable: "enforce_autocommit_on_reads"
     variable_value: "{{ proxysql_mysql_enforce_autocommit_on_reads | to_json}}"
-  forward_autocommit:
-    variable: "forward_autocommit"
-    variable_value: "{{ proxysql_mysql_forward_autocommit | to_json}}"
   free_connections_pct:
     variable: "free_connections_pct"
     variable_value: "{{ proxysql_mysql_free_connections_pct }}"

tests/integration/targets/setup_proxysql/defaults/main.yml

@@ -1,5 +1,5 @@
 ---
 proxysql_download_src: https://github.com/sysown/proxysql/releases/download
-proxysql_version: 2.0.10
+proxysql_version: 2.3.2
 
 proxysql_mysql_client_version: 5.7

tests/integration/targets/setup_proxysql/vars/main.yml

@@ -7,7 +7,7 @@ proxysql_percona_mysql_repos:
 
 proxysql_percona_mysql_packages:
   - percona-server-client-{{ proxysql_mysql_client_version }}
-  # - python-mysqldb
+  - python3-mysqldb
 
 proxysql_python_packages:
   - pymysql