Merge pull request #87 from CICS/tests.unitCicsVersion

added unit tests for cics version

Author: KyeMaloy97

plugins/module_utils/cicsgetversion.py

@@ -5,8 +5,8 @@
 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 try:
-    import zoautil_py.datasets as Datasets
-    import zoautil_py.exceptions as ZOAUExceptions
+    from zoautil_py.datasets import read
+    from zoautil_py.exceptions import ZOAUException
 except ImportError as imp_exc:
     ZOAUTIL_IMPORT_ERROR = imp_exc
 else:
@@ -15,12 +15,12 @@
 
 def get_dataset_member_version_record(dataset):  # type: (str) -> str
     try:
-        result = Datasets.read("%s.SDFHSAMP(DFH0SINX)" % dataset).split("STATUS = ", 1)[1].split(" ")[0]
+        result = read("%s.SDFHSAMP(DFH0SINX)" % dataset).split("STATUS = ", 1)[1].split(" ")[0]
         if not result or result == "":
             raise Exception("CICS version was blank")
         elif len(result) >= 10:
             raise Exception("CICS version was too long")
         else:
             return result
-    except ZOAUExceptions.ZOAUException:
+    except ZOAUException:
         raise Exception("Error reading dataset for calculating CICS version.")

tests/unit/module_utils/test_cicsgetversion.py

@@ -0,0 +1,83 @@
+from __future__ import (absolute_import, division, print_function)
+__metaclass__ = type
+
+from ansible_collections.ibm.ibm_zos_cics.plugins.module_utils import cicsgetversion
+try:
+    import unittest
+    from unittest.mock import MagicMock
+except ImportError:
+    from mock import MagicMock
+
+
+class CICSGetVersionUnitTests(unittest.TestCase):
+    def test_get_dataset_member_version_record(self):
+        stdout = '''
+        *                                                               *
+        * STATUS = 7.1.0                                                *
+        *                                                               *
+        *---------------------------------------------------------------*
+        *                                                               *
+        * DESCRIPTION :                                                 *
+
+        '''
+        cicsgetversion.read = MagicMock(return_value=stdout)
+
+        ds = 'CICS.TEST.PATH'
+        result = cicsgetversion.get_dataset_member_version_record(ds)
+        self.assertEqual(result, '7.1.0')
+
+    def test_get_dataset_member_version_record_not_present(self):
+        stdout = '''
+        *                                                               *
+        * STATUS =                                                      *
+        *                                                               *
+        *---------------------------------------------------------------*
+        *                                                               *
+        * DESCRIPTION :                                                 *
+
+        '''
+        cicsgetversion.read = MagicMock(return_value=stdout)
+
+        error_raised = False
+        try:
+            cicsgetversion.get_dataset_member_version_record('CICS.TEST.PATH')
+        except Exception as e:
+            print((repr(e)))
+            error_raised = True
+        assert error_raised
+
+    def test_get_dataset_member_version_record_too_long(self):
+        stdout = '''
+        *                                                               *
+        * STATUS = 1234647473636738383762728                            *
+        *                                                               *
+        *---------------------------------------------------------------*
+        *                                                               *
+        * DESCRIPTION :                                                 *
+
+        '''
+        cicsgetversion.read = MagicMock(return_value=stdout)
+
+        error_raised = False
+        try:
+            cicsgetversion.get_dataset_member_version_record('CICS.TEST.PATH')
+        except Exception as e:
+            print((repr(e)))
+            error_raised = True
+        assert error_raised
+
+    def test_get_dataset_member_version_record_blank(self):
+        stdout = '''
+        '''
+        cicsgetversion.read = MagicMock(return_value=stdout)
+
+        error_raised = False
+        try:
+            cicsgetversion.get_dataset_member_version_record('CICS.TEST.PATH')
+        except Exception as e:
+            print((repr(e)))
+            error_raised = True
+        assert error_raised
+
+    if __name__ == '__main__':
+        unittest.main()