Fix jinja warnings

Author: kiera-bennett

tests/integration/targets/cics_data_set/playbooks/validation_template.yml

@@ -72,7 +72,7 @@
           that:
             - result.failed == true
             - result.changed == false
-            - result.msg == "No template or data set override found for {{ data_set_name | lower }}"
+            - result.msg == "No template or data set override found for {}".format(data_set_name | lower)
             - "'executions' in result"
             - "'start_state' in result"
             - "'end_state' in result"
@@ -95,7 +95,7 @@
           that:
             - result.failed == true
             - result.changed == false
-            - "'Invalid argument \"{{ region_data_set_path }}...\" for type \"data_set_base\".' in result.msg"
+            - "'Invalid argument \"{}...\" for type \"data_set_base\".'.format(region_data_set_path) in result.msg"
             - "'executions' in result"
             - "'start_state' in result"
             - "'end_state' in result"

tests/integration/targets/cics_region_jcl/playbooks/region_jcl_member.yml

@@ -61,7 +61,7 @@
               - result.changed == false
               - result.start_state.exists == false
               - result.end_state.exists == false
-              - result.msg == "Base data set {{ base_data_set_path }} does not exist. Can only create a member in an existing PDS/E"
+              - result.msg == "Base data set {} does not exist. Can only create a member in an existing PDS/E".format(base_data_set_path)
 
         # #############################################################################
 
@@ -171,7 +171,7 @@
               - result.changed == false
               - result.start_state.exists == false
               - result.end_state.exists == false
-              - result.msg == "Data set {{ data_set_path }} does not exist."
+              - result.msg == "Data set {} does not exist.".format(data_set_path)
 
         # #############################################################################
 
@@ -201,7 +201,7 @@
               - result.changed == false
               - result.start_state.exists == true
               - result.end_state.exists == true
-              - result.msg == "Data set {{ data_set_path }} does not contain the expected Region JCL."
+              - result.msg == "Data set {} does not contain the expected Region JCL.".format(data_set_path)
 
         # #############################################################################
 

tests/integration/targets/cics_start_stop/playbooks/stop_args.yml

@@ -38,7 +38,7 @@
             that:
               - stop_result.failed is true
               - stop_result.changed is false
-              - "{{ stop_result.executions | length }} == 0"
+              - stop_result.executions | length == 0
               - stop_result.msg == "one of the following is required: job_id, job_name"
 
         - name: Stop CICS using job name
@@ -84,7 +84,7 @@
               - stop_result.msg == ""
               - stop_result.executions[-1].return.failed == False
               - stop_result.executions[-1].return.output[0].content | length == 2
-              - "'ON OUTPUT QUEUE' in '{{ stop_result.executions[-1].return.output[0].content | join(' ') }}'"
+              - "'ON OUTPUT QUEUE' in stop_result.executions[-1].return.output[0].content | join(' ')"
             fail_msg: "CICS Region did not stop successfully"
         - name: Assert execution RCs are 0
           ansible.builtin.assert:
@@ -124,7 +124,7 @@
               - stop_result.msg == ""
               - stop_result.executions[-1].return.failed == False
               - stop_result.executions[-1].return.output[0].content | length == 2
-              - "'ON OUTPUT QUEUE' in '{{ stop_result.executions[-1].return.output[0].content | join(' ') }}'"
+              - "'ON OUTPUT QUEUE' in stop_result.executions[-1].return.output[0].content | join(' ')"
             fail_msg: "CICS Region did not stop successfully"
         - name: Assert execution RCs are 0
           ansible.builtin.assert:
@@ -154,8 +154,8 @@
           ansible.builtin.assert:
             that:
               - stop_result.failed == true
-              - stop_result.msg == "No jobs found with name {{ start_region_applid }} and ID NONJOB"
-        
+              - stop_result.msg == "No jobs found with name {} and ID NONJOB".format(start_region_applid)
+
         - name: Issue shutdown command (wrong name)
           ibm.ibm_zos_cics.stop_region:
             job_name: "NONJOB"
@@ -172,7 +172,7 @@
           ansible.builtin.assert:
             that:
               - stop_result.failed == true
-              - stop_result.msg == "No jobs found with name NONJOB and ID {{ start_result.stdout }}"
+              - stop_result.msg == "No jobs found with name NONJOB and ID {}".format(start_result.stdout)
       always:
         - name: Delete job
           ansible.builtin.command:
@@ -212,7 +212,7 @@
               - stop_result.failed == false
               - stop_result.changed == false
               - stop_result.msg == ""
-        
+
         - name: Issue shutdown command with mismatched name and id (wrong name)
           ibm.ibm_zos_cics.stop_region:
             job_id: "{{ start_result.stdout }}"
@@ -224,7 +224,7 @@
             that:
               - stop_result.failed == true
               - stop_result.changed == false
-              - stop_result.msg == "No jobs found with name NONJOB and ID {{ start_result.stdout }}"
+              - stop_result.msg == "No jobs found with name NONJOB and ID {}".format(start_result.stdout)
         - name: Issue shutdown command with mismatched name and id  (wrong id)
           ibm.ibm_zos_cics.stop_region:
             job_id: "NONJOB"
@@ -236,7 +236,7 @@
             that:
               - stop_result.failed == true
               - stop_result.changed == false
-              - stop_result.msg == "No jobs found with name {{ start_region_applid }} and ID NONJOB"
+              - stop_result.msg == "No jobs found with name {} and ID NONJOB".format(start_region_applid)
 
       always:
         - name: Delete job

tests/integration/targets/cics_start_stop/playbooks/validate_console_autoinstall_fail.yml

@@ -47,7 +47,7 @@
           ansible.builtin.assert:
             that:
               - stop_output.failed is true
-              - stop_output.msg == "{{ AUTOINSTALL_FAIL_MSG }}"
+              - stop_output.msg == AUTOINSTALL_FAIL_MSG
               - stop_output.changed is false
               - "'executions' in stop_output"
       always:

tests/integration/targets/cics_start_stop/playbooks/validate_console_not_defined.yml

@@ -47,7 +47,7 @@
           ansible.builtin.assert:
             that:
               - stop_output.failed is true
-              - stop_output.msg == "{{ UNDEFINED_CONSOLE_MSG }}"
+              - stop_output.msg == UNDEFINED_CONSOLE_MSG
               - stop_output.changed is false
               - "'executions' in stop_output"
       always:

tests/integration/targets/cics_start_stop/repeatable_tasks/stop_region.yml

@@ -23,7 +23,7 @@
 
     - name: Set stop_output
       ansible.builtin.set_fact: stop_output="{{ stop_result }}"
-      when: "'skip_reason' not in {{ stop_result }}"
+      when: "'skip_reason' not in stop_result"
 
     - name: Issue shutdown command (with job_name)
       when:
@@ -75,7 +75,7 @@
       - stop_output.msg == ""
       - stop_output.executions[-1].return.failed == False
       - stop_output.executions[-1].return.output[0].content | length == 2
-      - "'ON OUTPUT QUEUE' in '{{ stop_output.executions[-1].return.output[0].content | join(' ') }}'"
+      - "'ON OUTPUT QUEUE' in stop_output.executions[-1].return.output[0].content | join(' ')"
     fail_msg: "CICS Region did not stop successfully"
 
 - name: Assert execution RCs are 0