[Bugfix][1239][zos job submit]max_rc_more_than_0_doesn_not_put_change_as_true (#1345)

* First iteration of solution

* Change dataset

* Ensure all cases for false

* Remove print

* Change behavior for bugfix

* Add fragment

* Fix latest lower case

* Fix uppercase

* Remove typo

* Remove typo

* Fix redundance

* Fix test and upper cases

* Fix test case

* Fix fragment

* Return to lower case

* Return to lower case

---------

Co-authored-by: Fernando Flores <[email protected]>

Author: AndreMarcel99

changelogs/fragments/1345-max_rc_more_than_0_doesn_not_put_change_as_true.yml

@@ -0,0 +1,5 @@
+bugfixes:
+  - zos_job_submit - when the argument max_rc was different than 0 the changed response returned
+    as false. Fix now return a changed response as true when the rc is not 0 and max_rc is above
+    or equal to the value of the job.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/1345).

plugins/modules/zos_job_submit.py

@@ -1108,7 +1108,9 @@ def assert_valid_return_code(max_rc, job_rc, ret_code, result):
     # should NOT be 'changed=true' even though the user did override the return code,
     # a non-zero return code means the job did not change anything, so set it as
     # result["chagned"]=False,
-    if job_rc != 0:
+    if max_rc and job_rc > max_rc:
+        return False
+    elif job_rc != 0 and max_rc is None:
         return False
 
     return True

tests/functional/modules/test_zos_fetch_func.py

@@ -539,12 +539,12 @@ def test_fetch_sequential_data_set_replace_on_local_machine(ansible_zos_module):
     ds_name = TEST_PS
     hosts.all.zos_data_set(name=TEST_PS, state="present")
     hosts.all.shell(cmd="decho \"{0}\" \"{1}\"".format(TEST_DATA, TEST_PS))
-    dest_path = "/tmp/" + ds_name
+    dest_path = "/tmp/" + TEST_PS
     with open(dest_path, "w") as infile:
         infile.write(DUMMY_DATA)
 
     local_checksum = checksum(dest_path, hash_func=sha256)
-    params = dict(src=ds_name, dest="/tmp/", flat=True)
+    params = dict(src=TEST_PS, dest="/tmp/", flat=True)
     try:
         results = hosts.all.zos_fetch(**params)
         for result in results.contacted.values():
@@ -562,6 +562,7 @@ def test_fetch_partitioned_data_set_replace_on_local_machine(ansible_zos_module)
     pds_name = get_tmp_ds_name()
     dest_path = "/tmp/" + pds_name
     full_path = dest_path + "/MYDATA"
+    pds_name_mem = pds_name + "(MYDATA)"
     hosts.all.zos_data_set(
         name=pds_name,
         type="pds",

tests/functional/modules/test_zos_job_submit_func.py

@@ -713,11 +713,11 @@ def test_job_submit_max_rc(ansible_zos_module, args):
                 assert re.search(r'the submitted job is greater than the value set for option', repr(result.get("msg")))
 
             elif args["max_rc"] == 12:
-                # Will not fail but changed will be false for the non-zero RC, there
-                # are other possibilities like an ABEND or JCL ERROR will fail this even
+                # Will not fail and as the max_rc is set to 12 and the rc is 8 is a change true
+                # there are other possibilities like an ABEND or JCL ERROR will fail this even
                 # with a MAX RC
                 assert result.get("msg") is None
-                assert result.get('changed') is False
+                assert result.get('changed') is True
                 assert result.get("jobs")[0].get("ret_code").get("code") < 12
     finally:
         hosts.all.file(path=tmp_file.name, state="absent")