[zos_data_set] GDG creation failing when using replace option (#1964)

* Adding Bug fix #1958 and testcase

* Create 1964-zos_data_test-fixing-gdg-replace-issue

* Removing print statements

* fixing PR comments

Author: surendrababuravella

changelogs/fragments/1964-zos_data_test-fixing-gdg-replace-issue

@@ -0,0 +1,3 @@
+bugfixes:
+    - zos_data_set - Module would fail with TypeError when trying to replace an existing GDG. Fix now allows to replacing a GDG.
+      https://github.com/ansible-collections/ibm_zos_core/pull/1964

plugins/module_utils/data_set.py

@@ -2433,7 +2433,7 @@ def ensure_present(self, replace):
         else:
             if not replace:
                 return changed
-            changed = self.ensure_absent()
+            changed = self.ensure_absent(True)
             gdg = gdgs.create(**arguments)
         if isinstance(gdg, gdgs.GenerationDataGroupView):
             changed = True

tests/functional/modules/test_zos_data_set_func.py

@@ -1103,3 +1103,22 @@ def test_create_member_special_chars(ansible_zos_module):
     finally:
         hosts.all.zos_data_set(name=data_set_name, state="absent")
 
+
+def test_gdg_create_and_replace(ansible_zos_module):
+    try:
+        hosts = ansible_zos_module
+        data_set_name = get_tmp_ds_name()
+        results = hosts.all.zos_data_set(name=data_set_name, empty=False, force=True, record_format="u", 
+                                         record_length=0, replace=True, space_primary=5, space_secondary=3, 
+                                         space_type="cyl", state="present", type="gdg", limit=3)
+        for result in results.contacted.values():
+            assert result.get("changed") is True
+            assert result.get("module_stderr") is None
+        results = hosts.all.zos_data_set(name=data_set_name, empty=False, force=True, record_format="u", 
+                                         record_length=0, replace=True, space_primary=5, space_secondary=3, 
+                                         space_type="cyl", state="present", type="gdg", limit=3)
+        for result in results.contacted.values():
+            assert result.get("changed") is True
+            assert result.get("module_stderr") is None
+    finally:
+        hosts.all.zos_data_set(name=data_set_name, state="absent", force=True, type="gdg")