[Bug] Failure when trying to delete dataset with type 'gdg' (#1971)

* Adding if condition to check whether GDG exists or not before trying to delete

* Adding change logs

* Update year in license

* Updating impacted testcase

* Updating changelog

* Update changelogs/fragments/1971-zos_data_set-fixing-gdg-delete-issue.yml

Co-authored-by: Alex Moreno <[email protected]>

* updating testcase

---------

Co-authored-by: Alex Moreno <[email protected]>

Author: surendrababuravella

changelogs/fragments/1964-zos_data_test-fixing-gdg-replace-issue renamed to changelogs/fragments/1964-zos_data_set-fixing-gdg-replace-issue

@@ -0,0 +1,4 @@
+bugfixes:
+    - zos_data_set - Module would fail when trying to delete a non-existent Generation Data Group.
+      Fix now provides a successful response with `changed=false`.
+      (https://github.com/ansible-collections/ibm_zos_core/pull/1971)

changelogs/fragments/1971-zos_data_set-fixing-gdg-delete-issue.yml

@@ -1,4 +1,4 @@
-# Copyright (c) IBM Corporation 2020, 2024
+# Copyright (c) IBM Corporation 2020, 2025
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
@@ -2453,17 +2453,21 @@ def ensure_absent(self, force):
         int
             Indicates if changes were made.
         """
-        # Try to delete
-        rc = datasets.delete(self.name)
-        if rc > 0:
-            if force:
-                if isinstance(self.gdg, gdgs.GenerationDataGroupView):
-                    self.gdg.delete()
+        # Check whether GDG exists or not
+        if gdgs.exists(name=self.name):
+            # Try to delete
+            rc = datasets.delete(self.name)
+            if rc > 0:
+                if force:
+                    if isinstance(self.gdg, gdgs.GenerationDataGroupView):
+                        self.gdg.delete()
+                    else:
+                        gdg_view = gdgs.GenerationDataGroupView(name=self.name)
+                        gdg_view.delete()
                 else:
-                    gdg_view = gdgs.GenerationDataGroupView(name=self.name)
-                    gdg_view.delete()
-            else:
-                raise DatasetDeleteError(self.raw_name, rc)
+                    raise DatasetDeleteError(self.raw_name, rc)
+        else:
+            return False
         return True
 
     def clear(self):

plugins/module_utils/data_set.py

@@ -1,7 +1,7 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 
-# Copyright (c) IBM Corporation 2019, 2024
+# Copyright (c) IBM Corporation 2019, 2025
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at

plugins/modules/zos_data_set.py

@@ -1121,4 +1121,14 @@ def test_gdg_create_and_replace(ansible_zos_module):
             assert result.get("changed") is True
             assert result.get("module_stderr") is None
     finally:
-        hosts.all.zos_data_set(name=data_set_name, state="absent", force=True, type="gdg")
+        hosts.all.zos_data_set(name=data_set_name, state="absent", force=True, type="gdg")
+
+def test_gdg_deletion_when_absent(ansible_zos_module):
+    hosts = ansible_zos_module
+    data_set_name = get_tmp_ds_name()
+    results = hosts.all.zos_data_set(name=data_set_name, force=False, record_format="fb", replace=False, 
+                                    space_primary=5, space_secondary=3, space_type="m", state="absent", type="gdg")
+    for result in results.contacted.values():
+        assert result.get("changed") is False
+        assert result.get("module_stderr") is None
+        assert result.get("failed") is None

tests/functional/modules/test_zos_data_set_func.py

@@ -1164,8 +1164,8 @@ def test_gdg_unarchive(ansible_zos_module, dstype, format):
 
         hosts.all.zos_data_set(
             batch=[
-                {"name": f"{data_set_name}(-1)", "state": "absent", "type": "gdg"},
-                {"name": f"{data_set_name}(0)", "state": "absent", "type": "gdg"},
+                {"name": f"{data_set_name}(-1)", "state": "absent"},
+                {"name": f"{data_set_name}(0)", "state": "absent"},
             ]
         )
         unarchive_result = hosts.all.zos_unarchive(