[Bugfix][zos_data_set] Added support for batch mode when creating gdg (#1515)

* Added support for batch mode

* changed style

* Added changelog

* Corrected pyflakes

Author: fernandofloresg

changelogs/fragments/1515-gdg_batch_creation.yml

@@ -0,0 +1,4 @@
+trivial:
+  - zos_data_set - Batch mode when type=gdg failed asking for limit option.
+    Fix now accepts limit as part of batch option.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/1515).

plugins/module_utils/data_set.py

@@ -1032,7 +1032,7 @@ def create(
                 create_exception.response.rc,
                 create_exception.response.stdout_response + "\n" + create_exception.response.stderr_response
             )
-        except exceptions.DatasetVerificationError as e:
+        except exceptions.DatasetVerificationError:
             # verification of a data set spanning multiple volumes is currently broken in ZOAU v.1.3.0
             if volumes and len(volumes) > 1:
                 if DataSet.data_set_cataloged(name, volumes):

plugins/modules/zos_data_set.py

@@ -1454,7 +1454,7 @@ def parse_and_validate_args(params):
                 type=dict(
                     type=data_set_type,
                     required=False,
-                    dependencies=["state"],
+                    dependencies=["state", "limit"],
                     choices=DATA_SET_TYPES,
                 ),
                 space_type=dict(
@@ -1526,6 +1526,30 @@ def parse_and_validate_args(params):
                     aliases=["volume"],
                     dependencies=["state"],
                 ),
+                limit=dict(
+                    type="int",
+                    required=False
+                ),
+                empty=dict(
+                    type="bool",
+                    required=False
+                ),
+                purge=dict(
+                    type="bool",
+                    required=False
+                ),
+                scratch=dict(
+                    type="bool",
+                    required=False
+                ),
+                extended=dict(
+                    type="bool",
+                    required=False
+                ),
+                fifo=dict(
+                    type="bool",
+                    required=False
+                ),
                 force=dict(
                     type="bool",
                     required=False,
@@ -1598,7 +1622,7 @@ def parse_and_validate_args(params):
             default=False,
         ),
         # GDG options
-        limit=dict(type=limit_type, required=False),
+        limit=dict(type="int", required=False),
         empty=dict(type="bool", required=False),
         purge=dict(type="bool", required=False),
         scratch=dict(type="bool", required=False),
@@ -1721,7 +1745,7 @@ def run_module():
                     default=False,
                 ),
                 # GDG options
-                limit=dict(type="int", required=False, no_log=False),
+                limit=dict(type="int", required=False),
                 empty=dict(type="bool", required=False),
                 purge=dict(type="bool", required=False),
                 scratch=dict(type="bool", required=False),

tests/functional/modules/test_zos_data_set_func.py

@@ -1029,6 +1029,29 @@ def test_gdg_create_and_delete_force(ansible_zos_module):
         hosts.all.zos_data_set(name=data_set_name, state="absent", force=True, type="gdg")
 
 
+def test_gdg_create_and_delete_force(ansible_zos_module):
+    try:
+        hosts = ansible_zos_module
+        data_set_name = get_tmp_ds_name(2,2, symbols=True)
+        data_set_list = [f"{data_set_name}A", f"{data_set_name}B", f"{data_set_name}C"]
+        results = hosts.all.zos_data_set(
+            batch=[
+                {"name":data_set_list[0], "state":"present", "type":"gdg", "limit":3},
+                {"name":data_set_list[1], "state":"present", "type":"gdg", "limit":3},
+                {"name":data_set_list[2], "state":"present", "type":"gdg", "limit":3},
+            ]
+        )
+        for result in results.contacted.values():
+            assert result.get("changed") is True
+            assert result.get("module_stderr") is None
+        results = hosts.all.shell(cmd=f"dls -tGDG ANSIBLE.*")
+        for result in results.contacted.values():
+            for ds_name in data_set_list:
+                assert ds_name in result.get("stdout")
+    finally:
+        results = hosts.all.shell(cmd=f"drm ANSIBLE.*")
+
+
 def test_create_special_chars(ansible_zos_module):
     try:
         hosts = ansible_zos_module