[Bug] [zos_backup_restore] Comment test case and fixes byte removal by ZOAU (#2238)

* [Bug] [zos_backup_restore] Comment test case and fixes byte removal by ZOAU (#2236)

* Commented backup test

* Default space type value to m

* Added changelog

* Updated docs

* Update 2236-space-type-default-zos_backup_restore.yml

* Updated changelogs

Author: fernandofloresg

changelogs/fragments/2238-space-type-default-zos_backup_restore.yml

@@ -0,0 +1,4 @@
+bugfixes:
+  - zos_backup_restore - Module documentation stated that default ``space_type`` for a backup was ``m`` but module would use bytes instead.
+    Fix now uses the correct default space type.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/2238).

plugins/modules/zos_backup_restore.py

@@ -174,6 +174,7 @@
       - Valid units of size are C(k), C(m), C(g), C(cyl), and C(trk).
       - When I(full_volume=True), I(space_type) defaults to C(g), otherwise default is C(m)
     type: str
+    default: m
     choices:
       - k
       - m
@@ -412,7 +413,7 @@ def main():
             ),
         ),
         space=dict(type="int", required=False, aliases=["size"]),
-        space_type=dict(type="str", required=False, aliases=["unit"], choices=["k", "m", "g", "cyl", "trk"]),
+        space_type=dict(type="str", required=False, aliases=["unit"], choices=["k", "m", "g", "cyl", "trk"], default="m"),
         volume=dict(type="str", required=False),
         full_volume=dict(type="bool", default=False),
         temp_volume=dict(type="str", required=False, aliases=["dest_volume"]),
@@ -431,7 +432,7 @@ def main():
         operation = params.get("operation")
         data_sets = params.get("data_sets", {})
         space = params.get("space")
-        space_type = params.get("space_type")
+        space_type = params.get("space_type", "m")
         volume = params.get("volume")
         full_volume = params.get("full_volume")
         temp_volume = params.get("temp_volume")

tests/functional/modules/test_zos_backup_restore.py

@@ -254,49 +254,50 @@ def test_backup_of_data_set(ansible_zos_module, backup_name, overwrite, recover)
         delete_data_set_or_file(hosts, backup_name)
         delete_remnants(hosts)
 
-
-@pytest.mark.parametrize(
-    "backup_name,overwrite",
-    [
-        ("DATA_SET", False),
-        ("DATA_SET", True),
-        ("UNIX", False),
-        ("UNIX", True),
-    ],
-)
-def test_backup_of_data_set_when_backup_dest_exists(
-    ansible_zos_module, backup_name, overwrite
-):
-    hosts = ansible_zos_module
-    data_set_name = get_tmp_ds_name()
-    if backup_name == "DATA_SET":
-        backup_name = get_tmp_ds_name(1,1)
-    else:
-        backup_name = get_random_file_name(dir=TMP_DIRECTORY, prefix='.dzp')
-    try:
-        create_data_set_or_file_with_contents(hosts, backup_name, DATA_SET_CONTENTS)
-        assert_data_set_or_file_exists(hosts, backup_name)
-        create_sequential_data_set_with_contents(
-            hosts, data_set_name, DATA_SET_CONTENTS
-        )
-        results = hosts.all.zos_backup_restore(
-            operation="backup",
-            data_sets=dict(include=data_set_name),
-            backup_name=backup_name,
-            overwrite=overwrite,
-        )
-        if overwrite:
-            assert_module_did_not_fail(results)
-            for result in results.contacted.values():
-                assert result.get("backup_name") == backup_name, \
-                    f"Backup name '{backup_name}' not found in output"
-        else:
-            assert_module_failed(results)
-        assert_data_set_or_file_exists(hosts, backup_name)
-    finally:
-        delete_data_set_or_file(hosts, data_set_name)
-        delete_data_set_or_file(hosts, backup_name)
-        delete_remnants(hosts)
+# Commenting these tests because of issue https://github.com/ansible-collections/ibm_zos_core/issues/2235
+# which likely is a zoau bug that needs to be fixed.
+# @pytest.mark.parametrize(
+#     "backup_name,overwrite",
+#     [
+#         ("DATA_SET", False),
+#         ("DATA_SET", True),
+#         ("UNIX", False),
+#         ("UNIX", True),
+#     ],
+# )
+# def test_backup_of_data_set_when_backup_dest_exists(
+#     ansible_zos_module, backup_name, overwrite
+# ):
+#     hosts = ansible_zos_module
+#     data_set_name = get_tmp_ds_name()
+#     if backup_name == "DATA_SET":
+#         backup_name = get_tmp_ds_name(1,1)
+#     else:
+#         backup_name = get_random_file_name(dir=TMP_DIRECTORY, prefix='.dzp')
+#     try:
+#         create_data_set_or_file_with_contents(hosts, backup_name, DATA_SET_CONTENTS)
+#         assert_data_set_or_file_exists(hosts, backup_name)
+#         create_sequential_data_set_with_contents(
+#             hosts, data_set_name, DATA_SET_CONTENTS
+#         )
+#         results = hosts.all.zos_backup_restore(
+#             operation="backup",
+#             data_sets=dict(include=data_set_name),
+#             backup_name=backup_name,
+#             overwrite=overwrite,
+#         )
+#         if overwrite:
+#             assert_module_did_not_fail(results)
+#             for result in results.contacted.values():
+#                 assert result.get("backup_name") == backup_name, \
+#                     f"Backup name '{backup_name}' not found in output"
+#         else:
+#             assert_module_failed(results)
+#         assert_data_set_or_file_exists(hosts, backup_name)
+#     finally:
+#         delete_data_set_or_file(hosts, data_set_name)
+#         delete_data_set_or_file(hosts, backup_name)
+#         delete_remnants(hosts)
 
 
 @pytest.mark.parametrize(