[v1.14.1] Merge release back into dev (#2201)

fernandofloresg · web-flow · commit afe0662c946a · 2025-07-04T12:10:57.000-06:00
* Merged v1.14.1

* Updated release notes
diff --git a/.github/ISSUE_TEMPLATE/bug_issue.yml b/.github/ISSUE_TEMPLATE/bug_issue.yml
@@ -33,6 +33,7 @@ body:
       description: Which version of z/OS Ansible core collection are you using. If you are unsure, review the [documentation](https://ibm.github.io/z_ansible_collections_doc/faqs/faqs.html#how-do-i-update-a-collection-to-the-latest-version).
       multiple: false
       options:
+        - v1.14.1
         - v1.14.0
         - v1.14.0-beta.1
         - v1.13.1
diff --git a/.github/ISSUE_TEMPLATE/collaboration_issue.yml b/.github/ISSUE_TEMPLATE/collaboration_issue.yml
@@ -42,8 +42,10 @@ body:
       description: Which version of z/OS Ansible core collection are you using. If you are unsure, review the [documentation](https://ibm.github.io/z_ansible_collections_doc/faqs/faqs.html#how-do-i-update-a-collection-to-the-latest-version).
       multiple: false
       options:
+        - v1.14.1
         - v1.14.0
         - v1.14.0-beta.1
+        - v1.13.1
         - v1.13.0
         - v1.13.0-beta.1
         - v1.12.0
diff --git a/.github/ISSUE_TEMPLATE/doc_issue.yml b/.github/ISSUE_TEMPLATE/doc_issue.yml
@@ -34,6 +34,7 @@ body:
       description: Which version of z/OS Ansible core collection are you using. If you are unsure, review the [documentation](https://ibm.github.io/z_ansible_collections_doc/faqs/faqs.html#how-do-i-update-a-collection-to-the-latest-version).
       multiple: false
       options:
+        - v1.14.1
         - v1.14.0
         - v1.14.0-beta.1
         - v1.13.1
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -4,6 +4,26 @@ ibm.ibm\_zos\_core Release Notes
 
 .. contents:: Topics
 
+v1.14.1
+=======
+
+Release Summary
+---------------
+
+Release Date: '2025-07-03'
+This changelog describes all changes made to the modules and plugins included
+in this collection. The release date is the date the changelog is created.
+For additional details such as required dependencies and availability review
+the collections `release notes <https://ibm.github.io/z_ansible_collections_doc/ibm_zos_core/docs/source/release_notes.html>`__
+
+Bugfixes
+--------
+
+- zos_copy - Previously, if the ansible user was not a superuser copying a file into the managed node resulted in permission denied error. Fix now sets the correct permissions for the ansible user for copying to the remote. (https://github.com/ansible-collections/ibm_zos_core/pull/2196)
+- zos_job_submit - Previously, if the ansible user was not a superuser copying a file into the managed node resulted in permission denied error. Fix now sets the correct permissions for the ansible user for copying to the remote. (https://github.com/ansible-collections/ibm_zos_core/pull/2196)
+- zos_script - Previously, if the ansible user was not a superuser copying a file into the managed node resulted in permission denied error. Fix now sets the correct permissions for the ansible user for copying to the remote. (https://github.com/ansible-collections/ibm_zos_core/pull/2196)
+- zos_unarchive - Previously, if the ansible user was not a superuser copying a file into the managed node resulted in permission denied error. Fix now sets the correct permissions for the ansible user for copying to the remote. (https://github.com/ansible-collections/ibm_zos_core/pull/2196)
+
 v1.14.0
 =======
 
diff --git a/README.md b/README.md
@@ -133,7 +133,7 @@ All releases will meet the following test criteria.
 <br/>This release of the collection was tested with following dependencies.
 
 * ansible-core v2.15.x
-* Python 3.11.x
+* Python 3.12.x
 * IBM Open Enterprise SDK for Python 3.12.x
 * IBM Z Open Automation Utilities (ZOAU) 1.3.4.x
 * z/OS V2R5
diff --git a/changelogs/.plugin-cache.yaml b/changelogs/.plugin-cache.yaml
@@ -146,4 +146,4 @@ plugins:
   strategy: {}
   test: {}
   vars: {}
-version: 1.14.0-beta.1
+version: 1.14.1
diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml
@@ -825,6 +825,36 @@ releases:
       name: zos_stat
       namespace: ''
     release_date: '2025-04-25'
+  1.14.1:
+    changes:
+      bugfixes:
+      - zos_copy - Previously, if the ansible user was not a superuser copying a file
+        into the managed node resulted in permission denied error. Fix now sets the
+        correct permissions for the ansible user for copying to the remote. (https://github.com/ansible-collections/ibm_zos_core/pull/2196)
+      - zos_job_submit - Previously, if the ansible user was not a superuser copying
+        a file into the managed node resulted in permission denied error. Fix now
+        sets the correct permissions for the ansible user for copying to the remote.
+        (https://github.com/ansible-collections/ibm_zos_core/pull/2196)
+      - zos_script - Previously, if the ansible user was not a superuser copying a
+        file into the managed node resulted in permission denied error. Fix now sets
+        the correct permissions for the ansible user for copying to the remote. (https://github.com/ansible-collections/ibm_zos_core/pull/2196)
+      - zos_unarchive - Previously, if the ansible user was not a superuser copying
+        a file into the managed node resulted in permission denied error. Fix now
+        sets the correct permissions for the ansible user for copying to the remote.
+        (https://github.com/ansible-collections/ibm_zos_core/pull/2196)
+      release_summary: 'Release Date: ''2025-07-03''
+
+        This changelog describes all changes made to the modules and plugins included
+
+        in this collection. The release date is the date the changelog is created.
+
+        For additional details such as required dependencies and availability review
+
+        the collections `release notes <https://ibm.github.io/z_ansible_collections_doc/ibm_zos_core/docs/source/release_notes.html>`__'
+    fragments:
+    - 2196-fix-copy-permission-issues.yml
+    - v1.14.1_summary.yml
+    release_date: '2025-07-01'
   1.2.1:
     changes:
       bugfixes:
diff --git a/changelogs/fragments/2115-copy-fix-tmp-dir.yml b/changelogs/fragments/2115-copy-fix-tmp-dir.yml
diff --git a/docs/source/release_notes.rst b/docs/source/release_notes.rst
@@ -6,6 +6,29 @@
 Releases
 ========
 
+Version 1.14.1
+==============
+
+Bugfixes
+--------
+
+- zos_copy - Previously, if the Ansible user was not a superuser copying a file into the managed node resulted in a permission denied error. Fix now sets the correct permissions for the Ansible user for copying to the remote.
+- zos_job_submit - Previously, if the Ansible user was not a superuser copying a file into the managed node resulted in a permission denied error. Fix now sets the correct permissions for the Ansible user for copying to the remote.
+- zos_script - Previously, if the Ansible user was not a superuser copying a file into the managed node resulted in a permission denied error. Fix now sets the correct permissions for the Ansible user for copying to the remote.
+- zos_unarchive - Previously, if the Ansible user was not a superuser copying a file into the managed node resulted in a permission denied error. Fix now sets the correct permissions for the Ansible user for copying to the remote.
+
+Availability
+------------
+
+* `Ansible Automation Platform`_
+* `Galaxy`_
+* `GitHub`_
+
+Known Issues
+------------
+- ``zos_copy`` - Copying from a sequential data set that is in use will result in a false positive and destination data set will be empty. The same is true when ``type=gdg`` and source GDS is a sequential data set in use.
+
+
 Version 1.14.0
 ==============
 
diff --git a/galaxy.yml b/galaxy.yml
@@ -6,7 +6,7 @@ namespace: ibm
 name: ibm_zos_core
 
 # The collection version
-version: "1.14.0"
+version: "1.14.1"
 
 # Collection README file
 readme: README.md
diff --git a/meta/ibm_zos_core_meta.yml b/meta/ibm_zos_core_meta.yml
@@ -1,5 +1,5 @@
 name: ibm_zos_core
-version: "1.14.0"
+version: "1.14.1"
 managed_requirements:
     -
         name: "IBM Open Enterprise SDK for Python"
diff --git a/plugins/action/zos_copy.py b/plugins/action/zos_copy.py
@@ -291,26 +291,7 @@ def run(self, tmp=None, task_vars=None):
         # Remove temporary directory from remote
         if self.tmp_dir is not None:
             path = os.path.normpath(f"{self.tmp_dir}/ansible-zos-copy")
-            # If another user created the temporary files, we'll need to run rm
-            # with it too, lest we get a permissions issue.
-            if self._connection.become:
-                # We get the dirname from temp_path and not path = os.path.normpath(f"{self.tmp_dir}/ansible-zos-copy")
-                # because if default is ~/.ansible/tmp/ when using become it would be similar to /root/.ansible/tmp
-                # but the original tmp directory was resolved when user is non escalated yet. Meaning, the original
-                # tmp directory is similar to /u/usrt001/.ansible/tmp.
-                path = os.path.dirname(temp_path)
-                self._connection.set_option('remote_user', self._play_context._become_user)
-                display.vvv(
-                    u"ibm_zos_copy SSH cleanup user updated to {0}".format(self._play_context._become_user),
-                    host=self._play_context.remote_addr
-                )
             rm_res = self._connection.exec_command(f"rm -rf {path}*")
-            if self._connection.become:
-                self._connection.set_option('remote_user', self._play_context._remote_user)
-                display.vvv(
-                    u"ibm_zos_copy SSH cleanup user restored to {0}".format(self._play_context._remote_user),
-                    host=self._play_context.remote_addr
-                )
 
         if copy_res.get("note") and not force:
             result["note"] = copy_res.get("note")
@@ -342,16 +323,24 @@ def _copy_to_remote(self, src, is_dir=False, ignore_stderr=False, task_vars=None
         """Copy a file or directory to the remote z/OS system """
         self.tmp_dir = self._connection._shell._options.get("remote_tmp")
         temp_path = os.path.join(self.tmp_dir, _create_temp_path_name())
-        tempfile_args = {"path": temp_path, "state": "directory", "mode": "666"}
-        # Reverted this back to using file ansible module so ansible would handle all temporary dirs
-        # creation with correct permissions.
-        tempfile = self._execute_module(
-            module_name="file", module_args=tempfile_args, task_vars=task_vars, wrap_async=self._task.async_val
-        )
+
+        rc, stdout, stderr = self._connection.exec_command("mkdir -p {0}".format(temp_path))
+        display.vvv(f"ibm_zos_copy: remote mkdir result {rc}, {stdout}, {stderr} path {temp_path}")
+        if rc > 0:
+            msg = f"Failed to create remote temporary directory in {self.tmp_dir}. Ensure that user has proper access."
+            return self._exit_action({}, msg, failed=True)
+
+        # The temporary dir was created successfully using ssh connection user.
+        rc, stdout, stderr = self._connection.exec_command(F"cd {temp_path} && pwd")
+        display.vvv(f"ibm_zos_copy: remote pwd result {rc}, {stdout}, {stderr} path {temp_path}")
+        if rc > 0:
+            msg = f"Failed to resolve remote temporary directory {temp_path}. Ensure that user has proper access."
+            return self._exit_action({}, msg, failed=True)
+        temp_path = stdout.decode("utf-8").replace("\r", "").replace("\n", "")
+
         _sftp_action = 'put'
-        was_user_updated = False
 
-        temp_path = os.path.join(tempfile.get("path"), os.path.basename(src))
+        temp_path = os.path.join(temp_path, os.path.basename(src))
         _src = src.replace("#", "\\#")
         full_temp_path = temp_path
 
@@ -392,13 +381,7 @@ def _copy_to_remote(self, src, is_dir=False, ignore_stderr=False, task_vars=None
                             sftp_transfer_method), host=self._play_context.remote_addr)
 
             display.vvv(u"ibm_zos_copy: {0} {1} TO {2}".format(_sftp_action, _src, temp_path), host=self._play_context.remote_addr)
-            if self._connection.become:
-                was_user_updated = True
-                self._connection.set_option('remote_user', self._play_context._become_user)
-                display.vvv(
-                    u"ibm_zos_copy SSH transfer user updated to {0}".format(self._play_context._become_user),
-                    host=self._play_context.remote_addr
-                )
+
             (returncode, stdout, stderr) = self._connection._file_transport_command(_src, temp_path, _sftp_action)
 
             display.vvv(u"ibm_zos_copy return code: {0}".format(returncode), host=self._play_context.remote_addr)
@@ -438,13 +421,6 @@ def _copy_to_remote(self, src, is_dir=False, ignore_stderr=False, task_vars=None
 
         finally:
             # Restore the users defined option `ssh_transfer_method` if it was overridden
-            if was_user_updated:
-                self._connection.set_option('remote_user', self._play_context._remote_user)
-                display.vvv(
-                    u"ibm_zos_copy SSH transfer user restored to {0}".format(self._play_context._remote_user),
-                    host=self._play_context.remote_addr
-                )
-
             if is_ssh_transfer_method_updated:
                 if version_major == 2 and version_minor >= 11:
                     self._connection.set_option('ssh_transfer_method', user_ssh_transfer_method)
diff --git a/plugins/action/zos_job_submit.py b/plugins/action/zos_job_submit.py
@@ -79,13 +79,22 @@ def run(self, tmp=None, task_vars=None):
             tmp_dir = self._connection._shell._options.get("remote_tmp")
             temp_file_dir = f'zos_job_submit_{datetime.now().strftime("%Y%m%d%S%f")}'
             dest_path = path.join(tmp_dir, temp_file_dir)
-            tempfile_args = {"path": dest_path, "state": "directory"}
-            # Reverted this back to using file ansible module so ansible would handle all temporary dirs
-            # creation with correct permissions.
-            tempfile = self._execute_module(
-                module_name="file", module_args=tempfile_args, task_vars=task_vars,
-            )
-            dest_path = tempfile.get("path")
+
+            rc, stdout, stderr = self._connection.exec_command("mkdir -p {0}".format(dest_path))
+            display.vvv(f"zos_job_submit: mkdir result {rc}, {stdout}, {stderr} dest path {dest_path}")
+            if rc > 0:
+                result["failed"] = True
+                result["msg"] = f"Failed to create remote temporary directory in {tmp_dir}. Ensure that user has proper access."
+                return result
+
+            # The temporary dir was created successfully using ssh connection user.
+            rc, stdout, stderr = self._connection.exec_command(F"cd {dest_path} && pwd")
+            display.vvv(f"zos_job_submit: remote pwd result {rc}, {stdout}, {stderr} path {dest_path}")
+            if rc > 0:
+                result["failed"] = True
+                result["msg"] = f"Failed to resolve remote temporary directory {dest_path}. Ensure that user has proper access."
+                return result
+            dest_path = stdout.decode("utf-8").replace("\r", "").replace("\n", "")
             dest_file = path.join(dest_path, path.basename(source))
 
             source_full = None
