[Enhancement][1765]enhance_error_message_when_faiiling_to_import (#1804)

* Classes for Exception on required by python

* Correct creation of zoau

* Continue experimenting

* Fix issue

* Fix lint

* Add fragment

* Update changelogs/fragments/1804_enhance_error_message_when_failing_import.yml

Co-authored-by: Fernando Flores <[email protected]>

* Fix docstring

---------

Co-authored-by: Fernando Flores <[email protected]>

Author: AndreMarcel99

changelogs/fragments/1804_enhance_error_message_when_failing_import.yml

@@ -0,0 +1,4 @@
+minor_changes:
+  - module_utils/import_handler - When importing a non supported ZOAU version like 1.2.x the module would throw a non user friendly error message.
+    Error message is now explicit about ZOAU not being properly configured for Ansible.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/1804).

plugins/module_utils/import_handler.py

@@ -39,7 +39,6 @@ def method(*args, **kwargs):
                     "Ensure environment variables are properly configured in Ansible for use with ZOAU."
                 )
             )
-
         return method
 
 
@@ -81,30 +80,25 @@ def __getattr__(self, name):
         and instead return a method that will alert the user that there was
         an error while importing ZOAU.
         """
-        def method(*args, **kwargs):
-            """Raises ImportError as a result of a failed ZOAU import.
+        """Raises ImportError as a result of a failed ZOAU import.
 
-            Parameters
-            ----------
-            *args : dict
-                Arguments ordered in a dictionary.
-            **kwargs : dict
-                Arguments ordered in a dictionary.
+        Parameters
+        ----------
+        name : str
+            Value of object not properly imported.
 
-            Raises
-            ------
-            ImportError
-                Unable to import a module or library.
-            """
-            raise ImportError(
-                (
-                    "ZOAU is not properly configured for Ansible. Unable to import zoautil_py. "
-                    "Ensure environment variables are properly configured in Ansible for use with ZOAU. "
-                    "Complete traceback: {0}".format(self.traceback)
-                )
+        Raises
+        ------
+        ImportError
+            Unable to import a module or library.
+        """
+        raise ImportError(
+            (
+                "ZOAU is not properly configured for Ansible. Unable to import zoautil_py. "
+                "Ensure environment variables are properly configured in Ansible for use with ZOAU. "
+                "Complete traceback: {0}".format(self.traceback)
             )
-
-        return method
+        )
 
 
 class MissingImport(object):
@@ -124,21 +118,16 @@ def __init__(self, import_name=""):
         self.import_name = import_name
 
     def __getattr__(self, name):
-        def method(*args, **kwargs):
-            """Raises ImportError as a result of trying to import a missing module.
-
-            Parameter
-            ---------
-            *args : dict
-                Arguments ordered in a dictionary.
-            **kwargs : dict
-                Arguments ordered in a dictionary.
+        """Raises ImportError as a result of trying to import a missing module.
 
-            Raises
-            ------
-            ImportError
-                Unable to import a module or library.
-            """
-            raise ImportError("Import {0} was not available.".format(self.import_name))
+        Parameter
+        ---------
+        name : str
+            Value of object not properly imported.
 
-        return method
+        Raises
+        ------
+        ImportError
+            Unable to import a module or library.
+        """
+        raise ImportError("Import {0} was not available.".format(self.import_name))