Update/595 596 617 618/ansible core 2 12 latest support (#627)

* Add regex to ignore all venv(s)

Signed-off-by: ddimatos <[email protected]>

* Update sanity for error Sanity test 'compile-2.6' does not test path 'plugins/action/zos_fetch.py'

Signed-off-by: ddimatos <[email protected]>

* Ling error zos_job_submit.py pylint:catching-non-exception

Signed-off-by: ddimatos <[email protected]>

* Synch makefile to dev branch

Signed-off-by: ddimatos <[email protected]>

* Update supported ansible-core versions per Hub requirements

Signed-off-by: ddimatos <[email protected]>

* Resolves using variable 'source_full' before assignment

Signed-off-by: ddimatos <[email protected]>

* Update modules to address validate-modules doc req for FQCN and globla var usage

Signed-off-by: ddimatos <[email protected]>

* Update ignore files to support ansible-core 2.13 and 2.14

Signed-off-by: ddimatos <[email protected]>

* ansible-core 2.15 test ignore file

Signed-off-by: ddimatos <[email protected]>

* Correct Argument 'tag_untagged' in argument_spec defines default as ('') , appears empty string not needed

Signed-off-by: ddimatos <[email protected]>

* address lint issue catching-non-exception

Signed-off-by: ddimatos <[email protected]>

* Correcting ansible-test ignore file to remove doc-default-does-not-match-spec

Signed-off-by: ddimatos <[email protected]>

* ansible-test lint correction catching-non-exception: Catching an exception which doesn't inherit from Exception

Signed-off-by: ddimatos <[email protected]>

* ansible-test revealed doc-default-does-not-match-spec: Argument 'space_primary' in argument_spec found in batch defines default as (None)

Signed-off-by: ddimatos <[email protected]>

* ansible-test revealed doc-default-does-not-match-spec: Argument 'space_primary' in argument_spec found in batch defines default as (None)

Signed-off-by: ddimatos <[email protected]>

* ansible-test correction for 'doc-default-does-not-match-spec' on 'plugins/modules/zos_data_set.py' is unnecessary

Signed-off-by: ddimatos <[email protected]>

* Upate ignore files as lint issue default-does-not-match-spec has been corrected in source

Signed-off-by: ddimatos <[email protected]>

* Removed contents from requiements file to satisfy dependabot and that we no longer need them

Signed-off-by: ddimatos <[email protected]>

* Update files with supported ansible version

Signed-off-by: ddimatos <[email protected]>

* Update requirements.txt to no contents, there is no need for it anymore

Signed-off-by: ddimatos <[email protected]>

* update modules with copyright year

Signed-off-by: ddimatos <[email protected]>

* update modules with copyright year

Signed-off-by: ddimatos <[email protected]>

* Update modules documentation

Signed-off-by: ddimatos <[email protected]>

* Update ping module doc

Signed-off-by: ddimatos <[email protected]>

* Updates the makefile and related scripts for the latest mounts (#628)

* Update makefile coments and use --ignore for pytest

Signed-off-by: ddimatos <[email protected]>

* lexicographical order targets

Signed-off-by: ddimatos <[email protected]>

* Update makefile and artifacts to support new mounts

Signed-off-by: ddimatos <[email protected]>

* Removing encrypted versions of the scripts, no longer senstive content

Signed-off-by: ddimatos <[email protected]>

---------

Signed-off-by: ddimatos <[email protected]>

* Propagate error message for clarity to end user

Signed-off-by: ddimatos <[email protected]>

* Update module doc to remove FB default reference and sync with code

Signed-off-by: ddimatos <[email protected]>

* Update helper with more targeted verbosity

Signed-off-by: ddimatos <[email protected]>

* Update print stmts for helper

Signed-off-by: ddimatos <[email protected]>

* update to corret lint issue

Signed-off-by: ddimatos <[email protected]>

* exclude scripts directory from collection build

Signed-off-by: ddimatos <[email protected]>

* Corrected mutual exclusion exclsive temporarily to meet certification

Signed-off-by: ddimatos <[email protected]>

* Update test case with added wait time for job submission

Signed-off-by: ddimatos <[email protected]>

* Update tests with added pytest markers

Signed-off-by: ddimatos <[email protected]>

* hacked in additional logic so that if this test fails the job is put to stdout

Signed-off-by: ddimatos <[email protected]>

* disable log purge

Signed-off-by: ddimatos <[email protected]>

* Update test case to account for more time as a result of slow network

Signed-off-by: ddimatos <[email protected]>

* add changelog fragement for release tasks

Signed-off-by: ddimatos <[email protected]>

---------

Signed-off-by: ddimatos <[email protected]>

Author: ddimatos

Makefile

@@ -49,7 +49,7 @@ and ansible-doc to automate tasks on z/OS.
 
 Ansible version compatibility
 =============================
-This collection has been tested against the following Ansible versions: >=2.9, 2.11.
+This collection has been tested against the following Ansible versions: >=2.9,<=2.14.1.
 
 Copyright
 =========

README.md

@@ -0,0 +1,19 @@
+trivial:
+  - Update documentation to use link L(...) over M(...) meta.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)
+  - Update modules such doc defaults match module defaults.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)
+  - Initialize variables to meet linting requirements.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)
+  - Remove unused global vars.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)
+  - Update Makefile tooling.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)
+  - Remove requirements.txt because it is maintained in the pipeline.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)
+  - Complete Ansible certification for versions 2.12, 2.13, 2.14 and 2.15.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)
+  - Update and add certification files ignore.txt.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)
+  - Update test cases with added checks.
+    (https://github.com/ansible-collections/ibm_zos_core/pull/627)

changelogs/fragments/627-all-modules.yml

@@ -151,7 +151,7 @@ tmp_hlq
 
 
 encoding
-  The character set of the source *src*. :ref:`zos_blockinfile <zos_blockinfile_module>` requires to be provided with correct encoding to read the content of USS file or data set. If this parameter is not provided, this module assumes that USS file or data set is encoded in IBM-1047.
+  The character set of the source *src*. `zos_blockinfile <./zos_blockinfile.html>`_ requires it to be provided with correct encoding to read the content of a USS file or data set. If this parameter is not provided, this module assumes that USS file or data set is encoded in IBM-1047.
 
   Supported character sets rely on the charset conversion utility (iconv) version; the most common character sets are supported.
 
@@ -253,7 +253,7 @@ Notes
 .. note::
    It is the playbook author or user's responsibility to avoid files that should not be encoded, such as binary files. A user is described as the remote user, configured either for the playbook or playbook tasks, who can also obtain escalated privileges to execute as root or another user.
 
-   All data sets are always assumed to be cataloged. If an uncataloged data set needs to be encoded, it should be cataloged first. The :ref:`zos_data_set <zos_data_set_module>` module can be used to catalog uncataloged data sets.
+   All data sets are always assumed to be cataloged. If an uncataloged data set needs to be encoded, it should be cataloged first. The `zos_data_set <./zos_data_set.html>`_ module can be used to catalog uncataloged data sets.
 
    For supported character sets used to encode data, refer to the `documentation <https://ibm.github.io/z_ansible_collections_doc/ibm_zos_core/docs/source/resources/character_set.html>`_.
 

docs/source/modules/zos_blockinfile.rst

@@ -16,7 +16,7 @@ zos_copy -- Copy data to z/OS
 
 Synopsis
 --------
-- The :ref:`zos_copy <zos_copy_module>` module copies a file or data set from a local or a remote machine to a location on the remote machine.
+- The `zos_copy <./zos_copy.html>`_ module copies a file or data set from a local or a remote machine to a location on the remote machine.
 
 
 
@@ -562,7 +562,7 @@ Notes
 
    For supported character sets used to encode data, refer to the `documentation <https://ibm.github.io/z_ansible_collections_doc/ibm_zos_core/docs/source/resources/character_set.html>`_.
 
-   :ref:`zos_copy <zos_copy_module>` uses SFTP (Secure File Transfer Protocol) for the underlying transfer protocol; Co:Z SFTP is not supported. In the case of Co:z SFTP, you can exempt the Ansible userid on z/OS from using Co:Z thus falling back to using standard SFTP.
+   `zos_copy <./zos_copy.html>`_ uses SFTP (Secure File Transfer Protocol) for the underlying transfer protocol; Co:Z SFTP is not supported. In the case of Co:z SFTP, you can exempt the Ansible userid on z/OS from using Co:Z thus falling back to using standard SFTP.
 
 
 

docs/source/modules/zos_copy.rst

@@ -231,10 +231,10 @@ volumes
   If creating a data set, *volumes* specifies the volume(s) where the data set should be created.
 
 
-  If *volumes* is provided when *state=present*, and the data set is not found in the catalog, :ref:`zos_data_set <zos_data_set_module>` will check the volume table of contents to see if the data set exists. If the data set does exist, it will be cataloged.
+  If *volumes* is provided when *state=present*, and the data set is not found in the catalog, `zos_data_set <./zos_data_set.html>`_ will check the volume table of contents to see if the data set exists. If the data set does exist, it will be cataloged.
 
 
-  If *volumes* is provided when *state=absent* and the data set is not found in the catalog, :ref:`zos_data_set <zos_data_set_module>` will check the volume table of contents to see if the data set exists. If the data set does exist, it will be cataloged and promptly removed from the system.
+  If *volumes* is provided when *state=absent* and the data set is not found in the catalog, `zos_data_set <./zos_data_set.html>`_ will check the volume table of contents to see if the data set exists. If the data set does exist, it will be cataloged and promptly removed from the system.
 
 
   *volumes* is required when *state=cataloged*.
@@ -478,10 +478,10 @@ batch
     If creating a data set, *volumes* specifies the volume(s) where the data set should be created.
 
 
-    If *volumes* is provided when *state=present*, and the data set is not found in the catalog, :ref:`zos_data_set <zos_data_set_module>` will check the volume table of contents to see if the data set exists. If the data set does exist, it will be cataloged.
+    If *volumes* is provided when *state=present*, and the data set is not found in the catalog, `zos_data_set <./zos_data_set.html>`_ will check the volume table of contents to see if the data set exists. If the data set does exist, it will be cataloged.
 
 
-    If *volumes* is provided when *state=absent* and the data set is not found in the catalog, :ref:`zos_data_set <zos_data_set_module>` will check the volume table of contents to see if the data set exists. If the data set does exist, it will be cataloged and promptly removed from the system.
+    If *volumes* is provided when *state=absent* and the data set is not found in the catalog, `zos_data_set <./zos_data_set.html>`_ will check the volume table of contents to see if the data set exists. If the data set does exist, it will be cataloged and promptly removed from the system.
 
 
     *volumes* is required when *state=cataloged*.

docs/source/modules/zos_data_set.rst

@@ -203,7 +203,7 @@ Notes
 
    For supported character sets used to encode data, refer to the `documentation <https://ibm.github.io/z_ansible_collections_doc/ibm_zos_core/docs/source/resources/character_set.html>`_.
 
-   :ref:`zos_fetch <zos_fetch_module>` uses SFTP (Secure File Transfer Protocol) for the underlying transfer protocol; Co:Z SFTP is not supported. In the case of Co:z SFTP, you can exempt the Ansible userid on z/OS from using Co:Z thus falling back to using standard SFTP.
+   `zos_fetch <./zos_fetch.html>`_ uses SFTP (Secure File Transfer Protocol) for the underlying transfer protocol; Co:Z SFTP is not supported. In the case of Co:z SFTP, you can exempt the Ansible userid on z/OS from using Co:Z thus falling back to using standard SFTP.
 
 
 

docs/source/modules/zos_fetch.rst

@@ -192,9 +192,9 @@ Notes
 -----
 
 .. note::
-   Only cataloged data sets will be searched. If an uncataloged data set needs to be searched, it should be cataloged first. The :ref:`zos_data_set <zos_data_set_module>` module can be used to catalog uncataloged data sets.
+   Only cataloged data sets will be searched. If an uncataloged data set needs to be searched, it should be cataloged first. The `zos_data_set <./zos_data_set.html>`_ module can be used to catalog uncataloged data sets.
 
-   The :ref:`zos_find <zos_find_module>` module currently does not support wildcards for high level qualifiers. For example, ``SOME.*.DATA.SET`` is a valid pattern, but ``*.DATA.SET`` is not.
+   The `zos_find <./zos_find.html>`_ module currently does not support wildcards for high level qualifiers. For example, ``SOME.*.DATA.SET`` is a valid pattern, but ``*.DATA.SET`` is not.
 
    If a data set pattern is specified as ``USER.*``, the matching data sets will have two name segments such as ``USER.ABC``, ``USER.XYZ`` etc. If a wildcard is specified as ``USER.*.ABC``, the matching data sets will have three name segments such as ``USER.XYZ.ABC``, ``USER.TEST.ABC`` etc.
 

docs/source/modules/zos_find.rst

@@ -58,7 +58,7 @@ location
 
 
 wait
-  Configuring wait used by the :ref:`zos_job_submit <zos_job_submit_module>` module has been deprecated and will be removed in ibm.ibm_zos_core collection.
+  Configuring wait used by the `zos_job_submit <./zos_job_submit.html>`_ module has been deprecated and will be removed in ibm.ibm_zos_core collection.
 
   Setting this option will yield no change, it is deprecated.
 
@@ -98,7 +98,9 @@ return_output
 volume
   The volume serial (VOLSER)is where the data set resides. The option is required only when the data set is not cataloged on the system.
 
-  When configured, the :ref:`zos_job_submit <zos_job_submit_module>` will try to catalog the data set for the volume serial. If it is not able to, the module will fail. Ignored for USS and LOCAL.
+  When configured, the `zos_job_submit <./zos_job_submit.html>`_ will try to catalog the data set for the volume serial. If it is not able to, the module will fail.
+
+  Ignored for USS and LOCAL.
 
   | **required**: False
   | **type**: str

docs/source/modules/zos_job_submit.rst

@@ -176,7 +176,7 @@ firstmatch
 
 
 encoding
-  The character set of the source *src*. :ref:`zos_lineinfile <zos_lineinfile_module>` requires to be provided with correct encoding to read the content of USS file or data set. If this parameter is not provided, this module assumes that USS file or data set is encoded in IBM-1047.
+  The character set of the source *src*. `zos_lineinfile <./zos_lineinfile.html>`_ requires to be provided with correct encoding to read the content of USS file or data set. If this parameter is not provided, this module assumes that USS file or data set is encoded in IBM-1047.
 
   Supported character sets rely on the charset conversion utility (iconv) version; the most common character sets are supported.