Skip to content

Commit fa9a694

Browse files
[Enabler][test_zos_job_query_func] Update test suites on functional/modules/test_zos_job_query_func.py to be pylint correct (#1462)
* Update test suites on functional/module-utils/test_zos_data_set_func.py to be pylint correct * Correct functional/modules/test_zos_data_set_func.py * Correct functional/modules/test_zos_data_set_func.py * Update test suites on functional/modules/test_zos_job_query_func.py to be pylint correct * Update test_zos_job_query_func.py --------- Co-authored-by: André Marcel Gutiérrez Benítez <[email protected]>
1 parent 0354fe3 commit fa9a694

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

tests/functional/modules/test_zos_job_query_func.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515

1616
__metaclass__ = type
1717

18+
import tempfile
1819
import ansible.constants
1920
import ansible.errors
2021
import ansible.utils
2122
import pytest
22-
from pprint import pprint
2323
from shellescape import quote
24-
import tempfile
2524

2625
from ibm_zos_core.tests.helpers.dataset import get_tmp_ds_name
2726

@@ -51,19 +50,19 @@ def test_zos_job_query_func(ansible_zos_module):
5150
def test_zos_job_id_query_multi_wildcards_func(ansible_zos_module):
5251
try:
5352
hosts = ansible_zos_module
54-
JDATA_SET_NAME = get_tmp_ds_name()
53+
jdata_set_name = get_tmp_ds_name()
5554
hosts.all.file(path=TEMP_PATH, state="directory")
5655
hosts.all.shell(
57-
cmd="echo {0} > {1}/SAMPLE".format(quote(JCLQ_FILE_CONTENTS), TEMP_PATH)
56+
cmd=f"echo {quote(JCLQ_FILE_CONTENTS)} > {TEMP_PATH}/SAMPLE"
5857
)
5958
hosts.all.zos_data_set(
60-
name=JDATA_SET_NAME, state="present", type="pds", replace=True
59+
name=jdata_set_name, state="present", type="pds", replace=True
6160
)
6261
hosts.all.shell(
63-
cmd="cp {0}/SAMPLE \"//'{1}(SAMPLE)'\"".format(TEMP_PATH, JDATA_SET_NAME)
62+
cmd=f"cp {TEMP_PATH}/SAMPLE \"//'{jdata_set_name}(SAMPLE)'\""
6463
)
6564
results = hosts.all.zos_job_submit(
66-
src="{0}(SAMPLE)".format(JDATA_SET_NAME), location="data_set", wait_time_s=10
65+
src=f"{jdata_set_name}(SAMPLE)", location="data_set", wait_time_s=10
6766
)
6867
for result in results.contacted.values():
6968
assert result.get("jobs")[0].get("ret_code").get("msg_code") == "0000"
@@ -77,26 +76,26 @@ def test_zos_job_id_query_multi_wildcards_func(ansible_zos_module):
7776

7877
finally:
7978
hosts.all.file(path=TEMP_PATH, state="absent")
80-
hosts.all.zos_data_set(name=JDATA_SET_NAME, state="absent")
79+
hosts.all.zos_data_set(name=jdata_set_name, state="absent")
8180

8281

8382
# test to show multi wildcard in Job_name query won't crash the search
8483
def test_zos_job_name_query_multi_wildcards_func(ansible_zos_module):
8584
try:
8685
hosts = ansible_zos_module
87-
NDATA_SET_NAME = get_tmp_ds_name()
86+
ndata_set_name = get_tmp_ds_name()
8887
hosts.all.file(path=TEMP_PATH, state="directory")
8988
hosts.all.shell(
90-
cmd="echo {0} > {1}/SAMPLE".format(quote(JCLQ_FILE_CONTENTS), TEMP_PATH)
89+
cmd=f"echo {quote(JCLQ_FILE_CONTENTS)} > {TEMP_PATH}/SAMPLE"
9190
)
9291
hosts.all.zos_data_set(
93-
name=NDATA_SET_NAME, state="present", type="pds", replace=True
92+
name=ndata_set_name, state="present", type="pds", replace=True
9493
)
9594
hosts.all.shell(
96-
cmd="cp {0}/SAMPLE \"//'{1}(SAMPLE)'\"".format(TEMP_PATH, NDATA_SET_NAME)
95+
cmd=f"cp {TEMP_PATH}/SAMPLE \"//'{ndata_set_name}(SAMPLE)'\""
9796
)
9897
results = hosts.all.zos_job_submit(
99-
src="{0}(SAMPLE)".format(NDATA_SET_NAME), location="data_set", wait_time_s=10
98+
src=f"{ndata_set_name}(SAMPLE)", location="data_set", wait_time_s=10
10099
)
101100
for result in results.contacted.values():
102101
assert result.get("jobs")[0].get("ret_code").get("msg_code") == "0000"
@@ -109,7 +108,7 @@ def test_zos_job_name_query_multi_wildcards_func(ansible_zos_module):
109108

110109
finally:
111110
hosts.all.file(path=TEMP_PATH, state="absent")
112-
hosts.all.zos_data_set(name=NDATA_SET_NAME, state="absent")
111+
hosts.all.zos_data_set(name=ndata_set_name, state="absent")
113112

114113

115114
def test_zos_job_id_query_short_ids_func(ansible_zos_module):

0 commit comments

Comments
 (0)