Skip to content

Conversation

mariolenz
Copy link
Collaborator

Ref: https://forum.ansible.com/t/44150
Ref: ansible-collections/ansible-inclusion#80

Opening as a draft, because the time to merge depends on what we decide in https://forum.ansible.com/t/44186.

Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until the issues with CI testing raised in ansible-collections/ansible-inclusion#80 are addressed

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my point of view, the issues have been resolved.

@felixfontein felixfontein requested a review from gotmax23 August 19, 2025 05:33
@felixfontein felixfontein marked this pull request as ready for review August 19, 2025 05:38
@mariolenz
Copy link
Collaborator Author

What do you think @gotmax23?

@gotmax23
Copy link
Contributor

I would prefer to wait until 12.1.0, since the main reason for lifting the feature freeze as far as I understood was because of the network collections and to avoid holding back bugfixes for collections that are already part of the ansible package. But if others feel strongly that this should be included in the next pre-release since we already paused the feature freeze, that's fine with me.

@felixfontein
Copy link
Contributor

I'm fine with both (waiting and merging now). Waiting would mean that we wait at least two more weeks before merging this (assuming we do 12.0.0b4 this week, 12.0.0rc1 next week, and 12.0.0 in two weeks). For Ansible 11, this doesn't make a difference, since the 11.10.0 release is in three weeks anyway. But if 12.0.0 gets delayed by more than two weeks compared to the schedule I sketched above, this would have to wait for 11.11.0 (unless we split it up into two PRs).

@mariolenz @anweshadas what do you think?

@mariolenz
Copy link
Collaborator Author

I feel it's a little unfair on the ravendb guys that they have to wait even longer. If it wasn't for the very unfortunate situation with the network collections, we'd have included this already. And this situation is not their fault.

On the other hand, I'm also fine with waiting until 2.1.0. Actually, I'm beginning to think that it probably would be better to wait.

@felixfontein
Copy link
Contributor

Then my suggestion would be to wait until 12.0.0 is out before merging, unless 11.10.0 happens earlier, in which case we'd split this PR up into one for Ansible 11 and one for Ansible 12, so that ravendb.ravendb will definitely be included in Ansible 11.10.0, the next Ansible 11 release. Is that OK for everyone?

@felixfontein
Copy link
Contributor

I created #592 from this PR that only contains the Ansible 11 changes.

@mariolenz mariolenz changed the title Add ravendb.ravendb to Ansible 11 and 12 Add ravendb.ravendb to Ansible 12 Aug 27, 2025
@mariolenz
Copy link
Collaborator Author

I've removed the Ansible 11 changes from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants