Minor molecule cleanups (#401)

TobiX · web-flow · commit b71725746d4b · 2025-12-11T20:57:05.000+01:00
* test: refactor molecule preparations (DRY)

* test: stub away vault enterprise service

The Vault Enterprise binary doesn't start without a license, so we
"fake" it. This should make those molecule tests more stable.
diff --git a/molecule/almalinux-9/prepare.yml b/molecule/almalinux-9/prepare.yml
@@ -1,22 +1,6 @@
 ---
-- name: Prepare controlling host
-  hosts: localhost
-  connection: local
-
-  tasks:
-    - name: Prepare CI environment
-      when: lookup('env', 'CI') is truthy
-      block:
-        - name: Install OS packages on controlling host
-          when: ansible_distribution != 'MacOSX'
-          ansible.builtin.package:
-            name: unzip
-          become: true
-
-        - name: Install netaddr dependency on controlling host
-          ansible.builtin.pip:
-            name: netaddr
-          become: false
+- name: Common prepare
+  ansible.builtin.import_playbook: ../prepare.yml
 
 - name: Prepare AlmaLinux
   hosts: all
@@ -26,4 +10,4 @@
         path: /etc/shadow
         mode: '0640'
         owner: root
-        group: root
+        group: root
diff --git a/molecule/archlinux/prepare.yml b/molecule/archlinux/prepare.yml
@@ -1,22 +1,6 @@
 ---
-- name: Prepare controlling host
-  hosts: localhost
-  connection: local
-
-  tasks:
-    - name: Prepare CI environment
-      when: lookup('env', 'CI') is truthy
-      block:
-        - name: Install OS packages on controlling host
-          when: ansible_distribution != 'MacOSX'
-          ansible.builtin.package:
-            name: unzip
-          become: true
-
-        - name: Install netaddr dependency on controlling host
-          ansible.builtin.pip:
-            name: netaddr
-          become: false
+- name: Common prepare
+  ansible.builtin.import_playbook: ../prepare.yml
 
 - name: Prepare ArchLinux
   hosts: all
diff --git a/molecule/centos-stream-9-enterprise/prepare.yml b/molecule/centos-stream-9-enterprise/prepare.yml
@@ -1,22 +1,6 @@
 ---
-- name: Prepare controlling host
-  hosts: localhost
-  connection: local
-
-  tasks:
-    - name: Prepare CI environment
-      when: lookup('env', 'CI') is truthy
-      block:
-        - name: Install OS packages on controlling host
-          when: ansible_distribution != 'MacOSX'
-          ansible.builtin.package:
-            name: unzip
-          become: true
-
-        - name: Install netaddr dependency on controlling host
-          ansible.builtin.pip:
-            name: netaddr
-          become: false
+- name: Common prepare
+  ansible.builtin.import_playbook: ../prepare.yml
 
 - name: Prepare CentOS
   hosts: all
@@ -26,4 +10,4 @@
         path: /etc/shadow
         mode: '0640'
         owner: root
-        group: root
+        group: root
diff --git a/molecule/centos-stream-9/prepare.yml b/molecule/centos-stream-9/prepare.yml
@@ -1,22 +1,6 @@
 ---
-- name: Prepare controlling host
-  hosts: localhost
-  connection: local
-
-  tasks:
-    - name: Prepare CI environment
-      when: lookup('env', 'CI') is truthy
-      block:
-        - name: Install OS packages on controlling host
-          when: ansible_distribution != 'MacOSX'
-          ansible.builtin.package:
-            name: unzip
-          become: true
-
-        - name: Install netaddr dependency on controlling host
-          ansible.builtin.pip:
-            name: netaddr
-          become: false
+- name: Common prepare
+  ansible.builtin.import_playbook: ../prepare.yml
 
 - name: Prepare CentOS
   hosts: all
@@ -26,4 +10,4 @@
         path: /etc/shadow
         mode: '0640'
         owner: root
-        group: root
+        group: root
diff --git a/molecule/debian-13-enterprise/prepare.yml b/molecule/debian-13-enterprise/prepare.yml
@@ -1,26 +1,11 @@
 ---
-- name: Prepare controlling host
-  hosts: localhost
-  connection: local
-
-  tasks:
-    - name: Prepare CI environment
-      when: lookup('env', 'CI') is truthy
-      block:
-        - name: Install OS packages on controlling host
-          when: ansible_distribution != 'MacOSX'
-          ansible.builtin.package:
-            name: unzip
-          become: true
-
-        - name: Install netaddr dependency on controlling host
-          ansible.builtin.pip:
-            name: netaddr
-          become: false
-
 - name: Prepare Debian
   hosts: all
   gather_facts: false
   tasks:
     - name: Bootstrap Python
       ansible.builtin.raw: "test -e /usr/bin/python || apt-get install --update python3 -y"
+      changed_when: true
+
+- name: Common prepare
+  ansible.builtin.import_playbook: ../prepare.yml
diff --git a/molecule/debian-13/prepare.yml b/molecule/debian-13/prepare.yml
@@ -1,26 +1,11 @@
 ---
-- name: Prepare controlling host
-  hosts: localhost
-  connection: local
-
-  tasks:
-    - name: Prepare CI environment
-      when: lookup('env', 'CI') is truthy
-      block:
-        - name: Install OS packages on controlling host
-          when: ansible_distribution != 'MacOSX'
-          ansible.builtin.package:
-            name: unzip
-          become: true
-
-        - name: Install netaddr dependency on controlling host
-          ansible.builtin.pip:
-            name: netaddr
-          become: false
-
 - name: Prepare Debian
   hosts: all
   gather_facts: false
   tasks:
     - name: Bootstrap Python
       ansible.builtin.raw: "test -e /usr/bin/python || apt-get install --update python3 -y"
+      changed_when: true
+
+- name: Common prepare
+  ansible.builtin.import_playbook: ../prepare.yml
diff --git a/molecule/prepare.yml b/molecule/prepare.yml
@@ -1,5 +1,5 @@
 ---
-- name: Prepare
+- name: Prepare host
   hosts: localhost
   connection: local
 
@@ -9,11 +9,34 @@
       block:
         - name: Install OS packages on controlling host
           when: ansible_distribution != 'MacOSX'
-          package:
+          ansible.builtin.package:
             name: unzip
           become: true
 
         - name: Install netaddr dependency on controlling host
-          pip:
+          ansible.builtin.pip:
             name: netaddr
           become: false
+
+- name: Stub out vault enterprise service
+  hosts: all
+  tasks:
+    - name: Prepare CI environment
+      when:
+        - "'enterprise' in lookup('env', 'MOLECULE_SCENARIO_DIRECTORY')"
+        - ansible_service_mgr == "systemd"
+      block:
+        - name: Make sure dropin directory exists
+          ansible.builtin.file:
+            path: /etc/systemd/system/vault.service.d/
+            state: directory
+            mode: '0755'
+
+        - name: Write dropin file
+          ansible.builtin.copy:
+            dest: /etc/systemd/system/vault.service.d/fake-service.conf
+            mode: '0644'
+            content: |
+              [Service]
+              ExecStart=
+              ExecStart=/usr/bin/sleep 100000
diff --git a/molecule/rockylinux-9/prepare.yml b/molecule/rockylinux-9/prepare.yml
@@ -1,22 +1,6 @@
 ---
-- name: Prepare controlling host
-  hosts: localhost
-  connection: local
-
-  tasks:
-    - name: Prepare CI environment
-      when: lookup('env', 'CI') is truthy
-      block:
-        - name: Install OS packages on controlling host
-          when: ansible_distribution != 'MacOSX'
-          ansible.builtin.package:
-            name: unzip
-          become: true
-
-        - name: Install netaddr dependency on controlling host
-          ansible.builtin.pip:
-            name: netaddr
-          become: false
+- name: Common prepare
+  ansible.builtin.import_playbook: ../prepare.yml
 
 - name: Prepare Rocky
   hosts: all
@@ -26,4 +10,4 @@
         path: /etc/shadow
         mode: '0640'
         owner: root
-        group: root
+        group: root
