Fix CI with newest molecule (#303)

* Fix CI with newest molecule

Get rid of the use of  molecule ephemeral_directory() as it's gone.
The most affected test was the vagrant one, as it's checking the
generated Vagrantfile. Set the environment variable for the
ephemeral directory in this case, so that we know for sure
the path of the ephemeral directory.

Signed-off-by: Arnaud Patard <[email protected]>

* Update prettier pre-commit configuration

The repository has been archived, so don't use it.

Signed-off-by: Arnaud Patard <[email protected]>

---------

Signed-off-by: Arnaud Patard <[email protected]>

Author: apatard

.pre-commit-config.yaml

@@ -11,9 +11,9 @@ default_language_version:
   python: python3
 minimum_pre_commit_version: 1.14.0
 repos:
-  - repo: https://github.com/pre-commit/mirrors-prettier
+  - repo: https://github.com/pycontribs/mirrors-prettier
     # keep it before yamllint
-    rev: "v4.0.0-alpha.8"
+    rev: "v3.4.2"
     hooks:
       - id: prettier
         # Temporary excludes so we can gradually normalize the formatting

conftest.py

@@ -9,7 +9,6 @@
 
 from molecule import config, logger
 from molecule.app import get_app
-from molecule.scenario import ephemeral_directory
 
 LOG = logger.get_logger(__name__)
 
@@ -79,16 +78,6 @@ def get_molecule_file(path):
     return config.molecule_file(path)
 
 
-@pytest.helpers.register
-def molecule_ephemeral_directory(_fixture_uuid):
-    project_directory = f"test-project-{_fixture_uuid}"
-    scenario_name = "test-instance"
-
-    return ephemeral_directory(
-        os.path.join("molecule_test", project_directory, scenario_name),
-    )
-
-
 def metadata_lint_update(role_directory: str) -> None:
     # By default, ansible-lint will fail on newly-created roles because the
     # fields in this file have not been changed from their defaults. This is

test/vagrant-plugin/functional/test_func.py

@@ -30,7 +30,6 @@
 from conftest import change_dir_to
 from molecule import logger, util
 from molecule.app import get_app
-from molecule.scenario import ephemeral_directory
 
 LOG = logger.get_logger(__name__)
 
@@ -141,16 +140,17 @@ def test_multi_node(temp_dir):
         "scenarios",
     )
 
+    molecule_eph_directory = os.path.join(temp_dir, "ephemeral")
+    env = os.environ
+    env["MOLECULE_EPHEMERAL_DIRECTORY"] = molecule_eph_directory
+
     with change_dir_to(scenario_directory):
         cmd = ["molecule", "test", "--scenario-name", "multi-node"]
-        result = get_app(Path()).run_command(cmd)
+        result = get_app(Path()).run_command(cmd, env=env)
         assert result.returncode == 0
 
-    molecule_eph_directory = ephemeral_directory()
     vagrantfile = os.path.join(
         molecule_eph_directory,
-        "scenarios",
-        "multi-node",
         "Vagrantfile",
     )
     with open(vagrantfile) as f: