Moving cleaning up molecule_instance_config tasks to the of the block, because this task changes the when condition of the block immediately and following tasks will be skipped regardless ot their when condition.

Author: klaphi

src/molecule_plugins/ec2/cookiecutter/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/destroy.yml

@@ -111,11 +111,6 @@
           until: ec2_instances is finished
           retries: 300
 
-        - name: Write Molecule instance configs
-          ansible.builtin.copy:
-            dest: "{{ molecule_instance_config }}"
-            content: "{{ {} | to_yaml }}"
-
         - name: Destroy ephemeral security groups (if needed)
           amazon.aws.ec2_security_group:
             profile: "{{ item.aws_profile | default(omit) }}"
@@ -142,4 +137,9 @@
             index_var: index
             label: "{{ item.name }}"
           when: item.key_inject_method == "ec2"
+
+        - name: Write Molecule instance configs
+          ansible.builtin.copy:
+            dest: "{{ molecule_instance_config }}"
+            content: "{{ {} | to_yaml }}"
 {%- endraw %}