Perform linting on Ansible playbooks (#101)

* skip experimental rules

Signed-off-by: Thomas Sjögren <[email protected]>

* Lint ansible files

Signed-off-by: Thomas Sjögren <[email protected]>

* fix missed alignment

Signed-off-by: Thomas Sjögren <[email protected]>

* Fix blk100 flake8 errors

Flake8 is giving errors about some empty lines in the code, so
remove the line to fix these errors.

Signed-off-by: Arnaud Patard <[email protected]>

---------

Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Arnaud Patard <[email protected]>
Co-authored-by: Arnaud Patard <[email protected]>

Author: konstruktoid

.ansible-lint

@@ -9,9 +9,10 @@ exclude_paths:
 skip_list:
   # Temporary skips made during migration
   - args[module]
+  - experimental
   - fqcn-builtins
-  - yaml[line-length]
   - var-spacing
+  - yaml[line-length]
 
 mock_modules:
   - vagrant # only until we publish community.vagrant collection

molecule/test-podman/converge.yml

@@ -4,4 +4,4 @@
   tasks:
     - name: Test
       ansible.builtin.debug:
-        msg: it worked!
+        msg: "It worked!"

src/molecule_plugins/gce/playbooks/tasks/create_linux_instance.yml

@@ -5,7 +5,7 @@
     path: "{{ ssh_identity_file }}"
   register: keypair
 
-- name: Create molecule Linux instance(s)
+- name: "Create molecule Linux instance(s)"
   google.cloud.gcp_compute_instance:
     state: present
     name: "{{ item.name }}"

src/molecule_plugins/podman/cookiecutter/{{cookiecutter.molecule_directory}}/{{cookiecutter.scenario_name}}/converge.yml

@@ -7,6 +7,7 @@
       ansible.builtin.copy:
         src: /etc/hosts
         dest: /tmp/hosts-from-controller
+        mode: '0644'
     - name: "Include {{ cookiecutter.role_name }}"
       ansible.builtin.include_role:
         name: "{{ cookiecutter.role_name }}"