Merge pull request #45 from NilashishC/master

Fix empty handling in facts base

Reviewed-by: Nilashish Chakraborty <[email protected]>
             https://github.com/NilashishC

Author: ansible-zuul[bot]

rmb_tests/roles/my_role/library/myos_facts.py

@@ -14,7 +14,7 @@
     myos.facts.facts import Facts
 
 ANSIBLE_METADATA = {'metadata_version': '1.1',
-                    'status': ['preview'],
+                    'status': [u'preview'],
                     'supported_by': '<support_group>'}
 
 

rmb_tests/roles/my_role/module_utils/network/myos/facts/base.py

@@ -111,7 +111,7 @@ def generate_final_config(self, cfg_dict):
                 child_val = self.generate_final_config(val)
                 if child_val:
                     dct = {key: child_val}
-            elif val is not None:
+            elif val not in [None, [], {}, (), '']:
                 dct = {key: val}
             if dct:
                 final_cfg.update(dct)

roles/scaffold_rm_facts/templates/module_utils/network_os/facts/base.py.j2

@@ -111,7 +111,7 @@ class FactsBase(object):
                 child_val = self.generate_final_config(val)
                 if child_val:
                     dct = {key: child_val}
-            elif val is not None:
+            elif val not in [None, [], {}, (), '']:
                 dct = {key: val}
             if dct:
                 final_cfg.update(dct)