Merge pull request #42 from ansible-network/bt_fix_truthy_bug

Fix for elif truthy

Reviewed-by: Bradley A. Thornton
             https://github.com/cidrblock

Author: ansible-zuul[bot]

rmb_tests/roles/my_role/module_utils/network/myos/facts/base.py

@@ -111,7 +111,7 @@ def generate_final_config(self, cfg_dict):
                 child_val = self.generate_final_config(val)
                 if child_val:
                     dct = {key: child_val}
-            elif val:
+            elif val is not None:
                 dct = {key: val}
             if dct:
                 final_cfg.update(dct)

rmb_tests/roles/my_role/module_utils/network/myos/facts/interfaces/interfaces.py

@@ -84,9 +84,12 @@ def render_config(self, spec, conf):
         if match:
             config['some_dict']['property_01'] = match.groups()[0]
 
-        try:
-            config['some_bool'] = bool(self.parse_conf_arg(conf, 'a_bool'))
-        except TypeError:
+        a_bool = self.parse_conf_arg(conf, 'a_bool')
+        if a_bool == 'true':
+            config['some_bool'] = True
+        elif a_bool == 'false':
+            config['some_bool'] = False
+        else:
             config['some_bool'] = None
 
         try:

roles/resource_module/templates/module_utils/network_os/facts/base.py.j2

@@ -111,7 +111,7 @@ class FactsBase(object):
                 child_val = self.generate_final_config(val)
                 if child_val:
                     dct = {key: child_val}
-            elif val:
+            elif val is not None:
                 dct = {key: val}
             if dct:
                 final_cfg.update(dct)

roles/resource_module/templates/module_utils/network_os/facts/resource/resource.py.j2

@@ -84,9 +84,12 @@ class {{ resource|capitalize }}Facts(FactsBase):
         if match:
             config['some_dict']['property_01'] = match.groups()[0]
 
-        try:
-            config['some_bool'] = bool(self.parse_conf_arg(conf, 'a_bool'))
-        except TypeError:
+        a_bool = self.parse_conf_arg(conf, 'a_bool')
+        if a_bool == 'true':
+            config['some_bool'] = True
+        elif a_bool == 'false':
+            config['some_bool'] = False
+        else:
             config['some_bool'] = None
 
         try: