Skip to content

Commit ab51d36

Browse files
Merge pull request #26 from trishnaguha/fix_before_facts
fix facts generation for before key in result Reviewed-by: Trishna Guha <[email protected]> https://github.com/trishnaguha
2 parents 8bf3c2d + 5a37089 commit ab51d36

File tree

1 file changed

+7
-6
lines changed
  • roles/resource_module/templates/module_utils/network_os/config/resource

1 file changed

+7
-6
lines changed

roles/resource_module/templates/module_utils/network_os/config/resource/resource.py.j2

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,23 +51,24 @@ class {{ resource|capitalize }}(ConfigBase, {{ resource|capitalize }}Args):
5151
commands = list()
5252
warnings = list()
5353

54-
commands.extend(self.set_config())
54+
existing_{{ resource }}_facts = self.get_{{ resource }}_facts()
55+
commands.extend(self.set_config(existing_{{ resource }}_facts))
5556
if commands:
5657
if not self._module.check_mode:
5758
self._connection.edit_config(commands)
5859
result['changed'] = True
5960
result['commands'] = commands
6061

61-
{{ resource }}_facts = self.get_{{ resource }}_facts()
62+
changed_{{ resource }}_facts = self.get_{{ resource }}_facts()
6263

63-
result['before'] = {{ resource }}_facts
64+
result['before'] = existing_{{ resource }}_facts
6465
if result['changed']:
65-
result['after'] = {{ resource }}_facts
66+
result['after'] = changed_{{ resource }}_facts
6667

6768
result['warnings'] = warnings
6869
return result
6970

70-
def set_config(self):
71+
def set_config(self, existing_{{ resource }}_facts):
7172
""" Collect the configuration from the args passed to the module,
7273
collect the current configuration (as a dict from facts)
7374
@@ -76,7 +77,7 @@ class {{ resource|capitalize }}(ConfigBase, {{ resource|capitalize }}Args):
7677
to the desired configuration
7778
"""
7879
want = self._module.params['config']
79-
have = self.get_{{ resource }}_facts()
80+
have = existing_{{ resource }}_facts
8081
resp = self.set_state(want, have)
8182
return to_list(resp)
8283

0 commit comments

Comments
 (0)