simplift the pr_deployment flow (#1745)

- not output in the PR
- no more `TEST_RESULTS` variable
- use `$*` to pass the parameters to the functions
- only run a subset of the `sanity` test-suite, ansible/ansible-wisdom-testing#964
- print the direct URL of the test run

Author: goneri

.github/workflows/pr_deployment_test.yml

@@ -8,33 +8,25 @@ permissions:
   pull-requests: read
 
 jobs:
+  pr_deplolyment_test:
+    if: ${{ github.event.label.name == 'pr-deployment' }}
+    timeout-minutes: 10
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Wait for PR deployment completion
+        run: bash ./.github/workflows/scripts/pr_deployment_test.sh wait_for_pr_deployment ${{ github.event.number }} ${{ secrets.PR_DEPLOY_CLUSTER_HOSTNAME }}
+        shell: bash
   pr_testing:
     if: ${{ github.event.label.name == 'pr-deployment' }}
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write
-    needs: deployment_ready
+    needs: pr_deplolyment_test
     steps:
     - uses: actions/checkout@v4
     - name: Trigger tests on PR deployment
       id: test_pr
       run: |
-        TEST_RESULTS=$(bash ./.github/workflows/scripts/pr_deployment_test.sh invoke_pr_test 81148901 ${{ secrets.TESTING_TRIGGER_PAT }} ${{ github.event.number }})
-        echo "TEST_RESULTS=${TEST_RESULTS}" >> $GITHUB_OUTPUT
+        bash ./.github/workflows/scripts/pr_deployment_test.sh invoke_pr_test 81148901 ${{ secrets.TESTING_TRIGGER_PAT }} ${{ github.event.number }}
       shell: bash
-    - name: report test results
-      uses: mshick/add-pr-comment@v2
-      with:
-        message: |
-          ${{ steps.test_pr.outputs.TEST_RESULTS }}
-
-
-  deployment_ready:
-    if: ${{ github.event.label.name == 'pr-deployment' }}
-    timeout-minutes: 10
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - name: Wait for PR deployment completion
-        run: bash ./.github/workflows/scripts/pr_deployment_test.sh wait_for_pr_deployment ${{ github.event.number }} ${{ secrets.PR_DEPLOY_CLUSTER_HOSTNAME }}
-        shell: bash

.github/workflows/scripts/pr_deployment_test.sh

@@ -34,7 +34,7 @@ invoke_pr_test() {
     run_status=$(echo "$run_info" | jq -r '.status')
     if [[ $run_status == "completed" ]]; then
       conclusion=$(echo "$run_info" | jq -r '.conclusion')
-      echo "Tests execution https://api.github.com/repos/ansible/ansible-wisdom-testing/actions/runs/$RUN_ID completed with conclusion: $conclusion"
+      echo "Tests execution https://github.com/ansible/ansible-wisdom-testing/actions/runs/$RUN_ID completed with conclusion: $conclusion"
       if [[ $conclusion == "success" ]]; then
         exit 0
       else
@@ -74,4 +74,4 @@ wait_for_pr_deployment() {
   echo "Deployment probably is broken. Please check"
 }
 
-$1 $2 $3 $4 $5 $6 $7
+$*