Skip to content

Commit 7082b5d

Browse files
samccannAkasurdeoraNod
authored
address broken links in dev and appendices sections (#2402)
* fix some broken links * malformed link * Update docs/docsite/rst/dev_guide/developing_python_3.rst Co-authored-by: Abhijeet Kasurde <[email protected]> * Apply suggestions from code review Co-authored-by: Don Naro <[email protected]> --------- Co-authored-by: Abhijeet Kasurde <[email protected]> Co-authored-by: Don Naro <[email protected]>
1 parent d8c36a0 commit 7082b5d

11 files changed

+16
-33
lines changed

docs/docsite/rst/dev_guide/developing_collections_changelogs.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ To initialize changelog generation:
3232

3333
#. Install ``antsibull-changelog``: :code:`pip install antsibull-changelog`.
3434
#. Initialize changelogs for your repository: :code:`antsibull-changelog init <path/to/your/collection>`.
35-
#. Optionally, edit the ``changelogs/config.yaml`` file to customize the location of the generated changelog ``.rst`` file or other options. See `Bootstrapping changelogs for collections <https://github.com/ansible-community/antsibull-changelog/blob/main/docs/changelogs.rst#bootstrapping-changelogs-for-collections>`_ for details.
35+
#. Optionally, edit the ``changelogs/config.yaml`` file to customize the location of the generated changelog ``.rst`` file or other options. See `Bootstrapping changelogs for collections <https://ansible.readthedocs.io/projects/antsibull-changelog/changelogs/>`_ for details.
3636

3737
To generate changelogs from the changelog fragments you created:
3838

docs/docsite/rst/dev_guide/developing_collections_creating.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ To start a new collection, run the following command in your collections directo
6060
6161
.. note::
6262

63-
Both the namespace and collection names use the same strict set of requirements. See `Galaxy namespaces <https://galaxy.ansible.com/docs/contributing/namespaces.html#galaxy-namespaces>`_ on the Galaxy docsite for those requirements.
63+
Both the namespace and collection names use the same strict set of requirements. Both are limited to alphanumeric characters and underscores, must have a minimum length of two characters, and cannot start with an underscore.
6464

6565
It will create the structure ``[my_namespace]/[my_collection]/[collection skeleton]``.
6666

@@ -122,9 +122,9 @@ Creating collections with ansible-creator
122122

123123
The `Ansible Development Tools <https://ansible.readthedocs.io/projects/dev-tools/>`_ package offers a convenient way to install ``ansible-creator`` along with a curated set of tools for developing automation content.
124124

125-
After `installing <https://ansible.readthedocs.io/projects/creator/installing/#installation>`_ ``ansible-creator`` you can initialize a project in one of the following ways:
125+
After `installing <https://ansible.readthedocs.io/projects/creator/installing>`_ ``ansible-creator`` you can initialize a project in one of the following ways:
126126

127-
* Use the `init <https://ansible.readthedocs.io/projects/creator/installing/#initialize-ansible-collection-init-subcommand>`_ subcommand.
127+
* Use the ``init`` subcommand.
128128
* Use ``ansible-creator`` with the `Ansible extension <https://ansible.readthedocs.io/projects/creator/collection_creation/#step-1-installing-ansible-creator-in-the-environment>`_ in Visual Studio Code.
129129

130130
.. seealso::

docs/docsite/rst/dev_guide/developing_collections_structure.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ execution-environment.yml
291291

292292
If your collection has requirements, you can specify them in the ``execution-environment.yml`` file in the ``meta`` directory.
293293
This ensures users do not need to add these requirements manually when building :ref:`Execution Environments<getting_started_ee_index>` containing your collection.
294-
See the `collection-level metadata guide <https://ansible.readthedocs.io/projects/builder/en/stable/collection_metadata/#collection-level-metadata>`_ for details.
294+
See the `collection-level metadata guide <https://ansible.readthedocs.io/projects/builder/en/stable/collection_metadata/>`_ for details.
295295

296296
.. seealso::
297297

docs/docsite/rst/dev_guide/developing_modules_documenting.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ Since we moved to collections we have deprecated the METADATA functionality, it
7575
DOCUMENTATION block
7676
===================
7777

78-
After the shebang, the UTF-8 coding, the copyright line, and the license section comes the ``DOCUMENTATION`` block. Ansible's online module documentation is generated from the ``DOCUMENTATION`` blocks in each module's source code. The ``DOCUMENTATION`` block must be valid YAML. You may find it easier to start writing your ``DOCUMENTATION`` string in an :ref:`editor with YAML syntax highlighting <other_tools_and_programs>` before you include it in your Python file. You can start by copying our `example documentation string <https://github.com/ansible/ansible/blob/devel/examples/DOCUMENTATION.yml>`_ into your module file and modifying it. If you run into syntax issues in your YAML, you can validate it on the `YAML Lint <http://www.yamllint.com/>`_ website.
78+
After the shebang, the UTF-8 coding, the copyright line, and the license section comes the ``DOCUMENTATION`` block. Ansible's online module documentation is generated from the ``DOCUMENTATION`` blocks in each module's source code. The ``DOCUMENTATION`` block must be valid YAML. You may find it easier to start writing your ``DOCUMENTATION`` string in an :ref:`editor with YAML syntax highlighting <other_tools_and_programs>` before you include it in your Python file. You can start by copying our `example documentation string <https://github.com/ansible/ansible-documentation/blob/devel/examples/DOCUMENTATION.yml>`_ into your module file and modifying it. If you run into syntax issues in your YAML, you can validate it on the `YAML Lint <http://www.yamllint.com/>`_ website.
7979

8080
Module documentation should briefly and accurately define what each module and option does, and how it works with others in the underlying system. Documentation should be written for broad audience--readable both by experts and non-experts.
8181
* Descriptions should always start with a capital letter and end with a full stop. Consistency always helps.

docs/docsite/rst/dev_guide/developing_modules_general_windows.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,7 @@ the most popular ones are
644644
- `Powershell ISE`_
645645
- `Visual Studio Code`_
646646

647-
.. _Powershell ISE: https://docs.microsoft.com/en-us/powershell/scripting/core-powershell/ise/how-to-debug-scripts-in-windows-powershell-ise
647+
.. _Powershell ISE: https://learn.microsoft.com/en-us/powershell/scripting/windows-powershell/ise/how-to-debug-scripts-in-windows-powershell-ise?view=powershell-7.5
648648
.. _Visual Studio Code: https://blogs.technet.microsoft.com/heyscriptingguy/2017/02/06/debugging-powershell-script-in-visual-studio-code-part-1/
649649

650650
To be able to view the arguments as passed by Ansible to the module follow

docs/docsite/rst/dev_guide/developing_python_3.rst

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -372,22 +372,11 @@ is compatible with Python 2.6.
372372
Use percent format with byte strings
373373
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
374374

375-
In Python 3.x, byte strings do not have a ``format()`` method. However, it
375+
In Python 3.5 and later, byte strings do not have a ``format()`` method. However, it
376376
does have support for the older, percent-formatting.
377377

378378
.. code-block:: python
379379
380380
b_command_line = b'ansible-playbook --become-user %s -K %s' % (user, playbook_file)
381381
382-
.. note:: Percent formatting added in Python 3.5
383-
384-
Percent formatting of byte strings was added back into Python 3 in 3.5.
385-
This isn't a problem for us because Python 3.5 is our minimum version.
386-
However, if you happen to be testing Ansible code with Python 3.4 or
387-
earlier, you will find that the byte string formatting here won't work.
388-
Upgrade to Python 3.5 to test.
389-
390-
.. seealso::
391-
Python documentation on `percent formatting <https://docs.python.org/3/library/stdtypes.html#string-formatting>`_
392-
393382
.. _testing_modules_python_3:

docs/docsite/rst/dev_guide/style_guide/basic_rules.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ For menu procedures, bold the menu names, button names, and so on to help the us
6161
3. In the **Open** dialog box, click **Save**.
6262
4. On the toolbar, click the **Open File** icon.
6363

64-
For code or command snippets, use the RST `code-block directive <https://www.sphinx-doc.org/en/1.5/markup/code.html#directive-code-block>`_:
64+
For code or command snippets, use the RST `code-block directive <https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-code-block>`_:
6565

6666
.. code-block:: rst
6767

docs/docsite/rst/dev_guide/style_guide/index.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ For example, you can highlight Python code using following syntax:
174174
Internal navigation
175175
-------------------
176176

177-
`Anchors (also called labels) and links <https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#ref-role>`_
177+
`Anchors (also called labels) and links <https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-ref>`_
178178
work together to help users find related content.
179179
Local tables of contents also help users navigate quickly to the information they need.
180180
All internal links should use the ``:ref:`` syntax.
@@ -310,7 +310,7 @@ We follow these technical or mechanical guidelines on all .md pages:
310310
Heading notation
311311
----------------
312312

313-
`Section headings in markdown <https://daringfireball.net/projects/markdown/syntax#headers>`_
313+
`Section headings in markdown <https://daringfireball.net/projects/markdown/syntax#header>`_
314314
can use a variety of notations.
315315
To make our documents easy to read and to edit, we follow a standard set of heading notations.
316316
We use:

docs/docsite/rst/dev_guide/testing_units.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ To mock out fetching results from devices, or provide other complex data structu
173173
come from external libraries, you can use ``fixtures`` to read in pre-generated data.
174174

175175
You can check how `fixtures <https://github.com/ansible/ansible/tree/devel/test/units/module_utils/facts/fixtures/cpuinfo>`_
176-
are used in `cpuinfo fact tests <https://github.com/ansible/ansible/blob/9f72ff80e3fe173baac83d74748ad87cb6e20e64/test/units/module_utils/facts/hardware/linux_data.py#L384>`_
176+
are used in `CPU_INFO_TEST_SCENARIOS <https://github.com/ansible/ansible/blob/devel/test/units/module_utils/facts/hardware/linux_data.py>`_
177177

178178
If you are simulating APIs you may find that Python placebo is useful. See
179179
:ref:`testing_units_modules` for more information.

docs/docsite/rst/reference_appendices/faq.rst

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -199,14 +199,9 @@ the OS native package managers, such as `yum`, `dnf`, or `apt`, or as mentioned
199199

200200
Refer to the documentation of the respective package for such dependencies and their installation methods.
201201

202-
Common Platform Issues
202+
Common System Issues
203203
++++++++++++++++++++++
204204

205-
What customer platforms does Red Hat support?
206-
---------------------------------------------
207-
208-
A number of them! For a definitive list please see this `Knowledge Base article <https://access.redhat.com/articles/3168091>`_.
209-
210205
Running in a virtualenv
211206
-----------------------
212207

@@ -906,9 +901,8 @@ The native jinja2 functionality actually allows us to return full Python objects
906901
How do I submit a change to the documentation?
907902
++++++++++++++++++++++++++++++++++++++++++++++
908903

909-
Documentation for Ansible is kept in the main project Git repository, and complete instructions
910-
for contributing can be found in the docs README `viewable on GitHub <https://github.com/ansible/ansible/blob/devel/docs/docsite/README.md>`_. Thanks!
911-
904+
Documentation for Ansible is kept in the `ansible/ansible-documentation <https://github.com/ansible/ansible-documentation>`_
905+
project Git repository. See :ref:`community_documentation_contributions` for details.
912906

913907
.. _legacy_vs_builtin:
914908

0 commit comments

Comments
 (0)