Skip to content

Commit d646862

Browse files
authored
nox: run clone-core session in a venv as well (#1055)
Previously, the clone-core session ran in the global environment (`venv_backend="none"`) and instead of provisioning a venv. I did this to save time, as the clone-core session needs no other dependencies besides a python interpreter. This turned out to be shortsighted. It's better to just create an empty venv that we know we can call `python` in as opposed to relying on whatever `python` may or may not be on `$PATH`. Some systems may only have `python3` or have `python` pointing to the wrong thing. Fixes: #1054
1 parent ae7316a commit d646862

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def pip_compile(session: nox.Session, req: str):
110110
# fmt: on
111111

112112

113-
@nox.session(name="clone-core", venv_backend="none")
113+
@nox.session(name="clone-core")
114114
def clone_core(session: nox.Session):
115115
"""
116116
Clone relevant portions of ansible-core from ansible/ansible into the current

0 commit comments

Comments
 (0)