Skip to content

Commit 4438f72

Browse files
[AAP-50140]: Change azure ad authenticator plugin group setting default from Group to groups (#798)
## Description <!-- Mandatory: Provide a clear, concise description of the changes and their purpose --> - What is being changed? Changing the Azure AD authenticator plugin default value for the setting GROUPS_CLAIM from `Group` to `groups` per AAP-50140 - Why is this change needed? This aligns the Azure AD plugin better with the default values that come from EntraID (aka Azure AD) - How does this change address the issue? The default value for new authenticators would now correctly be set. ## Type of Change <!-- Mandatory: Check one or more boxes that apply --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Test update - [ ] Refactoring (no functional changes) - [ ] Development environment change - [X] Configuration change ## Self-Review Checklist <!-- These items help ensure quality - they complement our automated CI checks --> - [X] I have performed a self-review of my code - [X] I have added relevant comments to complex code sections - [X] I have updated documentation where needed - [X] I have considered the security impact of these changes - [X] I have considered performance implications - [X] I have thought about error handling and edge cases - [X] I have tested the changes in my local environment ## Testing Instructions <!-- Optional for test-only changes. Mandatory for all other changes --> <!-- Must be detailed enough for reviewers to reproduce --> ### Prerequisites <!-- List any specific setup required --> ### Steps to Test 1. Create a new authenticator plugin of type AzureAD note that the default value for GROUPS_CLAIMS should now be groups instead of Group. 2. 3. ### Expected Results <!-- Describe what should happen after following the steps --> ## Additional Context <!-- Optional but helpful information --> ### Required Actions <!-- Check if changes require work in other areas --> <!-- Remove section if no external actions needed --> - [ ] Requires documentation updates <!-- API docs, feature docs, deployment guides --> - [ ] Requires downstream repository changes <!-- Specify repos: django-ansible-base, eda-server, etc. --> - [ ] Requires infrastructure/deployment changes <!-- CI/CD, installer updates, new services --> - [ ] Requires coordination with other teams <!-- UI team, platform services, infrastructure --> - [ ] Blocked by PR/MR: #XXX <!-- Reference blocking PRs/MRs with brief context --> ### Screenshots/Logs <!-- Add if relevant to demonstrate the changes -->
1 parent b6ec2e8 commit 4438f72

File tree

1 file changed

+1
-1
lines changed
  • ansible_base/authentication/authenticator_plugins

1 file changed

+1
-1
lines changed

ansible_base/authentication/authenticator_plugins/azuread.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class AzureADConfiguration(BaseAuthenticatorConfiguration):
4141
help_text=_("The JSON key used to extract the user's groups from the ID token or userinfo endpoint."),
4242
required=False,
4343
allow_null=False,
44-
default="Group",
44+
default="groups",
4545
ui_field_label=_("Groups Claim"),
4646
)
4747

0 commit comments

Comments
 (0)