Skip to content

Commit 8230929

Browse files
authored
AAP-45589 - add comment for default timeout set up (#738)
## Description - What is being changed? Adding missing comment for default timeout - Why is this change needed? To improve the code readability - How does this change address the issue? Add a comment with the reason for timeout been 20 ## Type of Change <!-- Mandatory: Check one or more boxes that apply --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] Documentation update - [ ] Test update - [ ] Refactoring (no functional changes) - [ ] Development environment change - [ ] Configuration change ## Self-Review Checklist <!-- These items help ensure quality - they complement our automated CI checks --> - [ ] I have performed a self-review of my code - [ ] I have added relevant comments to complex code sections - [ ] I have updated documentation where needed - [ ] I have considered the security impact of these changes - [ ] I have considered performance implications - [ ] I have thought about error handling and edge cases - [ ] I have tested the changes in my local environment ## Testing Instructions ### Expected Results <!-- Describe what should happen after following the steps --> ## Additional Context <!-- Optional but helpful information --> ### Required Actions <!-- Check if changes require work in other areas --> <!-- Remove section if no external actions needed --> - [ ] Requires documentation updates <!-- API docs, feature docs, deployment guides --> - [ ] Requires downstream repository changes <!-- Specify repos: django-ansible-base, eda-server, etc. --> - [ ] Requires infrastructure/deployment changes <!-- CI/CD, installer updates, new services --> - [ ] Requires coordination with other teams <!-- UI team, platform services, infrastructure --> - [ ] Blocked by PR/MR: #XXX <!-- Reference blocking PRs/MRs with brief context --> ### Screenshots/Logs <!-- Add if relevant to demonstrate the changes -->
1 parent 8d236d4 commit 8230929

File tree

1 file changed

+1
-0
lines changed
  • ansible_base/authentication/authenticator_plugins

1 file changed

+1
-0
lines changed

ansible_base/authentication/authenticator_plugins/ldap.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,6 +379,7 @@ def __init__(self, prefix: str = 'AUTH_LDAP_', defaults: dict = {}):
379379

380380
# If a DB-backed setting is specified that wipes out the
381381
# OPT_NETWORK_TIMEOUT, fall back to a sane default
382+
# This default should be less than 30 because that is the timeout of envoy
382383
if ldap.OPT_NETWORK_TIMEOUT not in internal_data:
383384
internal_data[ldap.OPT_NETWORK_TIMEOUT] = 20
384385

0 commit comments

Comments
 (0)