Skip to content

Commit 9c7453b

Browse files
Removed default None file in Azure AD authenticator (#807)
## Description <!-- Mandatory: Provide a clear, concise description of the changes and their purpose --> - What is being changed? The default value for the config item was set to None. This caused a null value to show up in the UI, when then saving it get the string "null" and save that into the database. - Why is this change needed? We end up setting this field to "null" on change. - How does this change address the issue? We no longer send the UI the "None" value and thus the UI won't send us the "null" value back. ## Type of Change <!-- Mandatory: Check one or more boxes that apply --> - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Test update - [ ] Refactoring (no functional changes) - [ ] Development environment change - [ ] Configuration change ## Self-Review Checklist <!-- These items help ensure quality - they complement our automated CI checks --> - [X] I have performed a self-review of my code - [X] I have added relevant comments to complex code sections - [X] I have updated documentation where needed - [x] I have considered the security impact of these changes - [x] I have considered performance implications - [x] I have thought about error handling and edge cases - [x] I have tested the changes in my local environment ## Testing Instructions <!-- Optional for test-only changes. Mandatory for all other changes --> <!-- Must be detailed enough for reviewers to reproduce --> ### Prerequisites <!-- List any specific setup required --> ### Steps to Test 1. Create an azure ad authenticator with junk it in. Note that the default value for the Username is "null". Save the authenticator. Look at the authenticator in the API it will have a string value of "null". 2. Apply the patch and everything will be good. 3. ### Expected Results <!-- Describe what should happen after following the steps --> ## Additional Context <!-- Optional but helpful information --> ### Required Actions <!-- Check if changes require work in other areas --> <!-- Remove section if no external actions needed --> - [ ] Requires documentation updates <!-- API docs, feature docs, deployment guides --> - [ ] Requires downstream repository changes <!-- Specify repos: django-ansible-base, eda-server, etc. --> - [ ] Requires infrastructure/deployment changes <!-- CI/CD, installer updates, new services --> - [ ] Requires coordination with other teams <!-- UI team, platform services, infrastructure --> - [ ] Blocked by PR/MR: #XXX <!-- Reference blocking PRs/MRs with brief context --> ### Screenshots/Logs <!-- Add if relevant to demonstrate the changes -->
1 parent 3058952 commit 9c7453b

File tree

1 file changed

+0
-1
lines changed
  • ansible_base/authentication/authenticator_plugins

1 file changed

+0
-1
lines changed

ansible_base/authentication/authenticator_plugins/azuread.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ class AzureADConfiguration(BaseAuthenticatorConfiguration):
4949
help_text=_("The name of the field from the assertion to use as the username. If not set will default to name"),
5050
required=False,
5151
allow_null=True,
52-
default=None,
5352
ui_field_label=_("Field to use as username"),
5453
)
5554

0 commit comments

Comments
 (0)