Add feature flag management command

Author: zkayyali812

ansible_base/feature_flags/management/__init__.py

@@ -0,0 +1,50 @@
+try:
+    from tabulate import tabulate
+
+    HAS_TABULATE = True
+except ImportError:
+    HAS_TABULATE = False
+
+from django.core.management.base import BaseCommand
+from flags.state import flag_state
+
+from ansible_base.feature_flags.models import AAPFlag
+
+
+class Command(BaseCommand):
+    help = "AAP Feature Flag management command"
+
+    def add_arguments(self, parser):
+        parser.add_argument("--list", action="store_true", help="List feature flags", required=False)
+
+    def handle(self, *args, **options):
+        if options["list"]:
+            self.list_feature_flags()
+
+    def list_feature_flags(self):
+        feature_flags = []
+        headers = ["Name", "UI_Name", "Value", "State", "Support Level", "Visibility", "Toggle Type", "Description", "Support URL"]
+
+        for feature_flag in AAPFlag.objects.all().order_by('name'):
+            feature_flags.append(
+                [
+                    f'{feature_flag.name}',
+                    f'{feature_flag.ui_name}',
+                    f'{feature_flag.value}',
+                    f'{flag_state(feature_flag.name)}',
+                    f'{feature_flag.support_level}',
+                    f'{feature_flag.visibility}',
+                    f'{feature_flag.toggle_type}',
+                    f'{feature_flag.description}',
+                    f'{feature_flag.support_url}',
+                ]
+            )
+        self.stdout.write('')
+
+        if HAS_TABULATE:
+            self.stdout.write(tabulate(feature_flags, headers, tablefmt="github"))
+        else:
+            self.stdout.write("\t".join(headers))
+            for feature_flag in feature_flags:
+                self.stdout.write("\t".join(feature_flag))
+        self.stdout.write('')

ansible_base/feature_flags/management/commands/__init__.py

@@ -4,7 +4,8 @@
 
 from ansible_base.activitystream.models import AuditableModel
 from ansible_base.lib.abstract_models.common import NamedCommonModel
-from ansible_base.resource_registry.fields import AnsibleResourceField
+
+# from ansible_base.resource_registry.fields import AnsibleResourceField
 
 
 def validate_feature_flag_name(value: str):
@@ -34,12 +35,7 @@ def __str__(self):
         validators=[validate_feature_flag_name],
         blank=False,
     )
-    ui_name = models.CharField(
-        max_length=64,
-        null=False,
-        blank=False,
-        help_text=_("The pretty name to display in the application User Interface")
-    )
+    ui_name = models.CharField(max_length=64, null=False, blank=False, help_text=_("The pretty name to display in the application User Interface"))
     condition = models.CharField(max_length=64, default="boolean", help_text=_("Used to specify a condition, which if met, will enable the feature flag."))
     value = models.CharField(max_length=127, default="True", help_text=_("The value used to evaluate the conditional specified."))
     required = models.BooleanField(

ansible_base/feature_flags/management/commands/feature_flags.py

@@ -1,4 +1,5 @@
 from django.apps import apps
+from django.conf import settings
 from django.core.exceptions import ValidationError
 from flags.sources import get_flags
 
@@ -51,6 +52,8 @@ def load_feature_flags():
                 if existing_flag:
                     update_feature_flag(existing_flag.first(), flag)
                 else:
+                    if hasattr(settings, flag['name']):
+                        flag['value'] = getattr(settings, flag['name'])
                     FeatureFlags.objects.create(**flag)
                 AAPFlag(**flag).full_clean()
             except ValidationError as e:

ansible_base/feature_flags/models/aap_flag.py

@@ -1,6 +1,6 @@
 from django.shortcuts import get_object_or_404
 from django.utils.translation import gettext_lazy as _
-from flags.state import flag_enabled, flag_state, get_flags
+from flags.state import flag_enabled
 from rest_framework import status
 from rest_framework.response import Response
 from rest_framework.viewsets import ModelViewSet
@@ -10,7 +10,6 @@
 from ansible_base.lib.utils.views.ansible_base import AnsibleBaseView
 from ansible_base.lib.utils.views.django_app_api import AnsibleBaseDjangoAppApiView
 from ansible_base.lib.utils.views.permissions import IsSuperuserOrAuditor
-from ansible_base.rest_pagination import DefaultPaginator
 
 from .utils import get_django_flags, is_boolean_str
 
@@ -31,10 +30,6 @@ def update(self, request, **kwargs):
         if not value:
             return Response(status=status.HTTP_400_BAD_REQUEST, data={"details": "Invalid request object."})
 
-        # Disable runtime toggle if the feature flag feature is not enabled
-        if not flag_enabled('FEATURE_FEATURE_FLAGS_ENABLED'):
-            return Response(status=status.HTTP_405_METHOD_NOT_ALLOWED, data={"details": "Runtime feature flags toggle is not enabled."})
-
         feature_flag = get_object_or_404(AAPFlag, pk=_feature_flag.id)
         if feature_flag.toggle_type == 'install-time':
             return Response(status=status.HTTP_405_METHOD_NOT_ALLOWED, data={"details": "Install-time feature flags cannot be toggled at run-time."})

ansible_base/feature_flags/utils.py

@@ -16,19 +16,6 @@ class AAPFlagNameSchema(TypedDict):
 
 
 AAP_FEATURE_FLAGS: list[AAPFlagNameSchema] = [
-    AAPFlagNameSchema(
-        name="FEATURE_FEATURE_FLAGS_ENABLED",
-        ui_name="Feature Flags",
-        condition="boolean",
-        value="True",
-        support_level='READY_FOR_PRODUCTION',
-        visibility="public",
-        toggle_type='install-time',
-        description='If enabled, feature flags can be toggled on/off at runtime via UI or API. '
-        'If disabled, feature flags can only be toggled on/off at install-time.',
-        support_url="",
-        labels=['platform'],
-    ),
     AAPFlagNameSchema(
         name="FEATURE_INDIRECT_NODE_COUNTING_ENABLED",
         ui_name="Indirect Node Counting",

ansible_base/feature_flags/views.py

@@ -14,5 +14,3 @@ def test_feature_flags_state_api_list(admin_api_client: APIClient):
     assert response.data["FEATURE_EDA_ANALYTICS_ENABLED"] is False
     assert 'FEATURE_INDIRECT_NODE_COUNTING_ENABLED' in response.data
     assert response.data["FEATURE_INDIRECT_NODE_COUNTING_ENABLED"] is False
-    assert 'FEATURE_FEATURE_FLAGS_ENABLED' in response.data
-    assert response.data["FEATURE_FEATURE_FLAGS_ENABLED"] is True