Refactor view to gateway

Author: zkayyali812

ansible_base/feature_flags/apps.py

@@ -1,8 +1,17 @@
 from django.apps import AppConfig
+from django.db.models.signals import post_migrate
+
+from ansible_base.feature_flags.utils import create_initial_data
 
 
 class FeatureFlagsConfig(AppConfig):
     default_auto_field = 'django.db.models.BigAutoField'
     name = 'ansible_base.feature_flags'
     label = 'dab_feature_flags'
     verbose_name = 'Feature Flags'
+
+    def ready(self):
+        try:
+            create_initial_data()
+        except Exception:
+            post_migrate.connect(create_initial_data, sender=self)

ansible_base/feature_flags/migrations/0001_initial.py

@@ -1,4 +1,4 @@
-# Generated by Django 4.2.17 on 2025-06-04 12:00
+# Generated by Django 4.2.17 on 2025-06-06 16:22
 
 import ansible_base.feature_flags.models.aap_flag
 from django.conf import settings
@@ -24,7 +24,7 @@ class Migration(migrations.Migration):
                 ('name', models.CharField(help_text='The name of the feature flag. Must follow the format of FEATURE_<flag-name>_ENABLED.', max_length=64, validators=[ansible_base.feature_flags.models.aap_flag.validate_feature_flag_name])),
                 ('ui_name', models.CharField(help_text='The pretty name to display in the application User Interface', max_length=64)),
                 ('condition', models.CharField(default='boolean', help_text='Used to specify a condition, which if met, will enable the feature flag.', max_length=64)),
-                ('value', models.CharField(default='True', help_text='The value used to evaluate the conditional specified.', max_length=127)),
+                ('value', models.CharField(default='False', help_text='The value used to evaluate the conditional specified.', max_length=127)),
                 ('required', models.BooleanField(default=False, help_text="If multiple conditions are required to be met to enable a feature flag, 'required' can be used to specify the necessary conditionals.")),
                 ('support_level', models.CharField(choices=[('NOT_FOR_USE', 'Not for use'), ('NOT_FOR_PRODUCTION', 'Not for production'), ('READY_FOR_PRODUCTION', 'Ready for production')], help_text='The support criteria for the feature flag. Must be one of (NOT_FOR_USE, NOT_FOR_PRODUCTION, READY_FOR_PRODUCTION).', max_length=25)),
                 ('visibility', models.CharField(choices=[('public', 'public'), ('private', 'private')], help_text='The visibility level of the feature flag. If private, flag is hidden.', max_length=20)),

ansible_base/feature_flags/models/aap_flag.py

@@ -35,7 +35,11 @@ def __str__(self):
     )
     ui_name = models.CharField(max_length=64, null=False, blank=False, help_text=_("The pretty name to display in the application User Interface"))
     condition = models.CharField(max_length=64, default="boolean", help_text=_("Used to specify a condition, which if met, will enable the feature flag."))
-    value = models.CharField(max_length=127, default="True", help_text=_("The value used to evaluate the conditional specified."))
+    value = models.CharField(
+        max_length=127,
+        default="False",
+        help_text=_("The value used to evaluate the conditional specified."),
+    )
     required = models.BooleanField(
         default=False,
         help_text=_("If multiple conditions are required to be met to enable a feature flag, 'required' can be used to specify the necessary conditionals."),

ansible_base/feature_flags/serializers.py

@@ -1,31 +1,11 @@
 from flags.state import flag_state
-from rest_framework import serializers
 
 from ansible_base.feature_flags.models import AAPFlag
 from ansible_base.lib.serializers.common import NamedCommonModelSerializer
 
 from .utils import get_django_flags
 
 
-class FeatureFlagSerializer(NamedCommonModelSerializer):
-    """Serialize list of feature flags"""
-
-    state = serializers.SerializerMethodField()
-
-    class Meta:
-        model = AAPFlag
-        fields = NamedCommonModelSerializer.Meta.fields + [x.name for x in AAPFlag._meta.concrete_fields] + ['state']
-        read_only_fields = ["name", "condition", "required", "support_level", "visibility", "toggle_type", "description", "labels", "ui_name", "support_url"]
-
-    def get_state(self, instance):
-        return flag_state(instance.name)
-
-    def to_representation(self, instance):
-        instance.state = True
-        ret = super().to_representation(instance)
-        return ret
-
-
 # TODO: Remove once all components are migrated to the new endpont.
 class OldFeatureFlagSerializer(NamedCommonModelSerializer):
     """Serialize list of feature flags"""

ansible_base/feature_flags/urls.py

@@ -9,8 +9,6 @@
 router = AssociationResourceRouter()
 
 router.register(r'feature_flags/states', views.FeatureFlagsStatesView, basename='aap_flags_states')
-router.register(r'feature_flags', views.FeatureFlagsView, basename='aap_flags')
-
 # TODO: Remove once all components are migrated to new endpoints.
 api_version_urls = [path('feature_flags_state/', views.OldFeatureFlagsStateListView.as_view(), name='feature-flags-state-list'), path('', include(router.urls))]
 

ansible_base/feature_flags/utils.py

@@ -42,6 +42,8 @@ def load_feature_flags():
     """
     Loads in all feature flags into the database. Updates them if necessary.
     """
+    from ansible_base.resource_registry.signals.handlers import no_reverse_sync
+
     feature_flags_model = apps.get_model('dab_feature_flags', 'AAPFlag')
     for flag in AAP_FEATURE_FLAGS:
         try:
@@ -53,7 +55,8 @@ def load_feature_flags():
                     flag['value'] = getattr(settings, flag['name'])
                 feature_flag = feature_flags_model(**flag)
             feature_flag.full_clean()
-            feature_flag.save()
+            with no_reverse_sync():
+                feature_flag.save()
         except ValidationError as e:
             # Ignore this error unless better way to bypass this
             if e.messages[0] == 'Aap flag with this Name and Condition already exists.':
@@ -67,6 +70,8 @@ def delete_feature_flags():
     """
     If a feature flag has been removed from the platform flags list, delete it from the database.
     """
+    from ansible_base.resource_registry.signals.handlers import no_reverse_sync
+
     all_flags = apps.get_model('dab_feature_flags', 'AAPFlag').objects.all()
     for flag in all_flags:
         found = False
@@ -78,4 +83,5 @@ def delete_feature_flags():
             continue
         if not found:
             logger.info(f"Deleting feature flag: {flag.name} as it is no longer available as a platform flag")
-            flag.delete()
+            with no_reverse_sync():
+                flag.delete()

ansible_base/feature_flags/views.py

@@ -5,7 +5,7 @@
 from rest_framework.viewsets import ModelViewSet
 
 from ansible_base.feature_flags.models import AAPFlag
-from ansible_base.feature_flags.serializers import FeatureFlagSerializer, OldFeatureFlagSerializer
+from ansible_base.feature_flags.serializers import OldFeatureFlagSerializer
 from ansible_base.lib.utils.views.ansible_base import AnsibleBaseView
 from ansible_base.lib.utils.views.django_app_api import AnsibleBaseDjangoAppApiView
 from ansible_base.lib.utils.views.permissions import IsSuperuserOrAuditor, try_add_oauth2_scope_permission
@@ -14,17 +14,6 @@
 from .utils import get_django_flags
 
 
-class FeatureFlagsView(AnsibleBaseDjangoAppApiView, ModelViewSet):
-    """
-    A view class for displaying feature flags
-    """
-
-    queryset = AAPFlag.objects.order_by('id')
-    serializer_class = FeatureFlagSerializer
-    permission_classes = try_add_oauth2_scope_permission([IsSuperuserOrAuditor])
-    http_method_names = ['get', 'head', 'options']
-
-
 class FeatureFlagsStatesView(AnsibleBaseDjangoAppApiView, ModelViewSet):
     """
     A view class for displaying feature flags states

ansible_base/lib/dynamic_config/settings_logic.py

@@ -306,12 +306,7 @@ def get_mergeable_dab_settings(settings: dict) -> dict:  # NOSONAR
         if "flags" not in installed_apps:
             installed_apps.append('flags')
 
-        # After all flags are migrated to database flags, remove settings flag source
-        # Settings flag source is defined for compatibility until migration is complete
-        dab_data['FLAG_SOURCES'] = (
-            'flags.sources.SettingsFlagsSource',
-            'ansible_base.feature_flags.flag_source.AAPFlagSource',
-        )
+        dab_data['FLAG_SOURCES'] = ('ansible_base.feature_flags.flag_source.AAPFlagSource',)
 
         found_template_backend = False
         template_context_processor = 'django.template.context_processors.request'

ansible_base/rbac/permission_registry.py

@@ -143,7 +143,6 @@ def create_managed_roles(self, apps) -> list[tuple[Model, bool]]:
         return ret
 
     def call_when_apps_ready(self, apps, app_config) -> None:
-        from ansible_base.feature_flags.utils import create_initial_data as feature_flag_create_initial_data
         from ansible_base.rbac import triggers
         from ansible_base.rbac.evaluations import bound_has_obj_perm, bound_singleton_permissions, connect_rbac_methods
         from ansible_base.rbac.management import create_dab_permissions
@@ -173,11 +172,6 @@ def call_when_apps_ready(self, apps, app_config) -> None:
             sender=app_config,
             dispatch_uid="ansible_base.rbac.triggers.post_migration_rbac_setup",
         )
-        if 'ansible_base.feature_flags' in settings.INSTALLED_APPS:
-            try:
-                feature_flag_create_initial_data()
-            except Exception:
-                post_migrate.connect(feature_flag_create_initial_data, sender=self)
 
         self.user_model.add_to_class('has_obj_perm', bound_has_obj_perm)
         self.user_model.add_to_class('singleton_permissions', bound_singleton_permissions)

test_app/tests/feature_flags/models/test_aap_flag.py

@@ -41,6 +41,7 @@ def test_feature_flags_from_db(aap_flags, feature_flag):
     ],
 )
 def test_feature_flag_database_setting_override(feature_flag, value):
+    AAPFlag.objects.all().delete()
     from ansible_base.feature_flags.utils import create_initial_data
 
     setattr(settings, feature_flag, value)